From: Takashi Iwai <tiwai@suse.de>
To: "José Expósito" <jose.exposito89@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
linux-input@vger.kernel.org,
Peter Hutterer <peter.hutterer@who-t.net>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jkosina@suse.cz>,
stable@vger.kernel.org, regressions@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] Right touchpad button disabled on Dell 7750
Date: Fri, 18 Mar 2022 14:11:39 +0100 [thread overview]
Message-ID: <s5hlex72yno.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220318130740.GA33535@elementary>
On Fri, 18 Mar 2022 14:07:40 +0100,
José Expósito wrote:
>
> Hi Takashi,
>
> Thanks for reporting the regression here.
>
> On Fri, Mar 18, 2022 at 12:42:31PM +0100, Takashi Iwai wrote:
> > Hi,
> >
> > we received a bug report about the regression of the touchpad on Dell
> > 7750 laptop, the right touchpad button is disabled on recent kernels:
> > https://bugzilla.suse.com/show_bug.cgi?id=1197243
> >
> > Note that it's a physical button, not a virtual clickpad button.
> >
> > The regression seems introduced by the upstream commit
> > 37ef4c19b4c659926ce65a7ac709ceaefb211c40 ("Input: clear
> > BTN_RIGHT/MIDDLE on buttonpads") that was backported to stable 5.16.x
> > kernel.
> >
> > The device is managed by hid-multitouch driver, and the further
> > investigation revealed that it's rather an incorrectly recognized
> > buttonpad property; namely, ID_DG_BUTTONTYPE reports it being 0 =
> > clickable touchpad although it's not. I built a test kernel to ignore
> > this check and it was confirmed to make the right button working again
> > by the reporter.
> >
> > Is this check really correct in general? Or do we need some
> > device-specific quirk?
>
> A couple of days ago another user with the same laptop (Dell Precision
> 7550 or 7750) emailed me to report the issue and I sent him a patch for
> testing.
>
> I he confirms that the patch works, I'll send it to the mailing list.
>
> I believe that your analysis of the regression is correct and I think
> that we'd need to add a quirk for the device.
>
> In case you want to have a look to the patch, I added it to this
> libinput [1] report.
Great, I'll try to build and ask the reporter to test with the patch.
Thanks!
Takashi
>
> Thanks,
> Jose
>
> [1] https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/726#note_1303623
>
next prev parent reply other threads:[~2022-03-18 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 11:42 [REGRESSION] Right touchpad button disabled on Dell 7750 Takashi Iwai
2022-03-18 13:07 ` José Expósito
2022-03-18 13:11 ` Takashi Iwai [this message]
2022-03-18 14:06 ` Benjamin Tissoires
2022-03-18 14:28 ` José Expósito
2022-03-18 14:37 ` Takashi Iwai
2022-03-18 16:05 ` José Expósito
2022-03-18 22:01 ` [PATCH] HID: multitouch: fix Dell Precision 7550 and 7750 button type kernel test robot
2022-03-19 8:10 ` [REGRESSION] Right touchpad button disabled on Dell 7750 Takashi Iwai
2022-03-20 19:12 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlex72yno.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).