stgt.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] targets.conf manpage should not refer to Wikipedia
@ 2016-01-19 17:28 Andy Grover
  2016-01-20 10:11 ` FUJITA Tomonori
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Grover @ 2016-01-19 17:28 UTC (permalink / raw)
  To: stgt

Man pages should not assume the user has network access to reach
Wikipedia for more information -- if the information is important they
should just include it directly. In this instance, I don't think
this info is important enough, and we should just remove the
reference.

See https://bugzilla.redhat.com/show_bug.cgi?id=1038326 for the
original bug report.

Signed-off-by: Andy Grover <agrover@redhat.com>
---
 doc/targets.conf.5.xml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/targets.conf.5.xml b/doc/targets.conf.5.xml
index 833e40a..84a4f97 100644
--- a/doc/targets.conf.5.xml
+++ b/doc/targets.conf.5.xml
@@ -50,8 +50,7 @@
         <listitem>
           <para>
 	    Defines a the start of a target definition. IQN is an ISCSI Qualified
-	    Name such as "iqn.2001-04.com.example:storage1". See "ISCSI" on
-	    Wikipedia for more information on IQNs.
+	    Name such as "iqn.2001-04.com.example:storage1".
           </para>
 	  <para>
 	    Within this block should be target-level directives, as
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] targets.conf manpage should not refer to Wikipedia
  2016-01-19 17:28 [PATCH] targets.conf manpage should not refer to Wikipedia Andy Grover
@ 2016-01-20 10:11 ` FUJITA Tomonori
  0 siblings, 0 replies; 2+ messages in thread
From: FUJITA Tomonori @ 2016-01-20 10:11 UTC (permalink / raw)
  To: agrover; +Cc: stgt

On Tue, 19 Jan 2016 09:28:53 -0800
Andy Grover <agrover@redhat.com> wrote:

> Man pages should not assume the user has network access to reach
> Wikipedia for more information -- if the information is important they
> should just include it directly. In this instance, I don't think
> this info is important enough, and we should just remove the
> reference.
> 
> See https://bugzilla.redhat.com/show_bug.cgi?id=1038326 for the
> original bug report.
> 
> Signed-off-by: Andy Grover <agrover@redhat.com>
> ---
>  doc/targets.conf.5.xml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-20 10:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-19 17:28 [PATCH] targets.conf manpage should not refer to Wikipedia Andy Grover
2016-01-20 10:11 ` FUJITA Tomonori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).