* b4 not finding patches
@ 2020-03-18 20:23 Mark Brown
2020-03-18 20:38 ` Konstantin Ryabitsev
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2020-03-18 20:23 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: tools
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
When I run
b4 am -t 87y2s0olg6.wl-kuninori.morimoto.gx@renesas.com
it says:
| Grabbing thread from lore.kernel.org
| Analyzing 13 messages in the thread
| Found new series v1
| Will use the latest revision: v3
| You can pick other revisions using the -vN flag
| ---
| Writing ./v3_20200316_kuninori_morimoto_gx_renesas_com.mbx
| ERROR: missing [1/6]!
| ERROR: missing [2/6]!
| ERROR: missing [3/6]!
| ERROR: missing [4/6]!
| ERROR: missing [5/6]!
| ERROR: missing [6/6]!
| ---
| Total patches: 0
| ---
even though lore appears to have the full thread:
https://lore.kernel.org/alsa-devel/87wo7kolfa.wl-kuninori.morimoto.gx@renesas.com/
Thanks,
Mark
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 not finding patches
2020-03-18 20:23 b4 not finding patches Mark Brown
@ 2020-03-18 20:38 ` Konstantin Ryabitsev
2020-03-18 20:59 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-03-18 20:38 UTC (permalink / raw)
To: Mark Brown; +Cc: tools
On Wed, Mar 18, 2020 at 08:23:35PM +0000, Mark Brown wrote:
> When I run
>
> b4 am -t 87y2s0olg6.wl-kuninori.morimoto.gx@renesas.com
>
> it says:
>
> | Grabbing thread from lore.kernel.org
> | Analyzing 13 messages in the thread
> | Found new series v1
> | Will use the latest revision: v3
> | You can pick other revisions using the -vN flag
> | ---
> | Writing ./v3_20200316_kuninori_morimoto_gx_renesas_com.mbx
> | ERROR: missing [1/6]!
> | ERROR: missing [2/6]!
> | ERROR: missing [3/6]!
> | ERROR: missing [4/6]!
> | ERROR: missing [5/6]!
> | ERROR: missing [6/6]!
> | ---
> | Total patches: 0
> | ---
>
> even though lore appears to have the full thread:
>
> https://lore.kernel.org/alsa-devel/87wo7kolfa.wl-kuninori.morimoto.gx@renesas.com/
This is because the cover letter is the only bit where we see "v3":
> [PATCH v3 0/6]
all other messages have
> [PATCH N/6]
I'm not sure if there is a reliably clean way of handling this
situation, but I'll think about it. For this particular case, you can
just pass -v1 to "b4 am" to grab the actual patches.
-K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 not finding patches
2020-03-18 20:38 ` Konstantin Ryabitsev
@ 2020-03-18 20:59 ` Mark Brown
2020-03-18 21:07 ` Konstantin Ryabitsev
2020-03-18 22:18 ` Konstantin Ryabitsev
0 siblings, 2 replies; 6+ messages in thread
From: Mark Brown @ 2020-03-18 20:59 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: tools
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On Wed, Mar 18, 2020 at 04:38:38PM -0400, Konstantin Ryabitsev wrote:
> On Wed, Mar 18, 2020 at 08:23:35PM +0000, Mark Brown wrote:
> > https://lore.kernel.org/alsa-devel/87wo7kolfa.wl-kuninori.morimoto.gx@renesas.com/
> This is because the cover letter is the only bit where we see "v3":
> > [PATCH v3 0/6]
> all other messages have
> > [PATCH N/6]
> I'm not sure if there is a reliably clean way of handling this
> situation, but I'll think about it. For this particular case, you can
> just pass -v1 to "b4 am" to grab the actual patches.
...but not the tags added to the cover letter which is the main reason
I'm doing this :/ . I do see the issue given people sending new
serieses in reply to existing ones though. Perhaps some heuristic about
lack of ambiguity (eg, if we're looking for six patches and find exactly
six patches)?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 not finding patches
2020-03-18 20:59 ` Mark Brown
@ 2020-03-18 21:07 ` Konstantin Ryabitsev
2020-03-18 22:18 ` Konstantin Ryabitsev
1 sibling, 0 replies; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-03-18 21:07 UTC (permalink / raw)
To: Mark Brown; +Cc: tools
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
On Wed, Mar 18, 2020 at 08:59:14PM +0000, Mark Brown wrote:
> > > https://lore.kernel.org/alsa-devel/87wo7kolfa.wl-kuninori.morimoto.gx@renesas.com/
>
> > This is because the cover letter is the only bit where we see "v3":
>
> > > [PATCH v3 0/6]
>
> > all other messages have
>
> > > [PATCH N/6]
>
> > I'm not sure if there is a reliably clean way of handling this
> > situation, but I'll think about it. For this particular case, you can
> > just pass -v1 to "b4 am" to grab the actual patches.
>
> ...but not the tags added to the cover letter which is the main reason
> I'm doing this :/ . I do see the issue given people sending new
> serieses in reply to existing ones though. Perhaps some heuristic about
> lack of ambiguity (eg, if we're looking for six patches and find exactly
> six patches)?
This case is probably easier, because it properly threads those patches
below the cover letter. I'll work in some logic to handle cases like
that:
- patches have no explicit version info
- the 00/NN immediately upthread specifies version
in this case we can fairly safely apply the cover letter version info to
all patches.
-K
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 235 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 not finding patches
2020-03-18 20:59 ` Mark Brown
2020-03-18 21:07 ` Konstantin Ryabitsev
@ 2020-03-18 22:18 ` Konstantin Ryabitsev
2020-03-20 20:52 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-03-18 22:18 UTC (permalink / raw)
To: Mark Brown; +Cc: tools
[-- Attachment #1: Type: text/plain, Size: 3067 bytes --]
On Wed, Mar 18, 2020 at 08:59:14PM +0000, Mark Brown wrote:
> > I'm not sure if there is a reliably clean way of handling this
> > situation, but I'll think about it. For this particular case, you
> > can just pass -v1 to "b4 am" to grab the actual patches.
>
> ...but not the tags added to the cover letter which is the main reason
> I'm doing this :/ . I do see the issue given people sending new
> serieses in reply to existing ones though. Perhaps some heuristic about
> lack of ambiguity (eg, if we're looking for six patches and find exactly
> six patches)?
I have code that properly handles this situation in master:
------
$ python3 b4/command.py am -o/tmp 87y2s0olg6.wl-kuninori.morimoto.gx@renesas.com -t
Looking up https://lore.kernel.org/r/87y2s0olg6.wl-kuninori.morimoto.gx@renesas.com
Grabbing thread from lore.kernel.org
Analyzing 13 messages in the thread
---
Writing /tmp/v3_20200316_kuninori_morimoto_gx_renesas_com.mbx
[PATCH 1/6] ASoC: soc-core: Merge CPU/Codec DAIs
Added: Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Added: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
[PATCH 2/6] ASoC: soc-core: Merge for_each_rtd_cpu/codec_dais()
Added: Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Added: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
[PATCH 3/6] ASoC: soc-dapm: Merge for_each_rtd_cpu/codec_dais()
Added: Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Added: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
[PATCH 4/6] ASoC: soc-pcm: Merge for_each_rtd_cpu/codec_dais()
Added: Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Added: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
[PATCH 5/6] ASoC: soc-core: Merge CPU/Codec for soc_dai_pcm_new()
Added: Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Added: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
[PATCH 6/6] ASoC: soc-pcm: Merge CPU/Codec MSB at soc_pcm_apply_msb()
Added: Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Added: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
Total patches: 6
---
Cover: /tmp/v3_20200316_kuninori_morimoto_gx_renesas_com.cover
Link: https://lore.kernel.org/r/87y2s0olg6.wl-kuninori.morimoto.gx@renesas.com
Base: not found, sorry
git checkout -b v3_20200316_kuninori_morimoto_gx_renesas_com master
git am /tmp/v3_20200316_kuninori_morimoto_gx_renesas_com.mbx
------
You can try that directly from the repo (if you set PYTHONPATH=.), or
build your own package.
Alternatively, you can run:
b4 mbox 87y2s0olg6.wl-kuninori.morimoto.gx@renesas.com
(edit all subjects to add v3 to them)
b4 am 87y2s0olg6.wl-kuninori.morimoto.gx@renesas.com -m that.mbox
I'll probably release 0.3.4 tomorrow with a couple more fixes.
Best,
-K
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 235 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 not finding patches
2020-03-18 22:18 ` Konstantin Ryabitsev
@ 2020-03-20 20:52 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-03-20 20:52 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: tools
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On Wed, Mar 18, 2020 at 06:18:02PM -0400, Konstantin Ryabitsev wrote:
> On Wed, Mar 18, 2020 at 08:59:14PM +0000, Mark Brown wrote:
> > ...but not the tags added to the cover letter which is the main reason
> > I'm doing this :/ . I do see the issue given people sending new
> > serieses in reply to existing ones though. Perhaps some heuristic about
> > lack of ambiguity (eg, if we're looking for six patches and find exactly
> > six patches)?
> I have code that properly handles this situation in master:
That works, thanks (and the shell script to run from git is super
helpful too!).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-20 20:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 20:23 b4 not finding patches Mark Brown
2020-03-18 20:38 ` Konstantin Ryabitsev
2020-03-18 20:59 ` Mark Brown
2020-03-18 21:07 ` Konstantin Ryabitsev
2020-03-18 22:18 ` Konstantin Ryabitsev
2020-03-20 20:52 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).