Re: Failure to grab a thread with b4

* Re: Failure to grab a thread with b4
       [not found]                 ` <20200704205140.3sztf4avevm635rt@wittgenstein>
@ 2020-07-06 19:27                   ` Konstantin Ryabitsev
  2020-07-07  8:17                     ` Christian Brauner
  0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Ryabitsev @ 2020-07-06 19:27 UTC (permalink / raw)
  To: Christian Brauner; +Cc: tools

On Sat, Jul 04, 2020 at 10:51:40PM +0200, Christian Brauner wrote:
> On Sat, Jul 04, 2020 at 10:48:50PM +0200, Christian Brauner wrote:
> > Hey Konstantin,

Please remember to cc tools@linux.kernel.org as well.

> > 
> > I'm running:
> > 
> > brauner@wittgenstein|~
> > > b4 --version
> > 0.5.1
> > 
> > and it fails to grab two patches from a series I sent:
> > 
> > Looking up https://lore.kernel.org/r/20200622234326.906346-1-christian.brauner%40ubuntu.com
> > Grabbing thread from lore.kernel.org/lkml
> > Checking for newer revisions on https://lore.kernel.org/lkml/
> > Analyzing 20 messages in the thread
> > ---
> > Thread incomplete, attempting to backfill
> > ---
> > Writing ./20200623_christian_brauner_arch_remove_do_fork_and_have_copy_thread_tls.mbx
> >   [PATCH 01/17] fork: fold legacy_clone_args_valid() into _do_fork()
> >   [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS
> >   [PATCH 03/17] sparc: share process creation helpers between sparc and sparc64
> >   [PATCH 04/17] sparc: unconditionally enable HAVE_COPY_THREAD_TLS
> >   [PATCH 05/17] ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args
> >   [PATCH 06/17] nios2: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args
> >   [PATCH 07/17] h8300: select HAVE_COPY_THREAD_TLS, switch to kernel_clone_args
> >   [PATCH 08/17] fork: remove do_fork()
> >   [PATCH 09/17] alpha: switch to copy_thread_tls()
> >   [PATCH 10/17] c6x: switch to copy_thread_tls()
> >   [PATCH 11/17] hexagon: switch to copy_thread_tls()
> >     + Acked-by: Brian Cain <bcain@codeaurora.org>
> >   [PATCH 12/17] microblaze: switch to copy_thread_tls()
> >   [PATCH 13/17] nds32: switch to copy_thread_tls()
> >   [PATCH 14/17] sh: switch to copy_thread_tls()
> >   [PATCH 15/17] unicore: switch to copy_thread_tls()
> >   ERROR: missing [16/17]!
> >   ERROR: missing [17/17]!
> > 
> > Just in case you need to fix something.

Well, they are actually not on LKML as far as I can tell -- very likely 
due to vger having hiccups on the day you sent them. E.g. the following 
links return 404:

https://lore.kernel.org/lkml/20200622234326.906346-17-christian.brauner@ubuntu.com/
https://lore.kernel.org/lkml/20200622234326.906346-18-christian.brauner@ubuntu.com/

They do exist on linuxppc-dev, but not the rest of the series.  
Unfortunately, we are currently only able to backfill based on cc 
information present on the cover letter, so we don't try to backfill 
from linuxppc-dev because the cover letter doesn't have that list cc'd.

I don't want to do clever workaround fixes for this, as eventually 
public-inbox will gain ability to collate threads from all of the lists 
it is tracking, so this category of problems should go away entirely 
without needing to work in clever hacks.

> Looking up 
> https://lore.kernel.org/r/20200622234326.906346-18-christian.brauner%40ubuntu.com
> Grabbing thread from lore.kernel.org/linuxppc-dev
> Traceback (most recent call last):
>   File "/home/brauner/.local/bin//b4", line 8, in <module>
>     sys.exit(cmd())
>   File "/home/brauner/.local/lib/python3.8/site-packages/b4/command.py", line 222, in cmd
>     cmdargs.func(cmdargs)
>   File "/home/brauner/.local/lib/python3.8/site-packages/b4/command.py", line 40, in cmd_am
>     b4.mbox.main(cmdargs)
>   File "/home/brauner/.local/lib/python3.8/site-packages/b4/mbox.py", line 491, in main
>     get_extra_series(threadmbox, direction=1)
>   File "/home/brauner/.local/lib/python3.8/site-packages/b4/mbox.py", line 369, in get_extra_series
>     lsub = b4.LoreSubject(base_msg['Subject'])
> TypeError: 'NoneType' object is not subscriptable
> Press any key to continue...

Got it -- the fix should be landing in master and stable-0.5.y soon.

-K

^ permalink raw reply	[flat|nested] 4+ messages in thread