Linux maintainer tooling and workflows
 help / color / Atom feed
* [BUG] b4 can't grap thread with already-percent-encoded slash
@ 2020-11-24 14:37 Philippe Blain
  2020-11-24 14:45 ` Konstantin Ryabitsev
  0 siblings, 1 reply; 6+ messages in thread
From: Philippe Blain @ 2020-11-24 14:37 UTC (permalink / raw)
  To: tools; +Cc: mricon

Hello,

I tried to use b4 to import this thread:
https://lore.kernel.org/git/X7y+cZ3MPqqmGXx%2F@coredump.intra.peff.net/T/#t

using that exact URL:

b4 mbox -o- https://lore.kernel.org/git/X7y+cZ3MPqqmGXx%2F@coredump.intra.peff.net/T/#t

It does not work - I get a 404. I think it's partly 
due to the already-percent-encoded slash (just before the @).
I tried a few things, like manually changing the '%2F' to '/', 
removing the '/T/#t' suffix, adding '-p git' to disambiguate,
but to no avail. I always get either a 404 or 
"That message-id is not known."

Cheers,

Philippe.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] b4 can't grap thread with already-percent-encoded slash
  2020-11-24 14:37 [BUG] b4 can't grap thread with already-percent-encoded slash Philippe Blain
@ 2020-11-24 14:45 ` Konstantin Ryabitsev
  2020-11-24 14:49   ` Philippe Blain
  0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-11-24 14:45 UTC (permalink / raw)
  To: Philippe Blain; +Cc: tools

On Tue, Nov 24, 2020 at 09:37:54AM -0500, Philippe Blain wrote:
> Hello,
> 
> I tried to use b4 to import this thread:
> https://lore.kernel.org/git/X7y+cZ3MPqqmGXx%2F@coredump.intra.peff.net/T/#t
> 
> using that exact URL:
> 
> b4 mbox -o- https://lore.kernel.org/git/X7y+cZ3MPqqmGXx%2F@coredump.intra.peff.net/T/#t
> 
> It does not work - I get a 404. I think it's partly 
> due to the already-percent-encoded slash (just before the @).
> I tried a few things, like manually changing the '%2F' to '/', 
> removing the '/T/#t' suffix, adding '-p git' to disambiguate,
> but to no avail. I always get either a 404 or "That message-id is not 
> known."

Yes, I kept meaning to fix that -- thanks for the reminder. The latest 
master/stable-0.5.y have a fix for that.

-K

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] b4 can't grap thread with already-percent-encoded slash
  2020-11-24 14:45 ` Konstantin Ryabitsev
@ 2020-11-24 14:49   ` Philippe Blain
  2020-11-24 14:52     ` Konstantin Ryabitsev
  0 siblings, 1 reply; 6+ messages in thread
From: Philippe Blain @ 2020-11-24 14:49 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools

Hi Konstantin,

On 20-11-24 09 h 45, Konstantin Ryabitsev wrote:
> On Tue, Nov 24, 2020 at 09:37:54AM -0500, Philippe Blain wrote:
>> Hello,
>>
>> I tried to use b4 to import this thread:
>> https://lore.kernel.org/git/X7y+cZ3MPqqmGXx%2F@coredump.intra.peff.net/T/#t
>>
>> using that exact URL:
>>
>> b4 mbox -o- https://lore.kernel.org/git/X7y+cZ3MPqqmGXx%2F@coredump.intra.peff.net/T/#t
>>
>> It does not work - I get a 404. I think it's partly 
>> due to the already-percent-encoded slash (just before the @).
>> I tried a few things, like manually changing the '%2F' to '/', 
>> removing the '/T/#t' suffix, adding '-p git' to disambiguate,
>> but to no avail. I always get either a 404 or "That message-id is not 
>> known."
> 
> Yes, I kept meaning to fix that -- thanks for the reminder. The latest 
> master/stable-0.5.y have a fix for that.

Not sure if you mean that it should be fixed in master... I installed b4 using

pip3 install --user --upgrade git+https://git.kernel.org/pub/scm/utils/b4/b4.git#egg=b4

so I'm at version 0.6.0-dev. Is it supposed to 
work ?

Thanks for the quick answer,

Philippe.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] b4 can't grap thread with already-percent-encoded slash
  2020-11-24 14:49   ` Philippe Blain
@ 2020-11-24 14:52     ` Konstantin Ryabitsev
  2020-11-24 14:55       ` Philippe Blain
  0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-11-24 14:52 UTC (permalink / raw)
  To: Philippe Blain; +Cc: tools

On Tue, Nov 24, 2020 at 09:49:41AM -0500, Philippe Blain wrote:
> > Yes, I kept meaning to fix that -- thanks for the reminder. The 
> > latest master/stable-0.5.y have a fix for that.
> 
> Not sure if you mean that it should be fixed in master... I installed b4 using
> 
> pip3 install --user --upgrade git+https://git.kernel.org/pub/scm/utils/b4/b4.git#egg=b4
> 
> so I'm at version 0.6.0-dev. Is it supposed to work ?

No, I *just* fixed it, so you'll need the latest master.
You can just run it from checkout, if you prefer. I just have have the 
following in my .bash_profile:

alias b4="$HOME/work/git/b4/b4.sh"

-K

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] b4 can't grap thread with already-percent-encoded slash
  2020-11-24 14:52     ` Konstantin Ryabitsev
@ 2020-11-24 14:55       ` Philippe Blain
  2020-11-24 15:58         ` Konstantin Ryabitsev
  0 siblings, 1 reply; 6+ messages in thread
From: Philippe Blain @ 2020-11-24 14:55 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools



On 20-11-24 09 h 52, Konstantin Ryabitsev wrote:
> On Tue, Nov 24, 2020 at 09:49:41AM -0500, Philippe Blain wrote:
>>> Yes, I kept meaning to fix that -- thanks for the reminder. The 
>>> latest master/stable-0.5.y have a fix for that.
>>
>> Not sure if you mean that it should be fixed in master... I installed b4 using
>>
>> pip3 install --user --upgrade git+https://git.kernel.org/pub/scm/utils/b4/b4.git#egg=b4
>>
>> so I'm at version 0.6.0-dev. Is it supposed to work ?
> 
> No, I *just* fixed it, so you'll need the latest master.

Ha! wow I'm impressed by your responsiveness then :P 
Indeed it works - I jus re-ran my pip command above to upgrade.

Thanks a lot!

Philippe.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] b4 can't grap thread with already-percent-encoded slash
  2020-11-24 14:55       ` Philippe Blain
@ 2020-11-24 15:58         ` Konstantin Ryabitsev
  0 siblings, 0 replies; 6+ messages in thread
From: Konstantin Ryabitsev @ 2020-11-24 15:58 UTC (permalink / raw)
  To: Philippe Blain; +Cc: tools

On Tue, Nov 24, 2020 at 09:55:47AM -0500, Philippe Blain wrote:
> > No, I *just* fixed it, so you'll need the latest master.
> 
> Ha! wow I'm impressed by your responsiveness then :P

Just luck, I assure you. :) I happened to be looking at that exact code.

Glad it works.

-K

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 14:37 [BUG] b4 can't grap thread with already-percent-encoded slash Philippe Blain
2020-11-24 14:45 ` Konstantin Ryabitsev
2020-11-24 14:49   ` Philippe Blain
2020-11-24 14:52     ` Konstantin Ryabitsev
2020-11-24 14:55       ` Philippe Blain
2020-11-24 15:58         ` Konstantin Ryabitsev

Linux maintainer tooling and workflows

Archives are clonable:
	git clone --mirror https://lore.kernel.org/tools/0 tools/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tools tools/ https://lore.kernel.org/tools \
		tools@linux.kernel.org
	public-inbox-index tools

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.linux.tools


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git