tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
* b4 ty thanking for everything
@ 2020-12-01 14:41 Mark Brown
  2020-12-01 14:52 ` [tools] " Martin K. Petersen
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Mark Brown @ 2020-12-01 14:41 UTC (permalink / raw)
  To: tools, konstantin

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

Hi,

When I run

	b4 ty -o /some/dir -b remote/branch -a

as of a git update from master earlier today (I'm at 45c63bd0fd80 "Fix
headers generated by "b4 ty") b4 generates thanks for every patch in its
database regardless of if it finds any commits for that series in the
specified branch which isn't ideal, especially if one has been applying
things to multiple branches.

Thanks,
Mark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tools] b4 ty thanking for everything
  2020-12-01 14:41 b4 ty thanking for everything Mark Brown
@ 2020-12-01 14:52 ` Martin K. Petersen
  2020-12-01 15:23 ` Konstantin Ryabitsev
       [not found] ` <164CA10C94033C15.5074@linux.kernel.org>
  2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2020-12-01 14:52 UTC (permalink / raw)
  To: Mark Brown; +Cc: tools, konstantin


Mark,

> When I run
>
> 	b4 ty -o /some/dir -b remote/branch -a
>
> as of a git update from master earlier today (I'm at 45c63bd0fd80 "Fix
> headers generated by "b4 ty") b4 generates thanks for every patch in its
> database regardless of if it finds any commits for that series in the
> specified branch which isn't ideal, especially if one has been applying
> things to multiple branches.

I tripped over that as well and was just about to post.

Thankfully manually renaming the affected files in ~/.local/b4/shared
worked. I had a lot of stuff queued for 5.11 that became collateral
damage when trying to send out thanks for a couple of 5.10 fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: b4 ty thanking for everything
  2020-12-01 14:41 b4 ty thanking for everything Mark Brown
  2020-12-01 14:52 ` [tools] " Martin K. Petersen
@ 2020-12-01 15:23 ` Konstantin Ryabitsev
       [not found] ` <164CA10C94033C15.5074@linux.kernel.org>
  2 siblings, 0 replies; 5+ messages in thread
From: Konstantin Ryabitsev @ 2020-12-01 15:23 UTC (permalink / raw)
  To: Mark Brown; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On Tue, Dec 01, 2020 at 02:41:01PM +0000, Mark Brown wrote:
> Hi,
> 
> When I run
> 
> 	b4 ty -o /some/dir -b remote/branch -a
> 
> as of a git update from master earlier today (I'm at 45c63bd0fd80 "Fix
> headers generated by "b4 ty") b4 generates thanks for every patch in its
> database regardless of if it finds any commits for that series in the
> specified branch which isn't ideal, especially if one has been applying
> things to multiple branches.

Dang, this means 0.5.3 is probably broken the same way. Let me find the 
culprit. :/

-K

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 235 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tools] b4 ty thanking for everything
       [not found] ` <164CA10C94033C15.5074@linux.kernel.org>
@ 2020-12-01 15:43   ` Konstantin Ryabitsev
  2020-12-02 17:05     ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Konstantin Ryabitsev @ 2020-12-01 15:43 UTC (permalink / raw)
  To: tools; +Cc: Mark Brown

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

On Tue, Dec 01, 2020 at 10:23:57AM -0500, Konstantin Ryabitsev via linux.kernel.org wrote:
> > as of a git update from master earlier today (I'm at 45c63bd0fd80 
> > "Fix
> > headers generated by "b4 ty") b4 generates thanks for every patch in its
> > database regardless of if it finds any commits for that series in the
> > specified branch which isn't ideal, especially if one has been applying
> > things to multiple branches.
> 
> Dang, this means 0.5.3 is probably broken the same way. Let me find 
> the culprit. :/

Okay, this should be fixed both in master and stable-0.5.y. You can 
restore the damage by looking in your .local/share/b4, finding the .sent 
files that you know were wrongfully triggered, and renaming them back 
into .am.

Sorry about that.

-K

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 235 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tools] b4 ty thanking for everything
  2020-12-01 15:43   ` [tools] " Konstantin Ryabitsev
@ 2020-12-02 17:05     ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2020-12-02 17:05 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On Tue, Dec 01, 2020 at 10:43:54AM -0500, Konstantin Ryabitsev wrote:

> Okay, this should be fixed both in master and stable-0.5.y. You can 
> restore the damage by looking in your .local/share/b4, finding the .sent 
> files that you know were wrongfully triggered, and renaming them back 
> into .am.

This seems to have fixed things, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-02 17:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 14:41 b4 ty thanking for everything Mark Brown
2020-12-01 14:52 ` [tools] " Martin K. Petersen
2020-12-01 15:23 ` Konstantin Ryabitsev
     [not found] ` <164CA10C94033C15.5074@linux.kernel.org>
2020-12-01 15:43   ` [tools] " Konstantin Ryabitsev
2020-12-02 17:05     ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).