tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
* b4 send needs a subject in the cover
@ 2022-12-07 23:02 Mark Brown
  2022-12-08  0:39 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2022-12-07 23:02 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

If I've got a patch series with a single patch in it then there's no
need for a cover letter and if it's the first version no need for a
changelog so I'd expect to just delete all the text in the b4 cover
other than the recipients.  However if I do that then what seems to end
up happening is that the first recipient gets deleted, I'm guessing
parsed as a subject which then doesn't get used due to this being a
single message.

I can see why this happens but it's a bit of a gotcha - printing the
subject might help make it clearer what's going on in this case?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: b4 send needs a subject in the cover
  2022-12-07 23:02 b4 send needs a subject in the cover Mark Brown
@ 2022-12-08  0:39 ` Mark Brown
  2022-12-09 21:05   ` Konstantin Ryabitsev
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2022-12-08  0:39 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

On Wed, Dec 07, 2022 at 11:02:41PM +0000, Mark Brown wrote:
> If I've got a patch series with a single patch in it then there's no
> need for a cover letter and if it's the first version no need for a
> changelog so I'd expect to just delete all the text in the b4 cover
> other than the recipients.  However if I do that then what seems to end
> up happening is that the first recipient gets deleted, I'm guessing
> parsed as a subject which then doesn't get used due to this being a
> single message.
> 
> I can see why this happens but it's a bit of a gotcha - printing the
> subject might help make it clearer what's going on in this case?

...and further if you look at

   https://lore.kernel.org/r/20221207-arm64-mvfr-fix-v1-0-0c739eb77bea@kernel.org

you'll see that the to and Cc lines end up in the sent patch which isn't
entirely what would be expected.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: b4 send needs a subject in the cover
  2022-12-08  0:39 ` Mark Brown
@ 2022-12-09 21:05   ` Konstantin Ryabitsev
  0 siblings, 0 replies; 3+ messages in thread
From: Konstantin Ryabitsev @ 2022-12-09 21:05 UTC (permalink / raw)
  To: Mark Brown; +Cc: tools

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On Thu, Dec 08, 2022 at 12:39:01AM +0000, Mark Brown wrote:
> On Wed, Dec 07, 2022 at 11:02:41PM +0000, Mark Brown wrote:
> > If I've got a patch series with a single patch in it then there's no
> > need for a cover letter and if it's the first version no need for a
> > changelog so I'd expect to just delete all the text in the b4 cover
> > other than the recipients.  However if I do that then what seems to end
> > up happening is that the first recipient gets deleted, I'm guessing
> > parsed as a subject which then doesn't get used due to this being a
> > single message.
> > 
> > I can see why this happens but it's a bit of a gotcha - printing the
> > subject might help make it clearer what's going on in this case?
> 
> ...and further if you look at
> 
>    https://lore.kernel.org/r/20221207-arm64-mvfr-fix-v1-0-0c739eb77bea@kernel.org
> 
> you'll see that the to and Cc lines end up in the sent patch which isn't
> entirely what would be expected.

I believe the latest master should fix both of these problems.

-K

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-09 21:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 23:02 b4 send needs a subject in the cover Mark Brown
2022-12-08  0:39 ` Mark Brown
2022-12-09 21:05   ` Konstantin Ryabitsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).