From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: "Kernel.org Tools" <tools@linux.kernel.org>
Subject: Re: [PATCH b4 0/2] A prep splat fix and rework of option handling
Date: Tue, 10 Jan 2023 17:43:54 -0500 [thread overview]
Message-ID: <20230110224354.rnzyqvpe4ljkoepl@meerkat.local> (raw)
In-Reply-To: <CAL_JsqLU8qb-aNGDZ45mq8_e=Oin6QY+8vBdfyUSPBFDVCFJEA@mail.gmail.com>
On Tue, Jan 10, 2023 at 04:15:34PM -0600, Rob Herring wrote:
> I ran into a few more issues sending this. The first was b4 is
> configured to use the web endpoint by default. Is there some way to
> override that other than editing .b4-config? I didn't see one, so I
> just edited the config and sent this.
Ah, yes, I didn't think about this. You *can* override it by setting
b4.send-endpoint-web = no in your local git config, but we should change the
default so that we always use SMTP when we find it, and only fall back to the
web endpoint when SMTP is not configured.
> The second issue is quite critical as users' work could be lost! After
> I sent this, my (uncommitted).b4-config changes were gone! This is due
> to the reroll to v2 and it seems git-filter-repo wipes out uncommitted
> changes. I guess the '--force' option disables all checking, so we
> need to do some of our own.
This is actually because we create a detached head for the purposes of tagging
it. This needs to be improved so we don't modify the current worktree, I just
didn't research how to do it.
For now, I added the check for the state of the tree to make sure that we
refuse to operate if it's not clean.
Thank you for the report.
-K
next prev parent reply other threads:[~2023-01-10 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 21:46 [PATCH b4 0/2] A prep splat fix and rework of option handling Rob Herring
2023-01-10 21:46 ` [PATCH b4 1/2] prep: Fix splat with --auto-to-cc when a branch has no commits Rob Herring
2023-01-10 21:46 ` [PATCH b4 2/2] prep: Allow configuration options when enrolling/creating branch Rob Herring
2023-01-10 22:15 ` [PATCH b4 0/2] A prep splat fix and rework of option handling Rob Herring
2023-01-10 22:43 ` Konstantin Ryabitsev [this message]
2023-01-12 16:14 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110224354.rnzyqvpe4ljkoepl@meerkat.local \
--to=konstantin@linuxfoundation.org \
--cc=robh@kernel.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).