From: Rob Herring <robh@kernel.org>
To: "Kernel.org Tools" <tools@linux.kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH b4 0/2] A prep splat fix and rework of option handling
Date: Tue, 10 Jan 2023 16:15:34 -0600 [thread overview]
Message-ID: <CAL_JsqLU8qb-aNGDZ45mq8_e=Oin6QY+8vBdfyUSPBFDVCFJEA@mail.gmail.com> (raw)
In-Reply-To: <20230110-prep-opts-v1-0-8e7d7b861849@kernel.org>
On Tue, Jan 10, 2023 at 3:46 PM Rob Herring <robh@kernel.org> wrote:
>
> I wanted enroll a branch and run 'auto-to-cc' in one step which from the
> help looks valid, but was met with a splat. The same splat happens if
> one runs 'b4 prep -c' on a newly created branch with no commits (other
> than the cover letter). There's a couple of other options that might be
> useful to use on new branches. The 2nd patch makes this possible.
>
> Alternatively, the help should be clearer on what options are valid
> together or not.
>
> Another thing I noticed is that if we error out when creating a new
> branch after the branch is created, the branch remains afterwards. Not
> sure if this is intended in the name of minimizing modifications to git
> trees or just an oversight.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Rob Herring (2):
> prep: Fix splat with --auto-to-cc when a branch has no commits
> prep: Allow configuration options when enrolling/creating branch
I ran into a few more issues sending this. The first was b4 is
configured to use the web endpoint by default. Is there some way to
override that other than editing .b4-config? I didn't see one, so I
just edited the config and sent this.
The second issue is quite critical as users' work could be lost! After
I sent this, my (uncommitted).b4-config changes were gone! This is due
to the reroll to v2 and it seems git-filter-repo wipes out uncommitted
changes. I guess the '--force' option disables all checking, so we
need to do some of our own.
Rob
next prev parent reply other threads:[~2023-01-10 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 21:46 [PATCH b4 0/2] A prep splat fix and rework of option handling Rob Herring
2023-01-10 21:46 ` [PATCH b4 1/2] prep: Fix splat with --auto-to-cc when a branch has no commits Rob Herring
2023-01-10 21:46 ` [PATCH b4 2/2] prep: Allow configuration options when enrolling/creating branch Rob Herring
2023-01-10 22:15 ` Rob Herring [this message]
2023-01-10 22:43 ` [PATCH b4 0/2] A prep splat fix and rework of option handling Konstantin Ryabitsev
2023-01-12 16:14 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLU8qb-aNGDZ45mq8_e=Oin6QY+8vBdfyUSPBFDVCFJEA@mail.gmail.com' \
--to=robh@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).