Problem with b4 with v2's in the thread

Problem with b4 with v2's in the thread

[Josef Bacik]

Hello,

I have a thread here

https://lore.kernel.org/linux-btrfs/941273be-4250-3406-79e4-60ef762c5506@suse.com/T/#m64fdf99cfbdb8914a7f665a1d241f6643a8be389

That doesn't work right with b4 am, it's only pulling down

[PATCH v2] btrfs: Switch seed device to list api

Which is just v2 of the 5th patch in the series.  There's actually 2 v2's in 
this list to address the kbuild fixes, but it doesn't even pick up both v2's, 
just the last one.  I realize this is a weird case, but thought I'd report it 
anyway.  Thanks,

Josef

Re: [tools] Problem with b4 with v2's in the thread

[Konstantin Ryabitsev]

On Tue, Aug 18, 2020 at 11:01:23AM -0400, Josef Bacik wrote:
> Hello,
> 
> I have a thread here
> 
> https://lore.kernel.org/linux-btrfs/941273be-4250-3406-79e4-60ef762c5506@suse.com/T/#m64fdf99cfbdb8914a7f665a1d241f6643a8be389
> 
> That doesn't work right with b4 am, it's only pulling down
> 
> [PATCH v2] btrfs: Switch seed device to list api
> 
> Which is just v2 of the 5th patch in the series.  There's actually 2 v2's in
> this list to address the kbuild fixes, but it doesn't even pick up both
> v2's, just the last one.  I realize this is a weird case, but thought I'd
> report it anyway.  Thanks,

Right, this is not really a case we can reasonably handle without making 
too many assumptions (that could be erroneous). A similar case was 
discussed on the users list a while back and the consensus was that, to 
make maintainers' lives easier, the entire series needs to be rerolled 
and resubmitted, instead of individual patches in the thread.

So, I suggest you respond to Nikolay with "looks good, but please reroll 
the whole series."

The alternative is that you can download the entire thread using "b4 
mbox" and manually edit subjects to make the proper v2 series that b4 is 
able to process.

-K

Re: [tools] Problem with b4 with v2's in the thread

[Josef Bacik]

On 8/18/20 11:16 AM, Konstantin Ryabitsev wrote:
> On Tue, Aug 18, 2020 at 11:01:23AM -0400, Josef Bacik wrote:
>> Hello,
>>
>> I have a thread here
>>
>> https://lore.kernel.org/linux-btrfs/941273be-4250-3406-79e4-60ef762c5506@suse.com/T/#m64fdf99cfbdb8914a7f665a1d241f6643a8be389
>>
>> That doesn't work right with b4 am, it's only pulling down
>>
>> [PATCH v2] btrfs: Switch seed device to list api
>>
>> Which is just v2 of the 5th patch in the series.  There's actually 2 v2's in
>> this list to address the kbuild fixes, but it doesn't even pick up both
>> v2's, just the last one.  I realize this is a weird case, but thought I'd
>> report it anyway.  Thanks,
> 
> Right, this is not really a case we can reasonably handle without making
> too many assumptions (that could be erroneous). A similar case was
> discussed on the users list a while back and the consensus was that, to
> make maintainers' lives easier, the entire series needs to be rerolled
> and resubmitted, instead of individual patches in the thread.
> 
> So, I suggest you respond to Nikolay with "looks good, but please reroll
> the whole series."
> 
> The alternative is that you can download the entire thread using "b4
> mbox" and manually edit subjects to make the proper v2 series that b4 is
> able to process.
> 

That's fair, thanks!

Josef