b4 send: missing diffstat in individual patches

b4 send: missing diffstat in individual patches

[Guillaume Ranquet]

Hello,

I've recently sent a patch series with b4 and diffstats are missing
from individual patches.

Which in itself is not an issue as I understand this is only comments
that are irrelevant to
the patch itself.

Though, I've had some complaints that my patches looks broken...
people seem to expect the
diffstat to be present.

The serie was sent with 0.10.0-dev (master from some weeks ago).
I've just retried a dry-run with the latest and the diffstat is still missing.

I haven't seen any option in b4 send to produce the individual commit
diffstat, I will have
a quick look if I can propose a patch.

Thx,
Guillaume.

Re: b4 send: missing diffstat in individual patches

[Konstantin Ryabitsev]

On Thu, Sep 22, 2022 at 04:37:44AM -0700, Guillaume Ranquet wrote:
> Hello,
> 
> I've recently sent a patch series with b4 and diffstats are missing
> from individual patches.

You're right, I've never actually noticed that. I guess that's the difference
when generating the message using --format=email.

> Which in itself is not an issue as I understand this is only comments
> that are irrelevant to
> the patch itself.
> 
> Though, I've had some complaints that my patches looks broken...
> people seem to expect the
> diffstat to be present.
> 
> The serie was sent with 0.10.0-dev (master from some weeks ago).
> I've just retried a dry-run with the latest and the diffstat is still missing.
> 
> I haven't seen any option in b4 send to produce the individual commit
> diffstat, I will have
> a quick look if I can propose a patch.

I'll try to put that in today.

-K

Re: b4 send: missing diffstat in individual patches

[Konstantin Ryabitsev]

On Thu, Sep 22, 2022 at 09:29:10AM -0400, Konstantin Ryabitsev wrote:
> > The serie was sent with 0.10.0-dev (master from some weeks ago).
> > I've just retried a dry-run with the latest and the diffstat is still missing.
> > 
> > I haven't seen any option in b4 send to produce the individual commit
> > diffstat, I will have
> > a quick look if I can propose a patch.
> 
> I'll try to put that in today.

This was an easy fix, so it's in master. I'll backport it into 0.10.y stable
later today.

-K

Re: b4 send: missing diffstat in individual patches

[Mattijs Korpershoek]

Hi Konstantin,

On Thu, Sep 22, 2022 at 10:22, Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:

> On Thu, Sep 22, 2022 at 09:29:10AM -0400, Konstantin Ryabitsev wrote:
>> > The serie was sent with 0.10.0-dev (master from some weeks ago).
>> > I've just retried a dry-run with the latest and the diffstat is still missing.
>> > 
>> > I haven't seen any option in b4 send to produce the individual commit
>> > diffstat, I will have
>> > a quick look if I can propose a patch.
>> 
>> I'll try to put that in today.
>
> This was an easy fix, so it's in master. I'll backport it into 0.10.y stable
> later today.

Thank you for all the work you've put in the "contributor" side of b4.
Your responsive replies and fixes are really appreciated, and so
is the new documentation.

Cheers!
Mattijs

>
> -K

Re: b4 send: missing diffstat in individual patches

[Konstantin Ryabitsev]

On Thu, Sep 22, 2022 at 04:46:56PM +0200, Mattijs Korpershoek wrote:
> > On Thu, Sep 22, 2022 at 09:29:10AM -0400, Konstantin Ryabitsev wrote:
> >> > The serie was sent with 0.10.0-dev (master from some weeks ago).
> >> > I've just retried a dry-run with the latest and the diffstat is still missing.
> >> > 
> >> > I haven't seen any option in b4 send to produce the individual commit
> >> > diffstat, I will have
> >> > a quick look if I can propose a patch.
> >> 
> >> I'll try to put that in today.
> >
> > This was an easy fix, so it's in master. I'll backport it into 0.10.y stable
> > later today.
> 
> Thank you for all the work you've put in the "contributor" side of b4.
> Your responsive replies and fixes are really appreciated, and so
> is the new documentation.

I'm glad people are using it! I'm sure there will be a lot of changes to my
initial implementation, and that was entirely expected.

Best regards,
Konstantin