b4 prep + prefix handling

b4 prep + prefix handling

[Vishal Verma]

Hi Konstantin,

I found a possible issue with prefixes - and also a suggestion below:

- When a 'git config format.subjectprefix' exists, b4 send does
something unexpected:
(the .git/config subjectprefix here was "ndctl PATCH")

  | Subject: [PATCH 2/2] [ndctl PATCH] meson.build: add a check argument to run_command

- It might be helpful to configure whether the final form is "PATCH
prefix" vs "prefix PATCH". I'm used to the latter, but I don't know if
the former is considered conventional.

- It might be nice if prefixes from git-config could be added
automagically (perhaps b4 prep pulls these in when starting a new
set?). I have prefixes based on repos sometimes, like the above
example, and it would be nice to get consistent behavior regardless of
whether 'b4 prep/send' is used or 'git format-patch/send-email'

Thanks!
Vishal

Re: b4 prep + prefix handling

[Konstantin Ryabitsev]

On Tue, Dec 06, 2022 at 03:44:59PM -0700, Vishal Verma wrote:
> Hi Konstantin,
> 
> I found a possible issue with prefixes - and also a suggestion below:
> 
> - When a 'git config format.subjectprefix' exists, b4 send does
> something unexpected:
> (the .git/config subjectprefix here was "ndctl PATCH")
> 
>   | Subject: [PATCH 2/2] [ndctl PATCH] meson.build: add a check argument to run_command
> 
> - It might be helpful to configure whether the final form is "PATCH
> prefix" vs "prefix PATCH". I'm used to the latter, but I don't know if
> the former is considered conventional.
> 
> - It might be nice if prefixes from git-config could be added
> automagically (perhaps b4 prep pulls these in when starting a new
> set?). I have prefixes based on repos sometimes, like the above
> example, and it would be nice to get consistent behavior regardless of
> whether 'b4 prep/send' is used or 'git format-patch/send-email'

Vishal:

I believe the latest master should be able to properly co-exist with prefixes
set via format.subjectPrefix and those set directly via b4.

Please try it out and let me know if it's not what you need.

-Konstantin

Re: b4 prep + prefix handling

[Vishal Verma]

On Fri, 2022-12-09 at 16:11 -0500, Konstantin Ryabitsev wrote:
> On Tue, Dec 06, 2022 at 03:44:59PM -0700, Vishal Verma wrote:
> > Hi Konstantin,
> > 
> > I found a possible issue with prefixes - and also a suggestion below:
> > 
> > - When a 'git config format.subjectprefix' exists, b4 send does
> > something unexpected:
> > (the .git/config subjectprefix here was "ndctl PATCH")
> > 
> >   | Subject: [PATCH 2/2] [ndctl PATCH] meson.build: add a check argument to run_command
> > 
> > - It might be helpful to configure whether the final form is "PATCH
> > prefix" vs "prefix PATCH". I'm used to the latter, but I don't know if
> > the former is considered conventional.
> > 
> > - It might be nice if prefixes from git-config could be added
> > automagically (perhaps b4 prep pulls these in when starting a new
> > set?). I have prefixes based on repos sometimes, like the above
> > example, and it would be nice to get consistent behavior regardless of
> > whether 'b4 prep/send' is used or 'git format-patch/send-email'
> 
> Vishal:
> 
> I believe the latest master should be able to properly co-exist with prefixes
> set via format.subjectPrefix and those set directly via b4.
> 
> Please try it out and let me know if it's not what you need.

Yep works great now - it gets pulled automatically from the git config,
without needing to b4 prep --set-prefixes

Thanks for the quick fix!