* [PATCH] tpm xen: drop unneeded chip variable
@ 2017-02-05 21:39 Julia Lawall
[not found] ` <1486330777-11341-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2017-02-05 21:39 UTC (permalink / raw)
To: Peter Huewe
Cc: kernel-janitors, Marcel Selhorst, Jarkko Sakkinen,
Jason Gunthorpe, tpmdd-devel, linux-kernel
The call that used chip was dropped in 1f0f30e404b3. Drop the
leftover declaration and initialization.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/char/tpm/xen-tpmfront.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 5aaa268..656e8af 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -289,7 +289,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
const struct xenbus_device_id *id)
{
struct tpm_private *priv;
- struct tpm_chip *chip;
int rv;
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
@@ -306,7 +305,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
rv = setup_ring(dev, priv);
if (rv) {
- chip = dev_get_drvdata(&dev->dev);
ring_free(priv);
return rv;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tpm xen: drop unneeded chip variable
[not found] ` <1486330777-11341-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
@ 2017-02-08 13:02 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2017-02-08 13:02 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
On Sun, Feb 05, 2017 at 10:39:37PM +0100, Julia Lawall wrote:
> The call that used chip was dropped in 1f0f30e404b3. Drop the
> leftover declaration and initialization.
>
> Signed-off-by: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
/Jarkko
>
> ---
> drivers/char/tpm/xen-tpmfront.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 5aaa268..656e8af 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -289,7 +289,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
> const struct xenbus_device_id *id)
> {
> struct tpm_private *priv;
> - struct tpm_chip *chip;
> int rv;
>
> priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> @@ -306,7 +305,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>
> rv = setup_ring(dev, priv);
> if (rv) {
> - chip = dev_get_drvdata(&dev->dev);
> ring_free(priv);
> return rv;
> }
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-08 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-05 21:39 [PATCH] tpm xen: drop unneeded chip variable Julia Lawall
[not found] ` <1486330777-11341-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2017-02-08 13:02 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).