From: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Cc: patrickc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ima-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Subject: [PATCH 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time Date: Wed, 6 Sep 2017 08:56:41 -0400 [thread overview] Message-ID: <20170906125643.5070-7-nayna@linux.vnet.ibm.com> (raw) In-Reply-To: <20170906125643.5070-1-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> The existing wait_for_tpm_stat() checks the chip status before sleeping for 5 msec in a polling loop. For some functions although the status isn't ready immediately, the status returns extremely quickly. Waiting for 5 msec causes an unnecessary delay. An example is the send() call in the tpms_tis driver. This patch defines __wait_for_tpm_stat(), allowing the caller to specify the polling sleep timeout value within the loop. The existing wait_for_tpm_stat() becomes a wrapper for this function. Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> --- drivers/char/tpm/tpm-interface.c | 15 ++++++++++++--- drivers/char/tpm/tpm.h | 3 +++ drivers/char/tpm/tpm_tis_core.c | 11 ++++++----- 3 files changed, 21 insertions(+), 8 deletions(-) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index 1d6729be4cd6..b23d006243b7 100644 --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -1050,8 +1050,9 @@ static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, return false; } -int wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, unsigned long timeout, - wait_queue_head_t *queue, bool check_cancel) +int __wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, unsigned long timeout, + unsigned int poll_sleep, wait_queue_head_t *queue, + bool check_cancel) { unsigned long stop; long rc; @@ -1085,7 +1086,7 @@ int wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, unsigned long timeout, } } else { do { - tpm_msleep(TPM_TIMEOUT); + tpm_msleep(poll_sleep); status = chip->ops->status(chip); if ((status & mask) == mask) return 0; @@ -1093,6 +1094,14 @@ int wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, unsigned long timeout, } return -ETIME; } +EXPORT_SYMBOL_GPL(__wait_for_tpm_stat); + +int wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, unsigned long timeout, + wait_queue_head_t *queue, bool check_cancel) +{ + return __wait_for_tpm_stat(chip, mask, timeout, TPM_TIMEOUT, + queue, check_cancel); +} EXPORT_SYMBOL_GPL(wait_for_tpm_stat); #define TPM_ORD_SAVESTATE 152 diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h index 2d5466a72e40..eb2f8818eded 100644 --- a/drivers/char/tpm/tpm.h +++ b/drivers/char/tpm/tpm.h @@ -525,6 +525,9 @@ int tpm_do_selftest(struct tpm_chip *chip); unsigned long tpm_calc_ordinal_duration(struct tpm_chip *chip, u32 ordinal); int tpm_pm_suspend(struct device *dev); int tpm_pm_resume(struct device *dev); +int __wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, + unsigned long timeout, unsigned int poll_sleep, + wait_queue_head_t *queue, bool check_cancel); int wait_for_tpm_stat(struct tpm_chip *chip, u8 mask, unsigned long timeout, wait_queue_head_t *queue, bool check_cancel); diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index 6b9bf4c4d434..d1eab29cb447 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -268,8 +268,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len) status = tpm_tis_status(chip); if ((status & TPM_STS_COMMAND_READY) == 0) { tpm_tis_ready(chip); - if (wait_for_tpm_stat - (chip, TPM_STS_COMMAND_READY, chip->timeout_b, + if (__wait_for_tpm_stat + (chip, TPM_STS_COMMAND_READY, chip->timeout_b, 1, &priv->int_queue, false) < 0) { rc = -ETIME; goto out_err; @@ -303,7 +303,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len) if (ignore_burst_count) continue; - if (wait_for_tpm_stat(chip, TPM_STS_VALID, chip->timeout_c, + if (__wait_for_tpm_stat(chip, TPM_STS_VALID, + chip->timeout_c, 1, &priv->int_queue, false) < 0) { rc = -ETIME; goto out_err; @@ -320,8 +321,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len) if (rc < 0) goto out_err; - if (wait_for_tpm_stat(chip, TPM_STS_VALID, chip->timeout_c, - &priv->int_queue, false) < 0) { + if (__wait_for_tpm_stat(chip, TPM_STS_VALID, chip->timeout_c, + 1, &priv->int_queue, false) < 0) { rc = -ETIME; goto out_err; } -- 2.13.3 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-09-06 12:56 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-06 12:56 [PATCH v2 0/4] additional TPM performance improvements Nayna Jain 2017-09-06 12:56 ` [PATCH v2 3/4] tpm: reduce tpm_msleep() time in get_burstcount() Nayna Jain 2017-09-13 1:00 ` Jarkko Sakkinen 2017-09-15 12:40 ` Nayna Jain [not found] ` <20170906125643.5070-1-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> 2017-09-06 12:56 ` [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance Nayna Jain 2017-09-06 16:12 ` Jason Gunthorpe 2017-09-13 18:52 ` [tpmdd-devel] " Ken Goldman [not found] ` <3c418974-a4c7-518e-b218-f6373c10209e-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> 2017-09-13 19:01 ` Peter Huewe 2017-09-13 0:45 ` Jarkko Sakkinen [not found] ` <20170912222010.ltm76m5vy2kupydi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2017-09-13 18:39 ` Peter Huewe 2017-09-13 23:10 ` Jarkko Sakkinen 2017-09-15 12:29 ` Nayna Jain 2017-09-15 15:19 ` Jarkko Sakkinen 2017-09-06 12:56 ` [PATCH v2 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time Nayna Jain 2017-09-13 0:58 ` Jarkko Sakkinen 2017-09-15 12:37 ` Nayna Jain 2017-09-15 15:20 ` Jarkko Sakkinen 2017-09-06 12:56 ` [PATCH v2 4/4] tpm: use tpm_msleep() value as max delay Nayna Jain 2017-09-13 0:47 ` Jarkko Sakkinen 2017-09-14 9:25 ` Nayna Jain 2017-09-14 12:28 ` Jarkko Sakkinen 2017-09-06 12:56 ` Nayna Jain [this message] 2017-09-06 12:58 ` [PATCH 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time Nayna 2017-09-06 12:56 ` [PATCH 1/4] tpm: ignore burstcount to improve tpm_tis send() performance Nayna Jain [not found] ` <20170906125643.5070-6-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> 2017-09-06 12:58 ` Nayna 2017-09-07 16:18 ` [PATCH v2 0/4] additional TPM performance improvements Jarkko Sakkinen 2017-09-11 15:20 ` [tpmdd-devel] " Alexander.Steffen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170906125643.5070-7-nayna@linux.vnet.ibm.com \ --to=nayna-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \ --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \ --cc=linux-ima-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=patrickc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \ --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ --subject='Re: [PATCH 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).