From: Thiebaud Weksteen <tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> To: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>, Ashley Lai <ashleydlai-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matthew Garrett <mjg59-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, peterhuewe-Mmb7MZpHnFY@public.gmane.org, Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org Subject: Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Date: Mon, 18 Sep 2017 14:38:03 +0200 [thread overview] Message-ID: <CA+zpnLe8hgSgBbjw8zF=pvykNo9mkVcyR65KY=vFckKf+XMb=Q@mail.gmail.com> (raw) In-Reply-To: <20170912084851.z3ednbeojawnyxk2-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> On Tue, Sep 12, 2017 at 10:48 AM, Thiebaud Weksteen <tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote: > On Mon, Sep 11, 2017 at 10:47:50AM -0600, Jason Gunthorpe wrote: >> On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote: >> >> > chip->bin_log_seqops.chip = chip; >> > - if (chip->flags & TPM_CHIP_FLAG_TPM2) >> > + >> > + if (log_version == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 || >> > + (!log_version && (chip->flags & TPM_CHIP_FLAG_TPM2))) >> > chip->bin_log_seqops.seqops = >> > &tpm2_binary_b_measurements_seqops; >> >> Lets have all the read_log_* versions return the postitive log_version >> and get rid of the chip->flags check here. >> >> ie Doesn't ACPI always return the TPM 1 version? > > That is my understanding. Ashley, Nayna, could you confirm the format > version expected by tpm_of? Could it be both? > I've changed the returned code for ACPI but not for DeviceTree. Without confirmation for tpm_of, I am reluctant to modify the current behaviour. >> >> Jason
next prev parent reply other threads:[~2017-09-18 12:38 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-11 10:00 [PATCH v2 0/3] Call GetEventLog before ExitBootServices Thiebaud Weksteen 2017-09-11 10:00 ` [PATCH v2 1/3] tpm: move tpm_eventlog.h outside of drivers folder Thiebaud Weksteen 2017-09-11 10:00 ` [PATCH v2 2/3] efi: call get_event_log before ExitBootServices Thiebaud Weksteen [not found] ` <20170911100022.7251-3-tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2017-09-13 14:49 ` kbuild test robot [not found] ` <201709132252.uZyTCtDz%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2017-09-13 16:28 ` Thiebaud Weksteen via tpmdd-devel 2017-09-14 10:24 ` [tpmdd-devel] " Javier Martinez Canillas [not found] ` <1f25ebdc-ab90-517f-b580-991a7cb5e25a-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-09-18 12:11 ` Thiebaud Weksteen 2017-09-18 12:49 ` Javier Martinez Canillas 2017-09-14 18:43 ` Jarkko Sakkinen [not found] ` <20170914184126.eevnstwq3i6fiq4j-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2017-09-14 18:48 ` Matthew Garrett 2017-09-14 19:02 ` Jarkko Sakkinen [not found] ` <20170914190247.rrbdzdexjjywxipf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2017-09-15 4:06 ` Jarkko Sakkinen 2017-09-18 12:28 ` Thiebaud Weksteen [not found] ` <CA+zpnLfs=DhW6kgbLV63_XzmKS7VnGGE0ecbFBZ0bu4wx3Jf+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-09-18 17:56 ` Jarkko Sakkinen 2017-09-11 10:00 ` [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table Thiebaud Weksteen [not found] ` <20170911100022.7251-4-tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2017-09-11 16:47 ` Jason Gunthorpe 2017-09-12 8:48 ` Thiebaud Weksteen [not found] ` <20170912084851.z3ednbeojawnyxk2-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2017-09-18 12:38 ` Thiebaud Weksteen [this message] 2017-09-18 16:28 ` Jason Gunthorpe 2017-09-13 16:27 ` kbuild test robot [not found] ` <201709140034.ESdZA8H8%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2017-09-13 16:43 ` Thiebaud Weksteen 2017-09-14 18:47 ` Jarkko Sakkinen [not found] ` <20170914184732.uiypaz4yft777oc7-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2017-09-18 12:33 ` Thiebaud Weksteen [not found] ` <20170911100022.7251-1-tweek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2017-09-13 18:59 ` [PATCH v2 0/3] Call GetEventLog before ExitBootServices Jarkko Sakkinen 2017-11-03 15:27 ` Jarkko Sakkinen 2017-09-14 10:21 ` [tpmdd-devel] " Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+zpnLe8hgSgBbjw8zF=pvykNo9mkVcyR65KY=vFckKf+XMb=Q@mail.gmail.com' \ --to=tweek-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \ --cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=ashleydlai-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \ --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \ --cc=mjg59-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \ --cc=nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \ --cc=peterhuewe-Mmb7MZpHnFY@public.gmane.org \ --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ --cc=tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org \ --subject='Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).