From: 김동현 <austindh.kim@gmail.com>
To: SZ Lin <sz.lin@moxa.com>
Cc: ashleydlai@gmail.com, benh@kernel.crashing.org, paulus@samba.org,
mpe@ellerman.id.au, peterhuewe@gmx.de, tpmdd@selhorst.ne,
jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com,
tpmdd-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Use __func__ instead of function name
Date: Sat, 19 Aug 2017 16:58:09 +0900 [thread overview]
Message-ID: <CADLLry4Cdbdy3+gOpHrDhqbHhUdhWgGgWLeN-1MnuurbhS=ZfA@mail.gmail.com> (raw)
In-Reply-To: <20170729072433.13194-6-sz.lin@moxa.com>
I guess below code would be better idea to gather more debug information.
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 643bba7..0aae785 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -141,6 +141,11 @@ static int tpm_ibmvtpm_send(struct tpm_chip
*chip, u8 *buf, size_t count)
return -EIO;
}
+ if (!buf) {
+ dev_err(ibmvtpm->dev, "%s buf null at %d \n",__func__,
rc, __LINE__);
+ return 0;
+ }
+
spin_lock(&ibmvtpm->rtce_lock);
memcpy((void *)ibmvtpm->rtce_buf, (void *)buf, count);
crq.valid = (u8)IBMVTPM_VALID_CMD;
@@ -150,8 +155,9 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip,
u8 *buf, size_t count)
rc = ibmvtpm_send_crq(ibmvtpm->vdev, be64_to_cpu(word[0]),
be64_to_cpu(word[1]));
+
if (rc != H_SUCCESS) {
- dev_err(ibmvtpm->dev, "tpm_ibmvtpm_send failed rc=%d\n", rc);
+ dev_err(ibmvtpm->dev, "%s failed rc=%d at %d
\n",__func__, rc, __LINE__);
rc = 0;
} else
rc = count;
2017-07-29 16:24 GMT+09:00 SZ Lin <sz.lin@moxa.com>:
> Fix following checkpatch.pl warning:
> WARNING: Prefer using '"%s...", __func__' to using
> the function's name, in a string
>
> Signed-off-by: SZ Lin <sz.lin@moxa.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index e75a674b44ac..2d33acc43e25 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -151,7 +151,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
> rc = ibmvtpm_send_crq(ibmvtpm->vdev, be64_to_cpu(word[0]),
> be64_to_cpu(word[1]));
> if (rc != H_SUCCESS) {
> - dev_err(ibmvtpm->dev, "tpm_ibmvtpm_send failed rc=%d\n", rc);
> + dev_err(ibmvtpm->dev, "%s failed rc=%d\n", __func__, rc);
> rc = 0;
> ibmvtpm->tpm_processing_cmd = false;
> } else
> @@ -193,7 +193,7 @@ static int ibmvtpm_crq_get_rtce_size(struct ibmvtpm_dev *ibmvtpm)
> cpu_to_be64(buf[1]));
> if (rc != H_SUCCESS)
> dev_err(ibmvtpm->dev,
> - "ibmvtpm_crq_get_rtce_size failed rc=%d\n", rc);
> + "%s failed rc=%d\n", __func__, rc);
>
> return rc;
> }
> @@ -221,7 +221,7 @@ static int ibmvtpm_crq_get_version(struct ibmvtpm_dev *ibmvtpm)
> cpu_to_be64(buf[1]));
> if (rc != H_SUCCESS)
> dev_err(ibmvtpm->dev,
> - "ibmvtpm_crq_get_version failed rc=%d\n", rc);
> + "%s failed rc=%d\n", __func__, rc);
>
> return rc;
> }
> @@ -241,7 +241,7 @@ static int ibmvtpm_crq_send_init_complete(struct ibmvtpm_dev *ibmvtpm)
> rc = ibmvtpm_send_crq(ibmvtpm->vdev, INIT_CRQ_COMP_CMD, 0);
> if (rc != H_SUCCESS)
> dev_err(ibmvtpm->dev,
> - "ibmvtpm_crq_send_init_complete failed rc=%d\n", rc);
> + "%s rc=%d\n", __func__, rc);
>
> return rc;
> }
> @@ -261,7 +261,7 @@ static int ibmvtpm_crq_send_init(struct ibmvtpm_dev *ibmvtpm)
> rc = ibmvtpm_send_crq(ibmvtpm->vdev, INIT_CRQ_CMD, 0);
> if (rc != H_SUCCESS)
> dev_err(ibmvtpm->dev,
> - "ibmvtpm_crq_send_init failed rc=%d\n", rc);
> + "%s failed rc=%d\n", __func__, rc);
>
> return rc;
> }
> @@ -351,7 +351,7 @@ static int tpm_ibmvtpm_suspend(struct device *dev)
> cpu_to_be64(buf[1]));
> if (rc != H_SUCCESS)
> dev_err(ibmvtpm->dev,
> - "tpm_ibmvtpm_suspend failed rc=%d\n", rc);
> + "%s failed rc=%d\n", __func__, rc);
>
> return rc;
> }
> --
> 2.13.3
>
next prev parent reply other threads:[~2017-08-19 7:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 7:24 [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix SZ Lin
2017-02-24 19:35 ` [RFT PATCH] tpm: ibmvtpm: simplify crq initialization and document crq format Michal Suchanek
2017-08-17 22:21 ` msuchanek
2017-08-19 17:18 ` Jarkko Sakkinen
2017-08-19 17:24 ` Jarkko Sakkinen
2017-07-29 7:24 ` [PATCH 1/5] Fix packed and aligned attribute warnings SZ Lin
2017-07-31 13:27 ` David Laight
2017-07-29 7:24 ` [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible" SZ Lin
2017-07-31 10:25 ` Michael Ellerman
2017-07-29 7:24 ` [PATCH 3/5] Fix 'void function return statements are not generally useful' warning SZ Lin
2017-07-29 7:24 ` [PATCH 4/5] Remove unneccessary 'out of memory' message SZ Lin
2017-07-29 7:24 ` [PATCH 5/5] Use __func__ instead of function name SZ Lin
[not found] ` <20170729072433.13194-6-sz.lin-D4fb9hXD9d4@public.gmane.org>
2017-08-18 8:03 ` Michal Suchánek
[not found] ` <0e2d9ac4f5ee02e9df98610ed07eaec9-l3A5Bk7waGM@public.gmane.org>
2017-08-18 11:25 ` Michael Ellerman
2017-08-19 7:58 ` 김동현 [this message]
2017-08-02 12:36 ` [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADLLry4Cdbdy3+gOpHrDhqbHhUdhWgGgWLeN-1MnuurbhS=ZfA@mail.gmail.com' \
--to=austindh.kim@gmail.com \
--cc=ashleydlai@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterhuewe@gmx.de \
--cc=sz.lin@moxa.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.ne \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).