From: "Frank Wunderlich" <frank-w@public-files.de>
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,
"Eddie Huang" <eddie.huang@mediatek.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Richard Fontana" <rfontana@redhat.com>,
"Allison Randal" <allison@lohutok.net>,
"David S . Miller" <davem@davemloft.net>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rob Herring" <robh@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Paul E . McKenney" <paulmck@linux.ibm.com>,
"Josef Friedl" <josef.friedl@speed.at>
Subject: Aw: Re: Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver
Date: Sat, 6 Jul 2019 18:15:20 +0200 [thread overview]
Message-ID: <trinity-a4e5f99f-00bc-4e90-9a48-64dbc6ba9c08-1562429720701@3c-app-gmx-bs42> (raw)
In-Reply-To: <20190705212448.GB12409@piout.net>
> Gesendet: Freitag, 05. Juli 2019 um 23:24 Uhr
> Von: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
> Let's say the RTC has been used to start your platform, then the irq
> handler will be called as soon as the irq is requested, leading to a
> null pointer dereference.
i cannot test this with my platform, but i have changed it in my repo
https://github.com/frank-w/BPI-R2-4.14/commits/5.2-poweroff-mainline
> Yes and IIRC, I did comment that the rtc change also had to be separated
> from 1/7.
also this is put in separate commit, can you take a look before i post v3?
> Also, I really doubt this new compatible is necessary at all as you
> could simply directly use mediatek,mt6397-rtc.
imho this can confuse because the wrong chip-name is used in dts
regards Frank
WARNING: multiple messages have this Message-ID (diff)
From: "Frank Wunderlich" <frank-w@public-files.de>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
Sebastian Reichel <sre@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,
Eddie Huang <eddie.huang@mediatek.com>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Fontana <rfontana@redhat.com>,
Allison Randal <allison@lohutok.net>,
"David S . Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Aw: Re: Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver
Date: Sat, 6 Jul 2019 18:15:20 +0200 [thread overview]
Message-ID: <trinity-a4e5f99f-00bc-4e90-9a48-64dbc6ba9c08-1562429720701@3c-app-gmx-bs42> (raw)
In-Reply-To: <20190705212448.GB12409@piout.net>
> Gesendet: Freitag, 05. Juli 2019 um 23:24 Uhr
> Von: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
> Let's say the RTC has been used to start your platform, then the irq
> handler will be called as soon as the irq is requested, leading to a
> null pointer dereference.
i cannot test this with my platform, but i have changed it in my repo
https://github.com/frank-w/BPI-R2-4.14/commits/5.2-poweroff-mainline
> Yes and IIRC, I did comment that the rtc change also had to be separated
> from 1/7.
also this is put in separate commit, can you take a look before i post v3?
> Also, I really doubt this new compatible is necessary at all as you
> could simply directly use mediatek,mt6397-rtc.
imho this can confuse because the wrong chip-name is used in dts
regards Frank
WARNING: multiple messages have this Message-ID (diff)
From: "Frank Wunderlich" <frank-w@public-files.de>
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
Richard Fontana <rfontana@redhat.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"Paul E . McKenney" <paulmck@linux.ibm.com>,
Lee Jones <lee.jones@linaro.org>,
linux-rtc@vger.kernel.org, Rob Herring <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
Allison Randal <allison@lohutok.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Josef Friedl <josef.friedl@speed.at>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Reichel <sre@kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Aw: Re: Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver
Date: Sat, 6 Jul 2019 18:15:20 +0200 [thread overview]
Message-ID: <trinity-a4e5f99f-00bc-4e90-9a48-64dbc6ba9c08-1562429720701@3c-app-gmx-bs42> (raw)
In-Reply-To: <20190705212448.GB12409@piout.net>
> Gesendet: Freitag, 05. Juli 2019 um 23:24 Uhr
> Von: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
> Let's say the RTC has been used to start your platform, then the irq
> handler will be called as soon as the irq is requested, leading to a
> null pointer dereference.
i cannot test this with my platform, but i have changed it in my repo
https://github.com/frank-w/BPI-R2-4.14/commits/5.2-poweroff-mainline
> Yes and IIRC, I did comment that the rtc change also had to be separated
> from 1/7.
also this is put in separate commit, can you take a look before i post v3?
> Also, I really doubt this new compatible is necessary at all as you
> could simply directly use mediatek,mt6397-rtc.
imho this can confuse because the wrong chip-name is used in dts
regards Frank
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-06 16:16 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 16:48 [PATCH v2 0/7] implement poweroff for mt6323/6397 Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` [PATCH v2 1/7] docs: dt-bindings: add poweroff Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-04 18:54 ` Alexandre Belloni
2019-07-04 18:54 ` Alexandre Belloni
2019-07-04 18:54 ` Alexandre Belloni
2019-07-03 16:48 ` [PATCH v2 2/7] rtc: mt6397: move some common definitions into rtc.h Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-04 9:11 ` Matthias Brugger
2019-07-04 9:11 ` Matthias Brugger
2019-07-04 9:11 ` Matthias Brugger
2019-07-04 11:49 ` Aw: " Frank Wunderlich
2019-07-04 11:49 ` Frank Wunderlich
2019-07-04 11:49 ` Frank Wunderlich
2019-07-03 16:48 ` [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-04 9:13 ` Matthias Brugger
2019-07-04 9:13 ` Matthias Brugger
2019-07-04 9:13 ` Matthias Brugger
2019-07-04 11:08 ` Aw: " Frank Wunderlich
2019-07-04 11:08 ` Frank Wunderlich
2019-07-04 11:08 ` Frank Wunderlich
2019-07-04 20:43 ` Alexandre Belloni
2019-07-04 20:43 ` Alexandre Belloni
2019-07-04 20:43 ` Alexandre Belloni
2019-07-05 15:35 ` Aw: " Frank Wunderlich
2019-07-05 15:35 ` Frank Wunderlich
2019-07-05 15:35 ` Frank Wunderlich
2019-07-05 21:24 ` Alexandre Belloni
2019-07-05 21:24 ` Alexandre Belloni
2019-07-05 21:24 ` Alexandre Belloni
2019-07-06 16:15 ` Frank Wunderlich [this message]
2019-07-06 16:15 ` Aw: " Frank Wunderlich
2019-07-06 16:15 ` Frank Wunderlich
2019-07-06 20:04 ` Alexandre Belloni
2019-07-06 20:04 ` Alexandre Belloni
2019-07-06 20:04 ` Alexandre Belloni
2019-07-03 16:48 ` [PATCH v2 4/7] mfd: mt6323: some improvements of mt6397-core Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` [PATCH v2 5/7] power: reset: add driver for mt6323 poweroff Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-04 9:15 ` Matthias Brugger
2019-07-04 9:15 ` Matthias Brugger
2019-07-04 9:15 ` Matthias Brugger
[not found] ` <d162c95d-773e-f364-0e06-07f67c5b0cbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-07-04 10:55 ` Frank Wunderlich
2019-07-04 10:03 ` Ran Bi
2019-07-04 10:03 ` Ran Bi
2019-07-04 10:03 ` Ran Bi
2019-07-04 11:06 ` Aw: " Frank Wunderlich
2019-07-04 11:06 ` Frank Wunderlich
2019-07-04 11:06 ` Frank Wunderlich
2019-07-03 16:48 ` [PATCH v2 6/7] MAINTAINERS: add Mediatek shutdown drivers Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` [PATCH v2 7/7] arm: dts: mt6323: add keys, power-controller, rtc and codec Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
2019-07-03 16:48 ` Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-a4e5f99f-00bc-4e90-9a48-64dbc6ba9c08-1562429720701@3c-app-gmx-bs42 \
--to=frank-w@public-files.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allison@lohutok.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=josef.friedl@speed.at \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=paulmck@linux.ibm.com \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.