* [PATCH] arm: mvebu: Espressobin: Fix URLs in comments
@ 2022-01-21 11:01 Pali Rohár
2022-01-23 7:19 ` Stefan Roese
2022-01-31 11:31 ` Stefan Roese
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2022-01-21 11:01 UTC (permalink / raw)
To: Stefan Roese; +Cc: u-boot
Use versioned URLs for line numbers as branches are moving in the time and
use master branch for mv-ddr-marvell where is up-to-date code.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
board/Marvell/mvebu_armada-37xx/board.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c
index e0e7720e4a1a..adee444555cf 100644
--- a/board/Marvell/mvebu_armada-37xx/board.c
+++ b/board/Marvell/mvebu_armada-37xx/board.c
@@ -59,11 +59,11 @@ DECLARE_GLOBAL_DATA_PTR;
* Memory Controller Registers
*
* Assembled based on public information:
- * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/master/wtmi/main.c#L332-336
+ * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/v2020.11.26/wtmi/main.c#L332-336
* https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-18.12/drivers/mv_ddr_mc6.h#L309-L332
*
* And checked against the written register values for the various topologies:
- * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-atf-mainline/a3700/mv_ddr_tim.h
+ * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/master/a3700/mv_ddr_tim.h
*/
#define A3700_CH0_MC_CTRL2_REG MVEBU_REGISTER(0x002c4)
#define A3700_MC_CTRL2_SDRAM_TYPE_MASK 0xf
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: mvebu: Espressobin: Fix URLs in comments
2022-01-21 11:01 [PATCH] arm: mvebu: Espressobin: Fix URLs in comments Pali Rohár
@ 2022-01-23 7:19 ` Stefan Roese
2022-01-31 11:31 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2022-01-23 7:19 UTC (permalink / raw)
To: Pali Rohár; +Cc: u-boot
On 1/21/22 12:01, Pali Rohár wrote:
> Use versioned URLs for line numbers as branches are moving in the time and
> use master branch for mv-ddr-marvell where is up-to-date code.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> board/Marvell/mvebu_armada-37xx/board.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c
> index e0e7720e4a1a..adee444555cf 100644
> --- a/board/Marvell/mvebu_armada-37xx/board.c
> +++ b/board/Marvell/mvebu_armada-37xx/board.c
> @@ -59,11 +59,11 @@ DECLARE_GLOBAL_DATA_PTR;
> * Memory Controller Registers
> *
> * Assembled based on public information:
> - * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/master/wtmi/main.c#L332-336
> + * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/v2020.11.26/wtmi/main.c#L332-336
> * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-18.12/drivers/mv_ddr_mc6.h#L309-L332
> *
> * And checked against the written register values for the various topologies:
> - * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-atf-mainline/a3700/mv_ddr_tim.h
> + * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/master/a3700/mv_ddr_tim.h
> */
> #define A3700_CH0_MC_CTRL2_REG MVEBU_REGISTER(0x002c4)
> #define A3700_MC_CTRL2_SDRAM_TYPE_MASK 0xf
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: mvebu: Espressobin: Fix URLs in comments
2022-01-21 11:01 [PATCH] arm: mvebu: Espressobin: Fix URLs in comments Pali Rohár
2022-01-23 7:19 ` Stefan Roese
@ 2022-01-31 11:31 ` Stefan Roese
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2022-01-31 11:31 UTC (permalink / raw)
To: Pali Rohár; +Cc: u-boot
On 1/21/22 12:01, Pali Rohár wrote:
> Use versioned URLs for line numbers as branches are moving in the time and
> use master branch for mv-ddr-marvell where is up-to-date code.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
> board/Marvell/mvebu_armada-37xx/board.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c
> index e0e7720e4a1a..adee444555cf 100644
> --- a/board/Marvell/mvebu_armada-37xx/board.c
> +++ b/board/Marvell/mvebu_armada-37xx/board.c
> @@ -59,11 +59,11 @@ DECLARE_GLOBAL_DATA_PTR;
> * Memory Controller Registers
> *
> * Assembled based on public information:
> - * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/master/wtmi/main.c#L332-336
> + * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/v2020.11.26/wtmi/main.c#L332-336
> * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-18.12/drivers/mv_ddr_mc6.h#L309-L332
> *
> * And checked against the written register values for the various topologies:
> - * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-atf-mainline/a3700/mv_ddr_tim.h
> + * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/master/a3700/mv_ddr_tim.h
> */
> #define A3700_CH0_MC_CTRL2_REG MVEBU_REGISTER(0x002c4)
> #define A3700_MC_CTRL2_SDRAM_TYPE_MASK 0xf
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-31 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-21 11:01 [PATCH] arm: mvebu: Espressobin: Fix URLs in comments Pali Rohár
2022-01-23 7:19 ` Stefan Roese
2022-01-31 11:31 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).