Re: [PATCH 2/6] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

[Michael Walle <michael@walle.cc>]

Am 2022-08-30 13:53, schrieb Stefan Roese:
> Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE
> enabled, like pogo_v4.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  drivers/timer/orion-timer.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/timer/orion-timer.c b/drivers/timer/orion-timer.c
> index 02ed138642b8..7e920eaeaa40 100644
> --- a/drivers/timer/orion-timer.c
> +++ b/drivers/timer/orion-timer.c
> @@ -41,6 +41,28 @@ u64 notrace timer_early_get_count(void)
>  }
>  #endif
> 
> +#if CONFIG_IS_ENABLED(BOOTSTAGE)
> +ulong timer_get_boot_us(void)
> +{
> +	u64 ticks = 0;
> +	u32 rate = 1;
> +	u64 us;
> +	int ret;
> +
> +	ret = dm_timer_init();
> +	if (!ret) {
> +		/* The timer is available */
> +		rate = timer_get_rate(gd->timer);
> +		timer_get_count(gd->timer, &ticks);
> +	} else {
> +		return 0;
> +	}
> +
> +	us = (ticks * 1000) / rate;
> +	return us;
> +}
> +#endif

This is duplicate code in almost all the timer drivers, shouldn't
this be a (weak) default implementation in timer-uclass.c? Also,
do you need to guard it with CONFIG_IS_ENABLED(BOOTSTAGE), aren't
unused functions discarded anyway?

-michael