From: Wolfgang Denk <wd@denx.de>
To: Paul Barker <paul.barker@sancloud.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 3/3] exports: Fix export of SPI access functions
Date: Fri, 26 Aug 2022 15:42:44 +0200 [thread overview]
Message-ID: <13212.1661521364@gemini.denx.de> (raw)
In-Reply-To: <20220505153242.1598807-4-paul.barker@sancloud.com>
Dear Paul,
In message <20220505153242.1598807-4-paul.barker@sancloud.com> you wrote:
> * With CONFIG_DM_SPI defined, spi_get_bus_and_cs needs to be used
> instead of spi_setup_slave to configure a SPI bus. As spi_setup_slave is
> already present in the export list it is reasonable to also export
> spi_get_bus_and_cs.
>
> * For the functions listed in the jump table to be callable they must
> also be defined in the "exports.h" header. Define the various exported
> SPI functions so that they can be used.
>
> Signed-off-by: Paul Barker <paul.barker@sancloud.com>
> ---
> include/_exports.h | 4 ++++
> include/exports.h | 15 ++++++++++++++-
> 2 files changed, 18 insertions(+), 1 deletion(-)
Sorry, but I disagree here. The SPI functions should have never
been part of the export interface. As far as I can see now, they
have been added by commit bedd8403f7
export SPI functions to standalone apps
While we're here, fix the broken #ifdef handling in _exports.h.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
in 2009. Actually I must even have seen them, as I complained about
incorrect comment style :-(
But no, SPI support should not be inclluded. I2C was there because
it was needed for reading the environment from an EEPROM, but then
the interface was frozen ano no more new interfices / drivers should
be allowed.
Viele Grüße,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr. 5, 82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
If you can't explain it to a six year old, you don't understand it
yourself. - Albert Einstein
prev parent reply other threads:[~2022-08-26 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 15:32 [PATCH 0/3] Clarify standalone application support Paul Barker
2022-05-05 15:32 ` [PATCH 1/3] Licenses: Clarify exceptions for standalone apps Paul Barker
2022-05-11 13:34 ` Tom Rini
2022-08-26 13:35 ` Wolfgang Denk
2022-10-26 19:26 ` Tom Rini
2022-05-05 15:32 ` [PATCH 2/3] examples: hello_world: Drop inclusion of common header Paul Barker
2022-05-11 13:34 ` Tom Rini
2022-08-26 13:36 ` Wolfgang Denk
2022-10-26 19:26 ` Tom Rini
2022-05-05 15:32 ` [PATCH 3/3] exports: Fix export of SPI access functions Paul Barker
2022-05-11 13:34 ` Tom Rini
2022-08-26 13:42 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13212.1661521364@gemini.denx.de \
--to=wd@denx.de \
--cc=paul.barker@sancloud.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).