Re: [PATCH v2 05/15] i.MX6: Enable Job ring driver model in U-Boot.

From: Ye Li <ye.li@nxp.com>
To: Gaurav Jain <gaurav.jain@nxp.com>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: "olteanv@gmail.com" <olteanv@gmail.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	Pankaj Gupta <pankaj.gupta@nxp.com>,
	Mingkai Hu <mingkai.hu@nxp.com>,
	Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
	Silvano Di Ninno <silvano.dininno@nxp.com>,
	"sjg@chromium.org" <sjg@chromium.org>, Ji Luo <ji.luo@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-uboot-imx <uboot-imx@nxp.com>,
	Shengzhou Liu <shengzhou.liu@nxp.com>,
	Rajesh Bhagat <rajesh.bhagat@nxp.com>,
	Franck Lenormand <franck.lenormand@nxp.com>,
	Varun Sethi <V.Sethi@nxp.com>, Alison Wang <alison.wang@nxp.com>,
	Peng Fan <peng.fan@nxp.com>, Wasim Khan <wasim.khan@nxp.com>,
	Pramod Kumar <pramod.kumar_1@nxp.com>,
	"sbabic@denx.de" <sbabic@denx.de>,
	Horia Geanta <horia.geanta@nxp.com>,
	Andy Tang <andy.tang@nxp.com>,
	Sahil Malhotra <sahil.malhotra@nxp.com>,
	Adrian Alonso <adrian.alonso@nxp.com>
Subject: Re: [PATCH v2 05/15] i.MX6: Enable Job ring driver model in U-Boot.
Date: Fri, 10 Sep 2021 09:20:46 +0000	[thread overview]
Message-ID: <1631265617.43076.28.camel@nxp.com> (raw)
In-Reply-To: <20210903070319.13484-6-gaurav.jain@nxp.com>

On Fri, 2021-09-03 at 12:33 +0530, Gaurav Jain wrote:
> i.MX6(SX/UL) - added support for JR driver model.
> 
> removed sec_init() call, sec is initialized based on
> job ring information processed from device tree.
> 
> Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> ---
>  arch/arm/mach-imx/mx6/Kconfig |  8 ++++++++
>  arch/arm/mach-imx/mx6/soc.c   | 12 ++++++++----
>  2 files changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-
> imx/mx6/Kconfig
> index 789a50d4e9..a7109bb512 100644
> --- a/arch/arm/mach-imx/mx6/Kconfig
> +++ b/arch/arm/mach-imx/mx6/Kconfig
> @@ -378,6 +378,10 @@ config TARGET_MX6SXSABRESD
>  	select DM
>  	select DM_THERMAL
>  	select SUPPORT_SPL
> +	select FSL_CAAM
> +	select FSL_BLOB
> +	select MISC
> +	select ARCH_MISC_INIT
>  
>  config TARGET_MX6SXSABREAUTO
>  	bool "mx6sxsabreauto"
> @@ -405,6 +409,10 @@ config TARGET_MX6UL_14X14_EVK
>  	select DM_THERMAL
>  	select SUPPORT_SPL
>  	imply CMD_DM
> +	select FSL_CAAM
> +	select FSL_BLOB
> +	select MISC
> +	select ARCH_MISC_INIT
>  

Can you also enable the JR driver for MX6SABREAUTO, MX6SABRESD and
MX6UL_9X9_EVK?

Best regards,
Ye Li

>  config TARGET_MX6UL_ENGICAM
>  	bool "Support Engicam GEAM6UL/Is.IoT"
> diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-
> imx/mx6/soc.c
> index aacfc854a2..fa6c3778bb 100644
> --- a/arch/arm/mach-imx/mx6/soc.c
> +++ b/arch/arm/mach-imx/mx6/soc.c
> @@ -4,6 +4,7 @@
>   * Sascha Hauer, Pengutronix
>   *
>   * (C) Copyright 2009 Freescale Semiconductor, Inc.
> + * Copyright 2021 NXP
>   */
>  
>  #include <common.h>
> @@ -23,7 +24,6 @@
>  #include <asm/arch/mxc_hdmi.h>
>  #include <asm/arch/crm_regs.h>
>  #include <dm.h>
> -#include <fsl_sec.h>
>  #include <imx_thermal.h>
>  #include <mmc.h>
>  
> @@ -734,9 +734,13 @@ static void setup_serial_number(void)
>  
>  int arch_misc_init(void)
>  {
> -#ifdef CONFIG_FSL_CAAM
> -	sec_init();
> -#endif
> +	struct udevice *dev;
> +	int ret;
> +
> +	ret = uclass_get_device_by_driver(UCLASS_MISC,
> DM_DRIVER_GET(caam_jr), &dev);
> +	if (ret)
> +		printf("Failed to initialize %s: %d\n", dev->name,
> ret);
> +
>  	setup_serial_number();
>  	return 0;
>  }