From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com>
To: Michal Simek <michal.simek@amd.com>,
Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>,
u-boot@lists.denx.de
Cc: adrian.fiergolski@fastree3d.com, jh80.chung@samsung.com,
sven@svenpeter.dev, kettenis@openbsd.org, sjg@chromium.org,
git@xilinx.com, git@amd.com
Subject: Re: [PATCH 2/5] firmware: zynqmp: Load config overlay for core0 to pmufw
Date: Sat, 16 Jul 2022 13:17:44 +0200 [thread overview]
Message-ID: <18849dd4-eadc-415f-9e6f-28bf2c4cd2b9@weidmueller.com> (raw)
In-Reply-To: <22a75fb0-51b8-7f88-1d45-fa33819156a5@amd.com>
Am 15.07.2022 um 18:34 schrieb Michal Simek:
>
>
> On 7/15/22 18:13, Stefan Herbrechtsmeier wrote:
>> Am 15.07.2022 um 11:39 schrieb Ashok Reddy Soma:
>>> Try loading pmufw config overlay for core0, if it doesn't return any
>>> error it means pmufw is accepting nodes for other IP's. Otherwise dont
>>> try to load config object for any other IP, just return from
>>> zynqmp_pmufw_node function.
>>>
>>> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>>> ---
>>>
>>> drivers/firmware/firmware-zynqmp.c | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/firmware/firmware-zynqmp.c
>>> b/drivers/firmware/firmware-zynqmp.c
>>> index 34d9b47003..288151533e 100644
>>> --- a/drivers/firmware/firmware-zynqmp.c
>>> +++ b/drivers/firmware/firmware-zynqmp.c
>>> @@ -68,8 +68,13 @@ int zynqmp_pmufw_config_close(void)
>>> return 0;
>>> }
>>> +static bool config_enabled;
>>> +
>>
>> Please move the variable inside the function.
>
> How can this work? When you move it to zynqmp_pmufw_node() then won't be
> visible in zynqmp_power_probe() and vice-versa.
If you reuse the zynqmp_pmufw_node function in zynqmp_power_probe
function you can check the id parameter to update the config_enabled
variable in zynqmp_pmufw_node.
next prev parent reply other threads:[~2022-07-16 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 9:39 [PATCH 0/5] Enable power domain driver in ZynqMP and Versal Ashok Reddy Soma
2022-07-15 9:39 ` [PATCH 1/5] firmware: zynqmp: Change prototype of zynqmp_pmufw_load_config_object() Ashok Reddy Soma
2022-07-15 9:39 ` [PATCH 2/5] firmware: zynqmp: Load config overlay for core0 to pmufw Ashok Reddy Soma
2022-07-15 16:13 ` Stefan Herbrechtsmeier
2022-07-15 16:34 ` Michal Simek
2022-07-16 11:17 ` Stefan Herbrechtsmeier [this message]
2022-07-19 4:44 ` Soma, Ashok Reddy
2022-07-20 16:02 ` Stefan Herbrechtsmeier
2022-07-21 11:53 ` Soma, Ashok Reddy
2022-07-15 9:39 ` [PATCH 3/5] arm64: zynqmp: Enable power domain driver Ashok Reddy Soma
2022-07-15 9:39 ` [PATCH 4/5] mailbox: zynqmp: Move struct zynqmp_ipi_msg from sys_proto.h Ashok Reddy Soma
2022-07-15 9:39 ` [PATCH 5/5] arm64: versal: Enable power domain driver and its dependencies Ashok Reddy Soma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18849dd4-eadc-415f-9e6f-28bf2c4cd2b9@weidmueller.com \
--to=stefan.herbrechtsmeier-oss@weidmueller.com \
--cc=adrian.fiergolski@fastree3d.com \
--cc=ashok.reddy.soma@xilinx.com \
--cc=git@amd.com \
--cc=git@xilinx.com \
--cc=jh80.chung@samsung.com \
--cc=kettenis@openbsd.org \
--cc=michal.simek@amd.com \
--cc=sjg@chromium.org \
--cc=sven@svenpeter.dev \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).