[PATCH 1/1] efi_loader: TPL_HIGH_LEVEL not allowed for CreateEvent

[PATCH 1/1] efi_loader: TPL_HIGH_LEVEL not allowed for CreateEvent

[Heinrich Schuchardt]

According to chapter 7.1 "Event, Timer, and Task Priority Services"
TPL_HIGH_LEVEL should not be exposed to applications and drivers.

According to the discussion with EDK II contributors this implies that
CreateEvent() shall not allow to create events with TPL_HIGH_LEVEL.

Cf. https://edk2.groups.io/g/devel/message/76337

Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 lib/efi_loader/efi_boottime.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index 4777b35fd4..f6d5ba05e3 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -264,7 +264,6 @@ efi_status_t is_valid_tpl(efi_uintn_t tpl)
 	case TPL_APPLICATION:
 	case TPL_CALLBACK:
 	case TPL_NOTIFY:
-	case TPL_HIGH_LEVEL:
 		return EFI_SUCCESS;
 	default:
 		return EFI_INVALID_PARAMETER;
--
2.30.2

RE: [PATCH 1/1] efi_loader: TPL_HIGH_LEVEL not allowed for CreateEvent

[Samer El-Haj-Mahmoud]

Acked-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Thursday, June 10, 2021 5:26 PM
> To: Alexander Graf <agraf@csgraf.de>
> Cc: u-boot@lists.denx.de; Heinrich Schuchardt <xypron.glpk@gmx.de>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Subject: [PATCH 1/1] efi_loader: TPL_HIGH_LEVEL not allowed for
> CreateEvent
>
> According to chapter 7.1 "Event, Timer, and Task Priority Services"
> TPL_HIGH_LEVEL should not be exposed to applications and drivers.
>
> According to the discussion with EDK II contributors this implies that
> CreateEvent() shall not allow to create events with TPL_HIGH_LEVEL.
>
> Cf. https://edk2.groups.io/g/devel/message/76337
>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  lib/efi_loader/efi_boottime.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
> index 4777b35fd4..f6d5ba05e3 100644
> --- a/lib/efi_loader/efi_boottime.c
> +++ b/lib/efi_loader/efi_boottime.c
> @@ -264,7 +264,6 @@ efi_status_t is_valid_tpl(efi_uintn_t tpl)
>       case TPL_APPLICATION:
>       case TPL_CALLBACK:
>       case TPL_NOTIFY:
> -     case TPL_HIGH_LEVEL:
>               return EFI_SUCCESS;
>       default:
>               return EFI_INVALID_PARAMETER;
> --
> 2.30.2

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.