* [PATCH] scripts/get_maintainer.pl: obey ignore list
@ 2021-06-11 3:37 Trevor Woerner
2021-06-11 14:23 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Trevor Woerner @ 2021-06-11 3:37 UTC (permalink / raw)
To: U-Boot Mailing List
If the user creates a .get_maintainer.ignore file, make sure it is consulted
and obeyed for *all* emails discovered by the script.
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
scripts/get_maintainer.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index e3b41616c9..8c0fb8656e 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -2435,6 +2435,7 @@ sub merge_email {
for (@_) {
my ($address, $role) = @$_;
+ next if (ignore_email_address($address));
if (!$saw{$address}) {
if ($output_roles) {
push(@lines, "$address ($role)");
--
2.30.0.rc0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/get_maintainer.pl: obey ignore list
2021-06-11 3:37 [PATCH] scripts/get_maintainer.pl: obey ignore list Trevor Woerner
@ 2021-06-11 14:23 ` Tom Rini
2021-06-11 14:56 ` Trevor Woerner
0 siblings, 1 reply; 4+ messages in thread
From: Tom Rini @ 2021-06-11 14:23 UTC (permalink / raw)
To: Trevor Woerner; +Cc: U-Boot Mailing List
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
On Thu, Jun 10, 2021 at 11:37:27PM -0400, Trevor Woerner wrote:
> If the user creates a .get_maintainer.ignore file, make sure it is consulted
> and obeyed for *all* emails discovered by the script.
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> scripts/get_maintainer.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index e3b41616c9..8c0fb8656e 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -2435,6 +2435,7 @@ sub merge_email {
>
> for (@_) {
> my ($address, $role) = @$_;
> + next if (ignore_email_address($address));
> if (!$saw{$address}) {
> if ($output_roles) {
> push(@lines, "$address ($role)");
This got me to check and see that yes, our copy of get_maintainers.pl is
out of date from Linux. And in fact, a re-sync will let us add a
.get_maintainer.conf file and use upstream a lot more closely as it now
has logic to find all MAINTAINERS files in a tree.
But this change isn't upstream. Please work with Joe Perches upstream
to get this change accepted and it'll flow down to us and not get
overwritten when I forget it was an intentional change :) Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/get_maintainer.pl: obey ignore list
2021-06-11 14:23 ` Tom Rini
@ 2021-06-11 14:56 ` Trevor Woerner
2021-06-11 21:06 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Trevor Woerner @ 2021-06-11 14:56 UTC (permalink / raw)
To: Tom Rini; +Cc: U-Boot Mailing List
Hi Tom,
On Fri 2021-06-11 @ 10:23:01 AM, Tom Rini wrote:
> On Thu, Jun 10, 2021 at 11:37:27PM -0400, Trevor Woerner wrote:
>
> > If the user creates a .get_maintainer.ignore file, make sure it is consulted
> > and obeyed for *all* emails discovered by the script.
> >
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> > scripts/get_maintainer.pl | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > index e3b41616c9..8c0fb8656e 100755
> > --- a/scripts/get_maintainer.pl
> > +++ b/scripts/get_maintainer.pl
> > @@ -2435,6 +2435,7 @@ sub merge_email {
> >
> > for (@_) {
> > my ($address, $role) = @$_;
> > + next if (ignore_email_address($address));
> > if (!$saw{$address}) {
> > if ($output_roles) {
> > push(@lines, "$address ($role)");
>
> This got me to check and see that yes, our copy of get_maintainers.pl is
> out of date from Linux. And in fact, a re-sync will let us add a
> .get_maintainer.conf file and use upstream a lot more closely as it now
> has logic to find all MAINTAINERS files in a tree.
>
> But this change isn't upstream. Please work with Joe Perches upstream
> to get this change accepted and it'll flow down to us and not get
> overwritten when I forget it was an intentional change :) Thanks!
Thanks for the tip!
I ran my patches through the kernel's latest get_maintainer.pl script and it
correctly removes email entries that are listed in my ~/.get_maintainer.ignore
file without any changes required. Therefore a re-sync would appear to fix the
issue I found.
I can take a look at the re-sync if you wish? It's unclear to me whether
you're looking into the re-sync or not.
Best regards,
Trevor
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/get_maintainer.pl: obey ignore list
2021-06-11 14:56 ` Trevor Woerner
@ 2021-06-11 21:06 ` Tom Rini
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-06-11 21:06 UTC (permalink / raw)
To: Trevor Woerner; +Cc: U-Boot Mailing List
[-- Attachment #1: Type: text/plain, Size: 2077 bytes --]
On Fri, Jun 11, 2021 at 10:56:55AM -0400, Trevor Woerner wrote:
> Hi Tom,
>
> On Fri 2021-06-11 @ 10:23:01 AM, Tom Rini wrote:
> > On Thu, Jun 10, 2021 at 11:37:27PM -0400, Trevor Woerner wrote:
> >
> > > If the user creates a .get_maintainer.ignore file, make sure it is consulted
> > > and obeyed for *all* emails discovered by the script.
> > >
> > > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > > ---
> > > scripts/get_maintainer.pl | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > > index e3b41616c9..8c0fb8656e 100755
> > > --- a/scripts/get_maintainer.pl
> > > +++ b/scripts/get_maintainer.pl
> > > @@ -2435,6 +2435,7 @@ sub merge_email {
> > >
> > > for (@_) {
> > > my ($address, $role) = @$_;
> > > + next if (ignore_email_address($address));
> > > if (!$saw{$address}) {
> > > if ($output_roles) {
> > > push(@lines, "$address ($role)");
> >
> > This got me to check and see that yes, our copy of get_maintainers.pl is
> > out of date from Linux. And in fact, a re-sync will let us add a
> > .get_maintainer.conf file and use upstream a lot more closely as it now
> > has logic to find all MAINTAINERS files in a tree.
> >
> > But this change isn't upstream. Please work with Joe Perches upstream
> > to get this change accepted and it'll flow down to us and not get
> > overwritten when I forget it was an intentional change :) Thanks!
>
> Thanks for the tip!
>
> I ran my patches through the kernel's latest get_maintainer.pl script and it
> correctly removes email entries that are listed in my ~/.get_maintainer.ignore
> file without any changes required. Therefore a re-sync would appear to fix the
> issue I found.
>
> I can take a look at the re-sync if you wish? It's unclear to me whether
> you're looking into the re-sync or not.
Please do. I took a quick attempt at it, but I couldn't convince it to
use all of our MAINTAINERS files, by default, for some reason. Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-11 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 3:37 [PATCH] scripts/get_maintainer.pl: obey ignore list Trevor Woerner
2021-06-11 14:23 ` Tom Rini
2021-06-11 14:56 ` Trevor Woerner
2021-06-11 21:06 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).