* [PATCH] command: Fix SMC and HVC maximum number of arguments
@ 2021-07-15 4:38 Siew Chin Lim
2021-07-20 18:33 ` Simon Glass
2021-07-24 20:40 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Siew Chin Lim @ 2021-07-15 4:38 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Ley Foon Tan, Simon Goldschmidt, Tien Fong Chee,
Dalon Westergreen, Simon Glass, Yau Wai Gan, Siew Chin Lim
smc and hvc commands take upto 8 user input arguments, the maximum
number of arguments of the U_BOOT_CMD macro should set to 9.
Besides, fix the typo (arg7 -> arg6) in hvc command's help message.
Signed-off-by: Siew Chin Lim <elly.siew.chin.lim@intel.com>
---
cmd/smccc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cmd/smccc.c b/cmd/smccc.c
index 0b19f6c68c..0ff9a08021 100644
--- a/cmd/smccc.c
+++ b/cmd/smccc.c
@@ -50,7 +50,7 @@ static int do_call(struct cmd_tbl *cmdtp, int flag, int argc,
#ifdef CONFIG_CMD_SMC
U_BOOT_CMD(
- smc, 8, 2, do_call,
+ smc, 9, 2, do_call,
"Issue a Secure Monitor Call",
"<fid> [arg1 ... arg6] [id]\n"
" - fid Function ID\n"
@@ -61,9 +61,9 @@ U_BOOT_CMD(
#ifdef CONFIG_CMD_HVC
U_BOOT_CMD(
- hvc, 8, 2, do_call,
+ hvc, 9, 2, do_call,
"Issue a Hypervisor Call",
- "<fid> [arg1...arg7] [id]\n"
+ "<fid> [arg1...arg6] [id]\n"
" - fid Function ID\n"
" - arg HVC arguments, passed to X1-X6 (default to zero)\n"
" - id Session ID, passed to W7 (defaults to zero)\n"
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] command: Fix SMC and HVC maximum number of arguments
2021-07-15 4:38 [PATCH] command: Fix SMC and HVC maximum number of arguments Siew Chin Lim
@ 2021-07-20 18:33 ` Simon Glass
2021-07-24 20:40 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-07-20 18:33 UTC (permalink / raw)
To: Siew Chin Lim
Cc: U-Boot Mailing List, Marek Vasut, Ley Foon Tan,
Simon Goldschmidt, Tien Fong Chee, Dalon Westergreen,
Yau Wai Gan
On Wed, 14 Jul 2021 at 22:39, Siew Chin Lim
<elly.siew.chin.lim@intel.com> wrote:
>
> smc and hvc commands take upto 8 user input arguments, the maximum
> number of arguments of the U_BOOT_CMD macro should set to 9.
>
> Besides, fix the typo (arg7 -> arg6) in hvc command's help message.
>
> Signed-off-by: Siew Chin Lim <elly.siew.chin.lim@intel.com>
> ---
> cmd/smccc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] command: Fix SMC and HVC maximum number of arguments
2021-07-15 4:38 [PATCH] command: Fix SMC and HVC maximum number of arguments Siew Chin Lim
2021-07-20 18:33 ` Simon Glass
@ 2021-07-24 20:40 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-07-24 20:40 UTC (permalink / raw)
To: Siew Chin Lim
Cc: u-boot, Marek Vasut, Ley Foon Tan, Simon Goldschmidt,
Tien Fong Chee, Dalon Westergreen, Simon Glass, Yau Wai Gan
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
On Thu, Jul 15, 2021 at 12:38:54PM +0800, Siew Chin Lim wrote:
> smc and hvc commands take upto 8 user input arguments, the maximum
> number of arguments of the U_BOOT_CMD macro should set to 9.
>
> Besides, fix the typo (arg7 -> arg6) in hvc command's help message.
>
> Signed-off-by: Siew Chin Lim <elly.siew.chin.lim@intel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-24 20:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 4:38 [PATCH] command: Fix SMC and HVC maximum number of arguments Siew Chin Lim
2021-07-20 18:33 ` Simon Glass
2021-07-24 20:40 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).