* [PATCH] reset: ast2600: Fix missing reference operator
@ 2021-07-20 7:01 Chia-Wei Wang
2021-07-24 20:41 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Chia-Wei Wang @ 2021-07-20 7:01 UTC (permalink / raw)
To: u-boot; +Cc: ryan_chen
Fix missing reference operator '&' to correctly get
HW register addresses for writel().
Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
---
drivers/reset/reset-ast2600.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/reset/reset-ast2600.c b/drivers/reset/reset-ast2600.c
index f64adaf74e..195ddd18e0 100644
--- a/drivers/reset/reset-ast2600.c
+++ b/drivers/reset/reset-ast2600.c
@@ -41,9 +41,9 @@ static int ast2600_reset_assert(struct reset_ctl *reset_ctl)
debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
if (reset_ctl->id < 32)
- writel(BIT(reset_ctl->id), scu->modrst_ctrl1);
+ writel(BIT(reset_ctl->id), &scu->modrst_ctrl1);
else
- writel(BIT(reset_ctl->id - 32), scu->modrst_ctrl2);
+ writel(BIT(reset_ctl->id - 32), &scu->modrst_ctrl2);
return 0;
}
@@ -56,9 +56,9 @@ static int ast2600_reset_deassert(struct reset_ctl *reset_ctl)
debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
if (reset_ctl->id < 32)
- writel(BIT(reset_ctl->id), scu->modrst_clr1);
+ writel(BIT(reset_ctl->id), &scu->modrst_clr1);
else
- writel(BIT(reset_ctl->id - 32), scu->modrst_clr2);
+ writel(BIT(reset_ctl->id - 32), &scu->modrst_clr2);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: ast2600: Fix missing reference operator
2021-07-20 7:01 [PATCH] reset: ast2600: Fix missing reference operator Chia-Wei Wang
@ 2021-07-24 20:41 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2021-07-24 20:41 UTC (permalink / raw)
To: Chia-Wei Wang; +Cc: u-boot, ryan_chen
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
On Tue, Jul 20, 2021 at 03:01:36PM +0800, Chia-Wei Wang wrote:
> Fix missing reference operator '&' to correctly get
> HW register addresses for writel().
>
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-24 20:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 7:01 [PATCH] reset: ast2600: Fix missing reference operator Chia-Wei Wang
2021-07-24 20:41 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).