u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH] rockchip: Fix u-boot-rockchip.bin build
@ 2021-07-25 14:25 Johan Gunnarsson
  2021-07-26 14:07 ` Simon Glass
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Johan Gunnarsson @ 2021-07-25 14:25 UTC (permalink / raw)
  To: u-boot
  Cc: Johan Gunnarsson, Bharat Gooty, Kever Yang, Philipp Tomsich,
	Rayagonda Kokatanur, Simon Glass

Currently there are a few arm32 rockchip board configs that don't
generate u-boot-rockchip.bin when running make because CONFIG_BINMAN
is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select
CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64.

Example builds that don't generate u-boot-rockchip.bin without this
patch:

export ARCH=arm
export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
make kylin-rk3036_defconfig
make

export ARCH=arm
export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
make rock_defconfig
make

export ARCH=arm
export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
make tinker-rk3288_defconfig
make

Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com>
---

 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 9de97cc101..5a8672cdd6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1791,7 +1791,7 @@ config ARCH_STM32MP
 config ARCH_ROCKCHIP
 	bool "Support Rockchip SoCs"
 	select BLK
-	select BINMAN if SPL_OPTEE
+	select BINMAN if SPL_OPTEE || (SPL && !ARM64)
 	select DM
 	select DM_GPIO
 	select DM_I2C
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: Fix u-boot-rockchip.bin build
  2021-07-25 14:25 [PATCH] rockchip: Fix u-boot-rockchip.bin build Johan Gunnarsson
@ 2021-07-26 14:07 ` Simon Glass
  2021-08-11  9:41 ` Kever Yang
  2021-08-11 10:18 ` Kever Yang
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2021-07-26 14:07 UTC (permalink / raw)
  To: Johan Gunnarsson
  Cc: U-Boot Mailing List, Bharat Gooty, Kever Yang, Philipp Tomsich,
	Rayagonda Kokatanur

On Sun, 25 Jul 2021 at 08:26, Johan Gunnarsson
<johan.gunnarsson@gmail.com> wrote:
>
> Currently there are a few arm32 rockchip board configs that don't
> generate u-boot-rockchip.bin when running make because CONFIG_BINMAN
> is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select
> CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64.
>
> Example builds that don't generate u-boot-rockchip.bin without this
> patch:
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make kylin-rk3036_defconfig
> make
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make rock_defconfig
> make
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make tinker-rk3288_defconfig
> make
>
> Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com>
> ---
>
>  arch/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: Fix u-boot-rockchip.bin build
  2021-07-25 14:25 [PATCH] rockchip: Fix u-boot-rockchip.bin build Johan Gunnarsson
  2021-07-26 14:07 ` Simon Glass
@ 2021-08-11  9:41 ` Kever Yang
  2021-08-11 10:18 ` Kever Yang
  2 siblings, 0 replies; 4+ messages in thread
From: Kever Yang @ 2021-08-11  9:41 UTC (permalink / raw)
  To: Johan Gunnarsson
  Cc: U-Boot-Denx, Bharat Gooty, Kever Yang, Philipp Tomsich,
	Rayagonda Kokatanur, Simon Glass

Johan Gunnarsson <johan.gunnarsson@gmail.com> 于2021年7月26日周一 上午7:32写道：
>
> Currently there are a few arm32 rockchip board configs that don't
> generate u-boot-rockchip.bin when running make because CONFIG_BINMAN
> is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select
> CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64.
>
> Example builds that don't generate u-boot-rockchip.bin without this
> patch:
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make kylin-rk3036_defconfig
> make
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make rock_defconfig
> make
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make tinker-rk3288_defconfig
> make
>
> Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
>  arch/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 9de97cc101..5a8672cdd6 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1791,7 +1791,7 @@ config ARCH_STM32MP
>  config ARCH_ROCKCHIP
>         bool "Support Rockchip SoCs"
>         select BLK
> -       select BINMAN if SPL_OPTEE
> +       select BINMAN if SPL_OPTEE || (SPL && !ARM64)
>         select DM
>         select DM_GPIO
>         select DM_I2C
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: Fix u-boot-rockchip.bin build
  2021-07-25 14:25 [PATCH] rockchip: Fix u-boot-rockchip.bin build Johan Gunnarsson
  2021-07-26 14:07 ` Simon Glass
  2021-08-11  9:41 ` Kever Yang
@ 2021-08-11 10:18 ` Kever Yang
  2 siblings, 0 replies; 4+ messages in thread
From: Kever Yang @ 2021-08-11 10:18 UTC (permalink / raw)
  To: Johan Gunnarsson, u-boot
  Cc: Bharat Gooty, Philipp Tomsich, Rayagonda Kokatanur, Simon Glass


On 2021/7/25 下午10:25, Johan Gunnarsson wrote:
> Currently there are a few arm32 rockchip board configs that don't
> generate u-boot-rockchip.bin when running make because CONFIG_BINMAN
> is not enabled. This patch changes CONFIG_ARCH_ROCKCHIP to also select
> CONFIG_BINMAN if CONFIG_SPL and !CONFIG_ARM64.
>
> Example builds that don't generate u-boot-rockchip.bin without this
> patch:
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make kylin-rk3036_defconfig
> make
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make rock_defconfig
> make
>
> export ARCH=arm
> export CROSS_COMPILE=/usr/bin/arm-linux-gnueabihf-
> make tinker-rk3288_defconfig
> make
>
> Signed-off-by: Johan Gunnarsson <johan.gunnarsson@gmail.com>


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever

> ---
>
>   arch/arm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 9de97cc101..5a8672cdd6 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1791,7 +1791,7 @@ config ARCH_STM32MP
>   config ARCH_ROCKCHIP
>   	bool "Support Rockchip SoCs"
>   	select BLK
> -	select BINMAN if SPL_OPTEE
> +	select BINMAN if SPL_OPTEE || (SPL && !ARM64)
>   	select DM
>   	select DM_GPIO
>   	select DM_I2C



^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-11 10:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-25 14:25 [PATCH] rockchip: Fix u-boot-rockchip.bin build Johan Gunnarsson
2021-07-26 14:07 ` Simon Glass
2021-08-11  9:41 ` Kever Yang
2021-08-11 10:18 ` Kever Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).