u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH] bootstage: Add SPL support
@ 2021-09-14  3:19 Marek Vasut
  2021-09-18  9:30 ` Simon Glass
  2021-09-24 18:36 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2021-09-14  3:19 UTC (permalink / raw)
  To: u-boot; +Cc: Marek Vasut, Simon Glass

Allow usage of the bootstage facilities in SPL.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Simon Glass <sjg@chromium.org>
---
 common/Kconfig.boot | 9 +++++++++
 include/bootstage.h | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/common/Kconfig.boot b/common/Kconfig.boot
index 902a5b8fbea..c230b5c76e4 100644
--- a/common/Kconfig.boot
+++ b/common/Kconfig.boot
@@ -667,6 +667,15 @@ config SHOW_BOOT_PROGRESS
 	  -150	common/cmd_nand.c	Incorrect FIT image format
 	  151	common/cmd_nand.c	FIT image format OK
 
+config SPL_SHOW_BOOT_PROGRESS
+	bool "Show boot progress in a board-specific manner"
+	depends on SPL
+	help
+	  Defining this option allows to add some board-specific code (calling
+	  a user-provided function show_boot_progress(int) that enables you to
+	  show the system's boot progress on some display (for example, some
+	  LEDs) on your board. For details see SHOW_BOOT_PROGRESS.
+
 endmenu
 
 menu "Boot media"
diff --git a/include/bootstage.h b/include/bootstage.h
index f837a387c8c..8d1989ac0e5 100644
--- a/include/bootstage.h
+++ b/include/bootstage.h
@@ -220,7 +220,7 @@ enum bootstage_id {
  */
 ulong timer_get_boot_us(void);
 
-#if defined(USE_HOSTCC) || !CONFIG_IS_ENABLED(BOOTSTAGE)
+#if defined(USE_HOSTCC) || !CONFIG_IS_ENABLED(SHOW_BOOT_PROGRESS)
 #define show_boot_progress(val) do {} while (0)
 #else
 /**
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] bootstage: Add SPL support
  2021-09-14  3:19 [PATCH] bootstage: Add SPL support Marek Vasut
@ 2021-09-18  9:30 ` Simon Glass
  2021-09-24 18:36 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-09-18  9:30 UTC (permalink / raw)
  To: Marek Vasut; +Cc: u-boot

On Mon, 13 Sept 2021 at 21:19, Marek Vasut <marex@denx.de> wrote:
>
> Allow usage of the bootstage facilities in SPL.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  common/Kconfig.boot | 9 +++++++++
>  include/bootstage.h | 2 +-
>  2 files changed, 10 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bootstage: Add SPL support
  2021-09-14  3:19 [PATCH] bootstage: Add SPL support Marek Vasut
  2021-09-18  9:30 ` Simon Glass
@ 2021-09-24 18:36 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-09-24 18:36 UTC (permalink / raw)
  To: Marek Vasut; +Cc: u-boot, Simon Glass

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

On Tue, Sep 14, 2021 at 05:19:35AM +0200, Marek Vasut wrote:

> Allow usage of the bootstage facilities in SPL.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

This breaks a large number of platforms unfortunately, starting with
sandbox_spl but also cortina_presidio-asic-emmc and likely many others.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-24 18:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14  3:19 [PATCH] bootstage: Add SPL support Marek Vasut
2021-09-18  9:30 ` Simon Glass
2021-09-24 18:36 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).