u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Cc: Heiko Thiery <heiko.thiery@gmail.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fabio Estevam <festevam@gmail.com>,
	Stefano Babic <sbabic@denx.de>,
	Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Marek Vasut <marex@denx.de>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Rick Chen <rick@andestech.com>, Tero Kristo <kristo@kernel.org>,
	Wolfgang Denk <wd@denx.de>
Subject: [PATCH v6 09/11] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable
Date: Sat,  9 Oct 2021 22:41:11 +0200	[thread overview]
Message-ID: <20211009204113.1208641-10-marcel@ziswiler.com> (raw)
In-Reply-To: <20211009204113.1208641-1-marcel@ziswiler.com>

From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

Variable "kernel_image" is used in boot.scr script only, that sets its
own default value to the constant string @@KERNEL_IMAGETYPE@@ in case
"kernel_image" is not set.
The default name of the kernel image shipped with BSP 5.x is "Image.gz".
Setting kernel_image="Image" as a pre-defined u-boot variable
breaks booting systems with modern versions of boot.scr, whereas
renaming it fixes booting with modern scripts and does not break working
of earlier versions of boot.scr.

While at it also update the copyright period, rather than hard-coding
fdtfile default fdt_board to dev for the Verdin iMX8M Mini and fix its
closing #endif comment.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

---

Changes in v6:
- Update commit message as requested by Wolfgang.

Changes in v3:
- Fix patch.
- Add missing apalis-imx8 part.
- While at it update copyright year resp. period.
- Fix closing endif comment.

Changes in v2:
- New patch allows booting recent embedded Linux BSPs.

 include/configs/apalis-imx8.h   |  6 +++---
 include/configs/verdin-imx8mm.h | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
index 80594548877..ce5681499c9 100644
--- a/include/configs/apalis-imx8.h
+++ b/include/configs/apalis-imx8.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0+ */
 /*
- * Copyright 2019 Toradex
+ * Copyright 2019-2021 Toradex
  */
 
 #ifndef __APALIS_IMX8_H
@@ -42,12 +42,12 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	BOOTENV \
 	MEM_LAYOUT_ENV_SETTINGS \
+	"boot_file=Image\0" \
 	"console=ttyLP1 earlycon\0" \
 	"fdt_addr=0x83000000\0"	\
 	"fdt_file=fsl-imx8qm-apalis-eval.dtb\0" \
 	"fdtfile=fsl-imx8qm-apalis-eval.dtb\0" \
 	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
-	"image=Image\0" \
 	"initrd_addr=0x83800000\0" \
 	"initrd_high=0xffffffffffffffff\0" \
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
@@ -57,7 +57,7 @@
 	"netargs=setenv bootargs console=${console},${baudrate} " \
 		"root=/dev/nfs ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp" \
 		"\0" \
-	"nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp ${fdt_addr} " \
+	"nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; tftp ${fdt_addr} " \
 		"apalis-imx8/${fdt_file}; booti ${loadaddr} - ${fdt_addr}\0" \
 	"panel=NULL\0" \
 	"script=boot.scr\0" \
diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
index 50c808383db..693fd6907eb 100644
--- a/include/configs/verdin-imx8mm.h
+++ b/include/configs/verdin-imx8mm.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0+ */
 /*
- * Copyright 2020 Toradex
+ * Copyright 2020-2021 Toradex
  */
 
 #ifndef __VERDIN_IMX8MM_H
@@ -54,16 +54,16 @@
 	BOOTENV \
 	MEM_LAYOUT_ENV_SETTINGS \
 	"bootcmd_mfg=fastboot 0\0" \
+	"boot_file=Image\0" \
 	"console=ttymxc0\0" \
 	"fdt_addr=0x43000000\0" \
-	"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
+	"fdt_board=dev\0" \
 	"initrd_addr=0x43800000\0" \
 	"initrd_high=0xffffffffffffffff\0" \
-	"kernel_image=Image\0" \
 	"netargs=setenv bootargs console=${console},${baudrate} " \
 		"root=/dev/nfs ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp" \
 		"\0" \
-	"nfsboot=run netargs; dhcp ${loadaddr} ${kernel_image}; " \
+	"nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; " \
 		"tftp ${fdt_addr} verdin/${fdtfile}; " \
 		"booti ${loadaddr} - ${fdt_addr}\0" \
 	"setup=setenv setupargs console=${console},${baudrate} " \
@@ -118,4 +118,4 @@
 #define CONFIG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_USB_MAX_CONTROLLER_COUNT 2
 
-#endif /*_VERDIN_IMX8MM_H */
+#endif /* __VERDIN_IMX8MM_H */
-- 
2.26.2


  parent reply	other threads:[~2021-10-09 20:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 20:41 [PATCH v6 00/11] board: toradex: verdin-imx8mm: target refresh Marcel Ziswiler
2021-10-09 20:41 ` [PATCH v6 01/11] imx8m: clean-up kconfig indentation Marcel Ziswiler
2021-10-20 14:43   ` sbabic
2021-10-09 20:41 ` [PATCH v6 02/11] verdin-imx8mm: fix ethernet Marcel Ziswiler
2021-10-20 14:44   ` sbabic
2021-10-09 20:41 ` [PATCH v6 03/11] ARM: dts: imx8mm-verdin: prepare for dek blob encapsulation Marcel Ziswiler
2021-10-20 14:43   ` sbabic
2021-10-09 20:41 ` [PATCH v6 04/11] arm64: dts: imx8mm-verdin-u-boot.dtsi: alphabetically re-order Marcel Ziswiler
2021-10-20 14:43   ` sbabic
2021-10-09 20:41 ` [PATCH v6 05/11] verdin-imx8mm: switch to use binman to pack images Marcel Ziswiler
2021-10-20 14:43   ` sbabic
2021-10-09 20:41 ` [PATCH v6 06/11] verdin-imx8mm: enable sleep_moci output Marcel Ziswiler
2021-10-20 14:44   ` sbabic
2021-10-09 20:41 ` [PATCH v6 07/11] verdin-imx8mm: clean-up include order Marcel Ziswiler
2021-10-20 14:43   ` sbabic
2021-10-09 20:41 ` [PATCH v6 08/11] verdin-imx8mm: drop support for v1.0 hardware Marcel Ziswiler
2021-10-20 14:44   ` sbabic
2021-10-09 20:41 ` Marcel Ziswiler [this message]
2021-10-20 14:44   ` [PATCH v6 09/11] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable sbabic
2021-10-09 20:41 ` [PATCH v6 10/11] verdin-imx8mm: use preboot for fdtfile evaluation Marcel Ziswiler
2021-10-20 14:44   ` sbabic
2021-10-09 20:41 ` [PATCH v6 11/11] verdin-imx8mm: fix watchdog pinctrl issue Marcel Ziswiler
2021-10-20 14:43   ` sbabic
2021-10-12 19:46 ` [PATCH v6 00/11] board: toradex: verdin-imx8mm: target refresh Tim Harvey
2021-10-12 21:16   ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211009204113.1208641-10-marcel@ziswiler.com \
    --to=marcel@ziswiler.com \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=heiko.thiery@gmail.com \
    --cc=kristo@kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marex@denx.de \
    --cc=oleksandr.suvorov@toradex.com \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=rick@andestech.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).