From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Cc: Heiko Thiery <heiko.thiery@gmail.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Fabio Estevam <festevam@gmail.com>,
Stefano Babic <sbabic@denx.de>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
Subject: [PATCH v6 11/11] verdin-imx8mm: fix watchdog pinctrl issue
Date: Sat, 9 Oct 2021 22:41:13 +0200 [thread overview]
Message-ID: <20211009204113.1208641-12-marcel@ziswiler.com> (raw)
In-Reply-To: <20211009204113.1208641-1-marcel@ziswiler.com>
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Finally, found the root cause of the issue already once mentioned back
here [2] which caused the following error message during boot:
imx_wdt watchdog@30280000:
pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19
Turns out while the watchdog node itself was already u-boot,dm-spl its
pinctrl node was not which caused it to be unavailable at that early
stage. Note that any and all other boards I checked also seem to be
missing this. However, I can't judge whether or not they might indeed
need a similar fix or not.
[2] https://marc.info/?l=u-boot&m=161786572422973
Fixes: commit d304e7ace3a6
("ARM: imx8m: Fix reset in SPL on Toradex iMX8MM Verdin")
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
(no changes since v2)
Changes in v2:
- New patch fixing watchdog pinctrl issue.
arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
index 6a7e9d776c8..9fb4d8aa8c2 100644
--- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
+++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
@@ -76,6 +76,10 @@
u-boot,dm-spl;
};
+&pinctrl_wdog {
+ u-boot,dm-spl;
+};
+
&uart1 {
u-boot,dm-spl;
};
--
2.26.2
next prev parent reply other threads:[~2021-10-09 20:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 20:41 [PATCH v6 00/11] board: toradex: verdin-imx8mm: target refresh Marcel Ziswiler
2021-10-09 20:41 ` [PATCH v6 01/11] imx8m: clean-up kconfig indentation Marcel Ziswiler
2021-10-20 14:43 ` sbabic
2021-10-09 20:41 ` [PATCH v6 02/11] verdin-imx8mm: fix ethernet Marcel Ziswiler
2021-10-20 14:44 ` sbabic
2021-10-09 20:41 ` [PATCH v6 03/11] ARM: dts: imx8mm-verdin: prepare for dek blob encapsulation Marcel Ziswiler
2021-10-20 14:43 ` sbabic
2021-10-09 20:41 ` [PATCH v6 04/11] arm64: dts: imx8mm-verdin-u-boot.dtsi: alphabetically re-order Marcel Ziswiler
2021-10-20 14:43 ` sbabic
2021-10-09 20:41 ` [PATCH v6 05/11] verdin-imx8mm: switch to use binman to pack images Marcel Ziswiler
2021-10-20 14:43 ` sbabic
2021-10-09 20:41 ` [PATCH v6 06/11] verdin-imx8mm: enable sleep_moci output Marcel Ziswiler
2021-10-20 14:44 ` sbabic
2021-10-09 20:41 ` [PATCH v6 07/11] verdin-imx8mm: clean-up include order Marcel Ziswiler
2021-10-20 14:43 ` sbabic
2021-10-09 20:41 ` [PATCH v6 08/11] verdin-imx8mm: drop support for v1.0 hardware Marcel Ziswiler
2021-10-20 14:44 ` sbabic
2021-10-09 20:41 ` [PATCH v6 09/11] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable Marcel Ziswiler
2021-10-20 14:44 ` sbabic
2021-10-09 20:41 ` [PATCH v6 10/11] verdin-imx8mm: use preboot for fdtfile evaluation Marcel Ziswiler
2021-10-20 14:44 ` sbabic
2021-10-09 20:41 ` Marcel Ziswiler [this message]
2021-10-20 14:43 ` [PATCH v6 11/11] verdin-imx8mm: fix watchdog pinctrl issue sbabic
2021-10-12 19:46 ` [PATCH v6 00/11] board: toradex: verdin-imx8mm: target refresh Tim Harvey
2021-10-12 21:16 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211009204113.1208641-12-marcel@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=heiko.thiery@gmail.com \
--cc=marcel.ziswiler@toradex.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).