u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH] imx: nandbcb: Fix printf format in write_fcb
@ 2021-10-20  9:13 Pali Rohár
  2021-12-07 20:43 ` Pali Rohár
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Pali Rohár @ 2021-10-20  9:13 UTC (permalink / raw)
  To: Stefano Babic, Fabio Estevam; +Cc: NXP i.MX U-Boot Team, u-boot

Correct printf format for unsigned long long is %llx and not %llxx.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 arch/arm/mach-imx/cmd_nandbcb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/cmd_nandbcb.c b/arch/arm/mach-imx/cmd_nandbcb.c
index 09622c13c980..646da0198660 100644
--- a/arch/arm/mach-imx/cmd_nandbcb.c
+++ b/arch/arm/mach-imx/cmd_nandbcb.c
@@ -650,7 +650,7 @@ static int write_fcb(struct boot_config *boot_cfg, struct fcb_block *fcb)
 			};
 
 			ret = mtd_write_oob(mtd, off, &ops);
-			printf("NAND FCB write to 0x%llxx offset 0x%zx written: %s\n", off, ops.len, ret ? "ERROR" : "OK");
+			printf("NAND FCB write to 0x%llx offset 0x%zx written: %s\n", off, ops.len, ret ? "ERROR" : "OK");
 		}
 
 		if (ret)
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] imx: nandbcb: Fix printf format in write_fcb
  2021-10-20  9:13 [PATCH] imx: nandbcb: Fix printf format in write_fcb Pali Rohár
@ 2021-12-07 20:43 ` Pali Rohár
  2022-01-13 14:33   ` Pali Rohár
  2022-01-15 13:51 ` Fabio Estevam
  2022-02-05 16:40 ` sbabic
  2 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2021-12-07 20:43 UTC (permalink / raw)
  To: Stefano Babic, Fabio Estevam; +Cc: NXP i.MX U-Boot Team, u-boot

PING?

On Wednesday 20 October 2021 11:13:15 Pali Rohár wrote:
> Correct printf format for unsigned long long is %llx and not %llxx.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  arch/arm/mach-imx/cmd_nandbcb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/cmd_nandbcb.c b/arch/arm/mach-imx/cmd_nandbcb.c
> index 09622c13c980..646da0198660 100644
> --- a/arch/arm/mach-imx/cmd_nandbcb.c
> +++ b/arch/arm/mach-imx/cmd_nandbcb.c
> @@ -650,7 +650,7 @@ static int write_fcb(struct boot_config *boot_cfg, struct fcb_block *fcb)
>  			};
>  
>  			ret = mtd_write_oob(mtd, off, &ops);
> -			printf("NAND FCB write to 0x%llxx offset 0x%zx written: %s\n", off, ops.len, ret ? "ERROR" : "OK");
> +			printf("NAND FCB write to 0x%llx offset 0x%zx written: %s\n", off, ops.len, ret ? "ERROR" : "OK");
>  		}
>  
>  		if (ret)
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] imx: nandbcb: Fix printf format in write_fcb
  2021-12-07 20:43 ` Pali Rohár
@ 2022-01-13 14:33   ` Pali Rohár
  0 siblings, 0 replies; 5+ messages in thread
From: Pali Rohár @ 2022-01-13 14:33 UTC (permalink / raw)
  To: Stefano Babic, Fabio Estevam, Tom Rini; +Cc: NXP i.MX U-Boot Team, u-boot

Just friendly reminder for this patch...

On Tuesday 07 December 2021 21:43:09 Pali Rohár wrote:
> PING?
> 
> On Wednesday 20 October 2021 11:13:15 Pali Rohár wrote:
> > Correct printf format for unsigned long long is %llx and not %llxx.
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  arch/arm/mach-imx/cmd_nandbcb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-imx/cmd_nandbcb.c b/arch/arm/mach-imx/cmd_nandbcb.c
> > index 09622c13c980..646da0198660 100644
> > --- a/arch/arm/mach-imx/cmd_nandbcb.c
> > +++ b/arch/arm/mach-imx/cmd_nandbcb.c
> > @@ -650,7 +650,7 @@ static int write_fcb(struct boot_config *boot_cfg, struct fcb_block *fcb)
> >  			};
> >  
> >  			ret = mtd_write_oob(mtd, off, &ops);
> > -			printf("NAND FCB write to 0x%llxx offset 0x%zx written: %s\n", off, ops.len, ret ? "ERROR" : "OK");
> > +			printf("NAND FCB write to 0x%llx offset 0x%zx written: %s\n", off, ops.len, ret ? "ERROR" : "OK");
> >  		}
> >  
> >  		if (ret)
> > -- 
> > 2.20.1
> > 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] imx: nandbcb: Fix printf format in write_fcb
  2021-10-20  9:13 [PATCH] imx: nandbcb: Fix printf format in write_fcb Pali Rohár
  2021-12-07 20:43 ` Pali Rohár
@ 2022-01-15 13:51 ` Fabio Estevam
  2022-02-05 16:40 ` sbabic
  2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2022-01-15 13:51 UTC (permalink / raw)
  To: Pali Rohár; +Cc: Stefano Babic, NXP i.MX U-Boot Team, U-Boot-Denx

On Wed, Oct 20, 2021 at 6:13 AM Pali Rohár <pali@kernel.org> wrote:
>
> Correct printf format for unsigned long long is %llx and not %llxx.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] imx: nandbcb: Fix printf format in write_fcb
  2021-10-20  9:13 [PATCH] imx: nandbcb: Fix printf format in write_fcb Pali Rohár
  2021-12-07 20:43 ` Pali Rohár
  2022-01-15 13:51 ` Fabio Estevam
@ 2022-02-05 16:40 ` sbabic
  2 siblings, 0 replies; 5+ messages in thread
From: sbabic @ 2022-02-05 16:40 UTC (permalink / raw)
  To: Pali Rohár, u-boot

> Correct printf format for unsigned long long is %llx and not %llxx.
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-02-05 16:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20  9:13 [PATCH] imx: nandbcb: Fix printf format in write_fcb Pali Rohár
2021-12-07 20:43 ` Pali Rohár
2022-01-13 14:33   ` Pali Rohár
2022-01-15 13:51 ` Fabio Estevam
2022-02-05 16:40 ` sbabic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).