From: Tom Rini <trini@konsulko.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Joe Hershberger <joe.hershberger@ni.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Andre Przywara <andre.przywara@arm.com>,
Abbie Chang <abbie.chang@cortina-access.com>,
Bin Meng <bmeng.cn@gmail.com>,
Kuldeep Singh <kuldeep.singh@nxp.com>,
Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Michal Simek <michal.simek@xilinx.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
"Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>,
Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH] net: phy: realtek: Add tx/rx delay config for 8211e
Date: Thu, 4 Nov 2021 09:13:49 -0400 [thread overview]
Message-ID: <20211104131349.GK24579@bill-the-cat> (raw)
In-Reply-To: <20211013020733.52574-1-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On Tue, Oct 12, 2021 at 09:07:32PM -0500, Samuel Holland wrote:
> Some boards need to change the tx/rx delay config in order for
> gigabit Ethernet to work.
>
> In Linux commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> delay config"), Realtek documented the bits for overriding the delays
> from the hardware straps.
>
> Copy the logic from linux, so the delay config is set from the PHY's
> interface type (the phy-mode property in the device tree).
>
> This removes the need for a one-off workaround for the Pine A64+ board.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> This change is needed for the Allwinner D1 Nezha board, which has
> incorrect hardware straps.
OK, so this breaks my pine64+. It's the 1GB memory model from the
original Kickstarter with an 8211e on it. My dhcp just times out now,
with this applied. Let me know if there's some specifics you want me to
try for debug or talk to me off-list and I can try and setup access to
the board for you.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-04 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 2:07 [PATCH] net: phy: realtek: Add tx/rx delay config for 8211e Samuel Holland
2021-10-16 18:30 ` Ramon Fried
2021-10-28 18:48 ` Ramon Fried
2021-11-04 13:13 ` Tom Rini [this message]
2021-11-04 13:40 ` Andre Przywara
2021-11-04 13:42 ` Tom Rini
2021-11-10 16:31 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104131349.GK24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=abbie.chang@cortina-access.com \
--cc=andre.przywara@arm.com \
--cc=bmeng.cn@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=joe.hershberger@ni.com \
--cc=kuldeep.singh@nxp.com \
--cc=meenakshi.aggarwal@nxp.com \
--cc=michal.simek@xilinx.com \
--cc=priyanka.jain@nxp.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=rfried.dev@gmail.com \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).