Re: [PATCH] net: phy: realtek: Add tx/rx delay config for 8211e

From: Tom Rini <trini@konsulko.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Samuel Holland <samuel@sholland.org>,
	u-boot@lists.denx.de, Joe Hershberger <joe.hershberger@ni.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Abbie Chang <abbie.chang@cortina-access.com>,
	Bin Meng <bmeng.cn@gmail.com>,
	Kuldeep Singh <kuldeep.singh@nxp.com>,
	Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	"Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>,
	Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH] net: phy: realtek: Add tx/rx delay config for 8211e
Date: Thu, 4 Nov 2021 09:42:39 -0400	[thread overview]
Message-ID: <20211104134239.GL24579@bill-the-cat> (raw)
In-Reply-To: <20211104134042.74ab5dc9@donnerap.cambridge.arm.com>

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]

On Thu, Nov 04, 2021 at 01:40:42PM +0000, Andre Przywara wrote:
> On Thu, 4 Nov 2021 09:13:49 -0400
> Tom Rini <trini@konsulko.com> wrote:
> 
> Hi Tom,
> 
> > On Tue, Oct 12, 2021 at 09:07:32PM -0500, Samuel Holland wrote:
> > 
> > > Some boards need to change the tx/rx delay config in order for
> > > gigabit Ethernet to work.
> > > 
> > > In Linux commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> > > delay config"), Realtek documented the bits for overriding the delays
> > > from the hardware straps.
> > > 
> > > Copy the logic from linux, so the delay config is set from the PHY's
> > > interface type (the phy-mode property in the device tree).
> > > 
> > > This removes the need for a one-off workaround for the Pine A64+ board.
> > > 
> > > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > > ---
> > > This change is needed for the Allwinner D1 Nezha board, which has
> > > incorrect hardware straps.  
> > 
> > OK, so this breaks my pine64+.  It's the 1GB memory model from the
> > original Kickstarter with an 8211e on it.  My dhcp just times out now,
> > with this applied.  Let me know if there's some specifics you want me to
> > try for debug or talk to me off-list and I can try and setup access to
> > the board for you.
> 
> Many thanks for testing and the report. I will have a closer look tonight,
> I should have quite some boards to be able to reproduce it.

Ah good.  And yes, good news / bad news, this board is now in my
every-PR local CI HW loop :)

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]