* [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte
@ 2022-01-07 19:12 Henrik Grimler
2022-01-07 19:12 ` [PATCH 2/2] doc: board: avoid ambiguous names for axy17lte Henrik Grimler
2022-01-11 17:08 ` [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte Dzmitry Sankouski
0 siblings, 2 replies; 4+ messages in thread
From: Henrik Grimler @ 2022-01-07 19:12 UTC (permalink / raw)
To: mk7.kang, jh80.chung, sjg, dsankouski, u-boot; +Cc: Henrik Grimler
a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also
should select PINCTRL_EXYNOS78x0, not the (non-existent)
PINCTRL_EXYNOS7880, and it has an Exynos 7870 SoC and not 7880.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series
of 2017 (a5y17lte)")
Signed-off-by: Henrik Grimler <henrik@grimler.se>
---
arch/arm/mach-exynos/Kconfig | 6 +++---
board/samsung/axy17lte/Kconfig | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 7f3aee571290..32b81728c389 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -161,7 +161,7 @@ config TARGET_A5Y17LTE
select SUPPORT_SPL
config TARGET_A7Y17LTE
- bool "Samsung SM-A520F board"
+ bool "Samsung SM-A720F board"
select ARM64
select CLK_EXYNOS
select OF_CONTROL
@@ -170,12 +170,12 @@ config TARGET_A7Y17LTE
select SUPPORT_SPL
config TARGET_A3Y17LTE
- bool "Samsung SM-A520F board"
+ bool "Samsung SM-A320F board"
select ARM64
select CLK_EXYNOS
select OF_CONTROL
select PINCTRL
- select PINCTRL_EXYNOS7880
+ select PINCTRL_EXYNOS78x0
select SUPPORT_SPL
endchoice
diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig
index 2abf8e7acfca..a018547ff5d4 100644
--- a/board/samsung/axy17lte/Kconfig
+++ b/board/samsung/axy17lte/Kconfig
@@ -27,7 +27,7 @@ if TARGET_A7Y17LTE
config SYS_BOARD
default "axy17lte"
help
- a5y17lte is a production board for SM-A520F phone on Exynos7880 SoC.
+ a7y17lte is a production board for SM-A720F phone on Exynos7880 SoC.
config SYS_VENDOR
default "samsung"
@@ -44,7 +44,7 @@ if TARGET_A3Y17LTE
config SYS_BOARD
default "axy17lte"
help
- a3y17lte is a production board for SM-A520F phone on Exynos7880 SoC.
+ a3y17lte is a production board for SM-A320F phone on Exynos7870 SoC.
config SYS_VENDOR
default "samsung"
base-commit: a14af7216a220fe8f1b2a5308ed632abe6f9f97f
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] doc: board: avoid ambiguous names for axy17lte
2022-01-07 19:12 [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte Henrik Grimler
@ 2022-01-07 19:12 ` Henrik Grimler
2022-01-07 20:58 ` Dzmitry Sankouski
2022-01-11 17:08 ` [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte Dzmitry Sankouski
1 sibling, 1 reply; 4+ messages in thread
From: Henrik Grimler @ 2022-01-07 19:12 UTC (permalink / raw)
To: mk7.kang, jh80.chung, sjg, dsankouski, u-boot; +Cc: Henrik Grimler
Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to
SM-J{3,5,7}20 or SM-T{3,5,7}20.
Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series
of 2017 (a5y17lte)")
Signed-off-by: Henrik Grimler <henrik@grimler.se>
---
doc/board/samsung/axy17lte.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/board/samsung/axy17lte.rst b/doc/board/samsung/axy17lte.rst
index 511cd57a22f5..4307e51d8919 100644
--- a/doc/board/samsung/axy17lte.rst
+++ b/doc/board/samsung/axy17lte.rst
@@ -14,7 +14,7 @@ It is loaded as an Android boot image through SBOOT.
Phone specs
-----------
-A3 (SM-320) (a3y17lte)
+A3 (SM-A320) (a3y17lte)
^^^^^^^^^^^^^^^^^^^^^^
- 4.7 AMOLED display
- Exynos 7870 SoC
@@ -23,7 +23,7 @@ A3 (SM-320) (a3y17lte)
.. A3 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A3_(2017)
-A5 (SM-520) (a5y17lte)
+A5 (SM-A520) (a5y17lte)
^^^^^^^^^^^^^^^^^^^^^^
- 5.2 AMOLED display
- Exynos 7880 SoC
@@ -32,7 +32,7 @@ A5 (SM-520) (a5y17lte)
.. A5 2017 wiki page: https://en.wikipedia.org/wiki/Samsung_Galaxy_A5_(2017)
-A7 (SM-720) (a5y17lte)
+A7 (SM-A720) (a5y17lte)
^^^^^^^^^^^^^^^^^^^^^^
- 5.7 AMOLED display
- Exynos 7880 SoC
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] doc: board: avoid ambiguous names for axy17lte
2022-01-07 19:12 ` [PATCH 2/2] doc: board: avoid ambiguous names for axy17lte Henrik Grimler
@ 2022-01-07 20:58 ` Dzmitry Sankouski
0 siblings, 0 replies; 4+ messages in thread
From: Dzmitry Sankouski @ 2022-01-07 20:58 UTC (permalink / raw)
To: Henrik Grimler; +Cc: Minkyu Kang, jh80.chung, Simon Glass, U-Boot Mailing List
Reviewed-by: Dzmitry Sankouski <dsankouski@gmail.com>
пт, 7 сту 2022, 22:14 карыстальнік Henrik Grimler <henrik@grimler.se>
напісаў:
> Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to
> SM-J{3,5,7}20 or SM-T{3,5,7}20.
>
> Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series
> of 2017 (a5y17lte)")
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
> doc/board/samsung/axy17lte.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/doc/board/samsung/axy17lte.rst
> b/doc/board/samsung/axy17lte.rst
> index 511cd57a22f5..4307e51d8919 100644
> --- a/doc/board/samsung/axy17lte.rst
> +++ b/doc/board/samsung/axy17lte.rst
> @@ -14,7 +14,7 @@ It is loaded as an Android boot image through SBOOT.
>
> Phone specs
> -----------
> -A3 (SM-320) (a3y17lte)
> +A3 (SM-A320) (a3y17lte)
> ^^^^^^^^^^^^^^^^^^^^^^
> - 4.7 AMOLED display
> - Exynos 7870 SoC
> @@ -23,7 +23,7 @@ A3 (SM-320) (a3y17lte)
>
> .. A3 2017 wiki page:
> https://en.wikipedia.org/wiki/Samsung_Galaxy_A3_(2017)
>
> -A5 (SM-520) (a5y17lte)
> +A5 (SM-A520) (a5y17lte)
> ^^^^^^^^^^^^^^^^^^^^^^
> - 5.2 AMOLED display
> - Exynos 7880 SoC
> @@ -32,7 +32,7 @@ A5 (SM-520) (a5y17lte)
>
> .. A5 2017 wiki page:
> https://en.wikipedia.org/wiki/Samsung_Galaxy_A5_(2017)
>
> -A7 (SM-720) (a5y17lte)
> +A7 (SM-A720) (a5y17lte)
> ^^^^^^^^^^^^^^^^^^^^^^
> - 5.7 AMOLED display
> - Exynos 7880 SoC
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte
2022-01-07 19:12 [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte Henrik Grimler
2022-01-07 19:12 ` [PATCH 2/2] doc: board: avoid ambiguous names for axy17lte Henrik Grimler
@ 2022-01-11 17:08 ` Dzmitry Sankouski
1 sibling, 0 replies; 4+ messages in thread
From: Dzmitry Sankouski @ 2022-01-11 17:08 UTC (permalink / raw)
To: Henrik Grimler; +Cc: Minkyu Kang, jh80.chung, Simon Glass, U-Boot Mailing List
Reviewed-by: Dzmitry Sankouski <dsankouski@gmail.com>
пт, 7 янв. 2022 г. в 22:14, Henrik Grimler <henrik@grimler.se>:
> a7y17lte is called SM-A720F, and a3y17lte SM-A320F. a3y17lte also
> should select PINCTRL_EXYNOS78x0, not the (non-existent)
> PINCTRL_EXYNOS7880, and it has an Exynos 7870 SoC and not 7880.
>
> Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series
> of 2017 (a5y17lte)")
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
> arch/arm/mach-exynos/Kconfig | 6 +++---
> board/samsung/axy17lte/Kconfig | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 7f3aee571290..32b81728c389 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -161,7 +161,7 @@ config TARGET_A5Y17LTE
> select SUPPORT_SPL
>
> config TARGET_A7Y17LTE
> - bool "Samsung SM-A520F board"
> + bool "Samsung SM-A720F board"
> select ARM64
> select CLK_EXYNOS
> select OF_CONTROL
> @@ -170,12 +170,12 @@ config TARGET_A7Y17LTE
> select SUPPORT_SPL
>
> config TARGET_A3Y17LTE
> - bool "Samsung SM-A520F board"
> + bool "Samsung SM-A320F board"
> select ARM64
> select CLK_EXYNOS
> select OF_CONTROL
> select PINCTRL
> - select PINCTRL_EXYNOS7880
> + select PINCTRL_EXYNOS78x0
> select SUPPORT_SPL
>
> endchoice
> diff --git a/board/samsung/axy17lte/Kconfig
> b/board/samsung/axy17lte/Kconfig
> index 2abf8e7acfca..a018547ff5d4 100644
> --- a/board/samsung/axy17lte/Kconfig
> +++ b/board/samsung/axy17lte/Kconfig
> @@ -27,7 +27,7 @@ if TARGET_A7Y17LTE
> config SYS_BOARD
> default "axy17lte"
> help
> - a5y17lte is a production board for SM-A520F phone on Exynos7880
> SoC.
> + a7y17lte is a production board for SM-A720F phone on Exynos7880
> SoC.
>
> config SYS_VENDOR
> default "samsung"
> @@ -44,7 +44,7 @@ if TARGET_A3Y17LTE
> config SYS_BOARD
> default "axy17lte"
> help
> - a3y17lte is a production board for SM-A520F phone on Exynos7880
> SoC.
> + a3y17lte is a production board for SM-A320F phone on Exynos7870
> SoC.
>
> config SYS_VENDOR
> default "samsung"
>
> base-commit: a14af7216a220fe8f1b2a5308ed632abe6f9f97f
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-11 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07 19:12 [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte Henrik Grimler
2022-01-07 19:12 ` [PATCH 2/2] doc: board: avoid ambiguous names for axy17lte Henrik Grimler
2022-01-07 20:58 ` Dzmitry Sankouski
2022-01-11 17:08 ` [PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte Dzmitry Sankouski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).