* [PATCH v2] imx8mm_beacon: Switch to binman for generating image
@ 2021-10-22 21:43 Marcel Ziswiler
2021-10-24 19:54 ` Simon Glass
2022-01-08 2:08 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Marcel Ziswiler @ 2021-10-22 21:43 UTC (permalink / raw)
To: u-boot
Cc: Adam Ford, Marcel Ziswiler, Fabio Estevam, Heiko Schocher,
Heiko Thiery, Ilko Iliev, Jaehoon Chung, Jagan Teki,
NXP i.MX U-Boot Team, Peng Fan, Rick Chen, Simon Glass,
Stefano Babic, Teresa Remmet
From: Adam Ford <aford173@gmail.com>
To eliminate a warning when using custom imx tools for generating
a binary, use binman to generate flash.bin.
Signed-off-by: Adam Ford <aford173@gmail.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
Note that this re-base is only compile tested.
Changes in v2:
- Re-based on top of imx/master.
arch/arm/dts/imx8mm-beacon-kit-u-boot.dtsi | 122 ++++++++++++++++++++
arch/arm/mach-imx/imx8m/Kconfig | 1 +
board/beacon/imx8mm/Kconfig | 2 +-
board/beacon/imx8mm/README | 6 +-
board/beacon/imx8mm/imximage-8mm-lpddr4.cfg | 9 ++
configs/imx8mm_beacon_defconfig | 2 +-
6 files changed, 137 insertions(+), 5 deletions(-)
create mode 100644 board/beacon/imx8mm/imximage-8mm-lpddr4.cfg
diff --git a/arch/arm/dts/imx8mm-beacon-kit-u-boot.dtsi b/arch/arm/dts/imx8mm-beacon-kit-u-boot.dtsi
index 73ddfdade6a..3c034a85e35 100644
--- a/arch/arm/dts/imx8mm-beacon-kit-u-boot.dtsi
+++ b/arch/arm/dts/imx8mm-beacon-kit-u-boot.dtsi
@@ -6,6 +6,10 @@
#include "imx8mm-u-boot.dtsi"
/ {
+ binman: binman {
+ multiple-images;
+ };
+
wdt-reboot {
compatible = "wdt-reboot";
wdt = <&wdog1>;
@@ -100,3 +104,121 @@
&wdog1 {
u-boot,dm-spl;
};
+
+&binman {
+ u-boot-spl-ddr {
+ filename = "u-boot-spl-ddr.bin";
+ pad-byte = <0xff>;
+ align-size = <4>;
+ align = <4>;
+
+ u-boot-spl {
+ align-end = <4>;
+ };
+
+ blob_1: blob-ext@1 {
+ filename = "lpddr4_pmu_train_1d_imem.bin";
+ size = <0x8000>;
+ };
+
+ blob_2: blob-ext@2 {
+ filename = "lpddr4_pmu_train_1d_dmem.bin";
+ size = <0x4000>;
+ };
+
+ blob_3: blob-ext@3 {
+ filename = "lpddr4_pmu_train_2d_imem.bin";
+ size = <0x8000>;
+ };
+
+ blob_4: blob-ext@4 {
+ filename = "lpddr4_pmu_train_2d_dmem.bin";
+ size = <0x4000>;
+ };
+ };
+
+ spl {
+ filename = "spl.bin";
+
+ mkimage {
+ args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
+
+ blob {
+ filename = "u-boot-spl-ddr.bin";
+ };
+ };
+ };
+
+ itb {
+ filename = "u-boot.itb";
+
+ fit {
+ description = "Configuration to load ATF before U-Boot";
+ #address-cells = <1>;
+ fit,external-offset = <CONFIG_FIT_EXTERNAL_OFFSET>;
+
+ images {
+ uboot {
+ description = "U-Boot (64-bit)";
+ type = "standalone";
+ arch = "arm64";
+ compression = "none";
+ load = <CONFIG_SYS_TEXT_BASE>;
+
+ uboot_blob: blob-ext {
+ filename = "u-boot-nodtb.bin";
+ };
+ };
+
+ atf {
+ description = "ARM Trusted Firmware";
+ type = "firmware";
+ arch = "arm64";
+ compression = "none";
+ load = <0x920000>;
+ entry = <0x920000>;
+
+ atf_blob: blob-ext {
+ filename = "bl31.bin";
+ };
+ };
+
+ fdt {
+ description = "NAME";
+ type = "flat_dt";
+ compression = "none";
+
+ uboot_fdt_blob: blob-ext {
+ filename = "u-boot.dtb";
+ };
+ };
+ };
+
+ configurations {
+ default = "conf";
+
+ conf {
+ description = "NAME";
+ firmware = "uboot";
+ loadables = "atf";
+ fdt = "fdt";
+ };
+ };
+ };
+ };
+
+ imx-boot {
+ filename = "flash.bin";
+ pad-byte = <0x00>;
+
+ spl: blob-ext@1 {
+ offset = <0x0>;
+ filename = "spl.bin";
+ };
+
+ uboot: blob-ext@2 {
+ offset = <0x57c00>;
+ filename = "u-boot.itb";
+ };
+ };
+};
diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
index 276b8bd9742..a2822f8c28f 100644
--- a/arch/arm/mach-imx/imx8m/Kconfig
+++ b/arch/arm/mach-imx/imx8m/Kconfig
@@ -117,6 +117,7 @@ config TARGET_VERDIN_IMX8MM
config TARGET_IMX8MM_BEACON
bool "imx8mm Beacon Embedded devkit"
+ select BINMAN
select IMX8MM
select SUPPORT_SPL
select IMX8M_LPDDR4
diff --git a/board/beacon/imx8mm/Kconfig b/board/beacon/imx8mm/Kconfig
index 58799c1a655..63f064e8cb8 100644
--- a/board/beacon/imx8mm/Kconfig
+++ b/board/beacon/imx8mm/Kconfig
@@ -10,7 +10,7 @@ config SYS_CONFIG_NAME
default "imx8mm_beacon"
config IMX_CONFIG
- default "arch/arm/mach-imx/imx8m/imximage-8mm-lpddr4.cfg"
+ default "board/beacon/imx8mm/imximage-8mm-lpddr4.cfg"
source "board/freescale/common/Kconfig"
diff --git a/board/beacon/imx8mm/README b/board/beacon/imx8mm/README
index dce176fa0b2..03d9412f0d6 100644
--- a/board/beacon/imx8mm/README
+++ b/board/beacon/imx8mm/README
@@ -12,8 +12,8 @@ Get and Build the ARM Trusted firmware
Note: $(srctree) is U-Boot source directory
$ git clone https://source.codeaurora.org/external/imx/imx-atf
-$ git checkout imx_4.19.35_1.0.0
-$ make PLAT=imx8mm bl31 ARCH=arm CROSS_COMPILE=aarch64-linux-gnu-
+$ git checkout imx_5.4.70_2.3.0
+$ make PLAT=imx8mm bl31 CROSS_COMPILE=aarch64-linux-gnu-
$ cp build/imx8mm/release/bl31.bin $(srctree)
Get the DDR firmware
@@ -26,7 +26,7 @@ $ cp firmware-imx-8.5/firmware/ddr/synopsys/lpddr4*.bin $(srctree)
Build U-Boot
============
$ make imx8mm_beacon_defconfig
-$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu- ATF_LOAD_ADDR=0x920000
+$ make flash.bin CROSS_COMPILE=aarch64-linux-gnu-
Burn U-Boot to microSD Card
===========================
diff --git a/board/beacon/imx8mm/imximage-8mm-lpddr4.cfg b/board/beacon/imx8mm/imximage-8mm-lpddr4.cfg
new file mode 100644
index 00000000000..90573be5fd9
--- /dev/null
+++ b/board/beacon/imx8mm/imximage-8mm-lpddr4.cfg
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2021 NXP
+ */
+
+#define __ASSEMBLY__
+
+BOOT_FROM sd
+LOADER u-boot-spl-ddr.bin 0x7E1000
diff --git a/configs/imx8mm_beacon_defconfig b/configs/imx8mm_beacon_defconfig
index 02cdeda23e5..9d6af69ba15 100644
--- a/configs/imx8mm_beacon_defconfig
+++ b/configs/imx8mm_beacon_defconfig
@@ -21,7 +21,7 @@ CONFIG_SYS_LOAD_ADDR=0x40480000
CONFIG_FIT=y
CONFIG_FIT_EXTERNAL_OFFSET=0x3000
CONFIG_SPL_LOAD_FIT=y
-CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh"
+# CONFIG_USE_SPL_FIT_GENERATOR is not set
CONFIG_OF_SYSTEM_SETUP=y
CONFIG_DEFAULT_FDT_FILE="imx8mm-beacon-kit.dtb"
CONFIG_SPL_BOARD_INIT=y
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] imx8mm_beacon: Switch to binman for generating image
2021-10-22 21:43 [PATCH v2] imx8mm_beacon: Switch to binman for generating image Marcel Ziswiler
@ 2021-10-24 19:54 ` Simon Glass
2022-01-08 2:08 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-10-24 19:54 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: U-Boot Mailing List, Adam Ford, Marcel Ziswiler, Fabio Estevam,
Heiko Schocher, Heiko Thiery, Ilko Iliev, Jaehoon Chung,
Jagan Teki, NXP i.MX U-Boot Team, Peng Fan, Rick Chen,
Stefano Babic, Teresa Remmet
On Fri, 22 Oct 2021 at 15:49, Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Adam Ford <aford173@gmail.com>
>
> To eliminate a warning when using custom imx tools for generating
> a binary, use binman to generate flash.bin.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
> Note that this re-base is only compile tested.
>
> Changes in v2:
> - Re-based on top of imx/master.
>
> arch/arm/dts/imx8mm-beacon-kit-u-boot.dtsi | 122 ++++++++++++++++++++
> arch/arm/mach-imx/imx8m/Kconfig | 1 +
> board/beacon/imx8mm/Kconfig | 2 +-
> board/beacon/imx8mm/README | 6 +-
> board/beacon/imx8mm/imximage-8mm-lpddr4.cfg | 9 ++
> configs/imx8mm_beacon_defconfig | 2 +-
> 6 files changed, 137 insertions(+), 5 deletions(-)
> create mode 100644 board/beacon/imx8mm/imximage-8mm-lpddr4.cfg
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] imx8mm_beacon: Switch to binman for generating image
2021-10-22 21:43 [PATCH v2] imx8mm_beacon: Switch to binman for generating image Marcel Ziswiler
2021-10-24 19:54 ` Simon Glass
@ 2022-01-08 2:08 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-01-08 2:08 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: u-boot, Adam Ford, Marcel Ziswiler, Fabio Estevam,
Heiko Schocher, Heiko Thiery, Ilko Iliev, Jaehoon Chung,
Jagan Teki, NXP i.MX U-Boot Team, Peng Fan, Rick Chen,
Simon Glass, Stefano Babic, Teresa Remmet
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On Fri, Oct 22, 2021 at 11:43:40PM +0200, Marcel Ziswiler wrote:
> From: Adam Ford <aford173@gmail.com>
>
> To eliminate a warning when using custom imx tools for generating
> a binary, use binman to generate flash.bin.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-08 2:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 21:43 [PATCH v2] imx8mm_beacon: Switch to binman for generating image Marcel Ziswiler
2021-10-24 19:54 ` Simon Glass
2022-01-08 2:08 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).