[PATCH] arm: dts: mt7622: remove default pinctrl of uart0

[PATCH] arm: dts: mt7622: remove default pinctrl of uart0

[Weijie Gao]

Currently u-boot running on mt7622 will print an warning log at beginning:
> serial_mtk serial@11002000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19

It turns out that the pinctrl uclass can't work properly in board_f stage.

Since the uart0 is the default UART device used by bootrom, and will be
initialized in both bootrom and tf-a bl2. It's ok not to setup pinctrl for
uart0 in u-boot.

This patch removes the default pinctrl of uart0 to suppress the unwanted
warning.

Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
---
 arch/arm/dts/mt7622-bananapi-bpi-r64.dts | 2 --
 arch/arm/dts/mt7622-rfb.dts              | 2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/arm/dts/mt7622-bananapi-bpi-r64.dts b/arch/arm/dts/mt7622-bananapi-bpi-r64.dts
index 4f2f04851d..2ac933a6ac 100644
--- a/arch/arm/dts/mt7622-bananapi-bpi-r64.dts
+++ b/arch/arm/dts/mt7622-bananapi-bpi-r64.dts
@@ -182,8 +182,6 @@
 };
 
 &uart0 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&uart0_pins>;
 	status = "okay";
 };
 
diff --git a/arch/arm/dts/mt7622-rfb.dts b/arch/arm/dts/mt7622-rfb.dts
index c2f1ad2011..30a9137407 100644
--- a/arch/arm/dts/mt7622-rfb.dts
+++ b/arch/arm/dts/mt7622-rfb.dts
@@ -189,8 +189,6 @@
 };
 
 &uart0 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&uart0_pins>;
 	status = "okay";
 };
 
-- 
2.17.1

Re: [PATCH] arm: dts: mt7622: remove default pinctrl of uart0

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

On Wed, Jul 13, 2022 at 11:16:39AM +0800, Weijie Gao wrote:

> Currently u-boot running on mt7622 will print an warning log at beginning:
> > serial_mtk serial@11002000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19
> 
> It turns out that the pinctrl uclass can't work properly in board_f stage.
> 
> Since the uart0 is the default UART device used by bootrom, and will be
> initialized in both bootrom and tf-a bl2. It's ok not to setup pinctrl for
> uart0 in u-boot.
> 
> This patch removes the default pinctrl of uart0 to suppress the unwanted
> warning.
> 
> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]