* [PATCH] rockchip: rk3308: fix rockchip_dnl_key_pressed() on roc-cc
@ 2022-07-14 14:09 John Keeping
2022-08-27 3:23 ` Kever Yang
0 siblings, 1 reply; 2+ messages in thread
From: John Keeping @ 2022-07-14 14:09 UTC (permalink / raw)
To: Andy Yan; +Cc: u-boot, John Keeping
Commit 6aa4fe3912 ("dm: core: Rename and fix uclass_get_by_name_len()")
changed uclass_get_device_by_name() to an exact match when previously it
behaved as a prefix match.
The roc-cc code relied on this prefix match by only specifying part of
the device name. Fix this by using the full name including the address.
Signed-off-by: John Keeping <john@metanate.com>
---
board/firefly/firefly-rk3308/roc_cc_rk3308.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/firefly/firefly-rk3308/roc_cc_rk3308.c b/board/firefly/firefly-rk3308/roc_cc_rk3308.c
index 28dcc2a690..bdf3cc03dc 100644
--- a/board/firefly/firefly-rk3308/roc_cc_rk3308.c
+++ b/board/firefly/firefly-rk3308/roc_cc_rk3308.c
@@ -70,7 +70,7 @@ int rockchip_dnl_key_pressed(void)
{
unsigned int val;
- if (adc_channel_single_shot("saradc", 1, &val)) {
+ if (adc_channel_single_shot("saradc@ff1e0000", 1, &val)) {
printf("%s read adc key val failed\n", __func__);
return false;
}
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rockchip: rk3308: fix rockchip_dnl_key_pressed() on roc-cc
2022-07-14 14:09 [PATCH] rockchip: rk3308: fix rockchip_dnl_key_pressed() on roc-cc John Keeping
@ 2022-08-27 3:23 ` Kever Yang
0 siblings, 0 replies; 2+ messages in thread
From: Kever Yang @ 2022-08-27 3:23 UTC (permalink / raw)
To: John Keeping, Andy Yan; +Cc: u-boot
On 2022/7/14 22:09, John Keeping wrote:
> Commit 6aa4fe3912 ("dm: core: Rename and fix uclass_get_by_name_len()")
> changed uclass_get_device_by_name() to an exact match when previously it
> behaved as a prefix match.
>
> The roc-cc code relied on this prefix match by only specifying part of
> the device name. Fix this by using the full name including the address.
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> board/firefly/firefly-rk3308/roc_cc_rk3308.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/firefly/firefly-rk3308/roc_cc_rk3308.c b/board/firefly/firefly-rk3308/roc_cc_rk3308.c
> index 28dcc2a690..bdf3cc03dc 100644
> --- a/board/firefly/firefly-rk3308/roc_cc_rk3308.c
> +++ b/board/firefly/firefly-rk3308/roc_cc_rk3308.c
> @@ -70,7 +70,7 @@ int rockchip_dnl_key_pressed(void)
> {
> unsigned int val;
>
> - if (adc_channel_single_shot("saradc", 1, &val)) {
> + if (adc_channel_single_shot("saradc@ff1e0000", 1, &val)) {
> printf("%s read adc key val failed\n", __func__);
> return false;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-27 3:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 14:09 [PATCH] rockchip: rk3308: fix rockchip_dnl_key_pressed() on roc-cc John Keeping
2022-08-27 3:23 ` Kever Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).