u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias
@ 2022-07-15  8:16 Pali Rohár
  2022-07-15  8:37 ` Marek Behún
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Pali Rohár @ 2022-07-15  8:16 UTC (permalink / raw)
  To: Marek Behún, Stefan Roese; +Cc: u-boot

CONFIG_ETHPRIME can be set to DT node name or alias which refers to DT
node. Define ethernet aliases and set ETHPRIME to eth2 which refers to WAN
ethernet port. This removes hardcoded DT node name from U-Boot
configuration file.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 arch/arm/dts/armada-385-turris-omnia.dts | 6 ++++++
 configs/turris_omnia_defconfig           | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/armada-385-turris-omnia.dts b/arch/arm/dts/armada-385-turris-omnia.dts
index 5511c84849ee..7f1478edfd23 100644
--- a/arch/arm/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/dts/armada-385-turris-omnia.dts
@@ -55,6 +55,12 @@
 		stdout-path = &uart0;
 	};
 
+	aliases {
+		ethernet0 = &eth0;
+		ethernet1 = &eth1;
+		ethernet2 = &eth2;
+	};
+
 	memory {
 		device_type = "memory";
 		reg = <0x00000000 0x40000000>; /* 1024 MB */
diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index 6460535ef94e..e2a0449b487b 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -65,7 +65,7 @@ CONFIG_CMD_FS_UUID=y
 CONFIG_ENV_OVERWRITE=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_USE_ETHPRIME=y
-CONFIG_ETHPRIME="ethernet@34000"
+CONFIG_ETHPRIME="eth2"
 CONFIG_ARP_TIMEOUT=200
 CONFIG_NET_RETRY_COUNT=50
 CONFIG_NETCONSOLE=y
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias
  2022-07-15  8:16 [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias Pali Rohár
@ 2022-07-15  8:37 ` Marek Behún
  2022-07-15  8:40   ` Pali Rohár
  2022-07-18 10:29 ` Stefan Roese
  2022-07-21 12:28 ` Stefan Roese
  2 siblings, 1 reply; 5+ messages in thread
From: Marek Behún @ 2022-07-15  8:37 UTC (permalink / raw)
  To: Pali Rohár; +Cc: Stefan Roese, u-boot

On Fri, 15 Jul 2022 10:16:00 +0200
Pali Rohár <pali@kernel.org> wrote:

> CONFIG_ETHPRIME can be set to DT node name or alias which refers to DT
> node. Define ethernet aliases and set ETHPRIME to eth2 which refers to WAN
> ethernet port. This removes hardcoded DT node name from U-Boot
> configuration file.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Oh yeah. Do we want to send this dt change also to Linux?

Reviewed-by: Marek Behún <kabel@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias
  2022-07-15  8:37 ` Marek Behún
@ 2022-07-15  8:40   ` Pali Rohár
  0 siblings, 0 replies; 5+ messages in thread
From: Pali Rohár @ 2022-07-15  8:40 UTC (permalink / raw)
  To: Marek Behún; +Cc: Stefan Roese, u-boot

On Friday 15 July 2022 10:37:13 Marek Behún wrote:
> On Fri, 15 Jul 2022 10:16:00 +0200
> Pali Rohár <pali@kernel.org> wrote:
> 
> > CONFIG_ETHPRIME can be set to DT node name or alias which refers to DT
> > node. Define ethernet aliases and set ETHPRIME to eth2 which refers to WAN
> > ethernet port. This removes hardcoded DT node name from U-Boot
> > configuration file.
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> 
> Oh yeah. Do we want to send this dt change also to Linux?

Rather synchronize Omnia/A385 DTS files between U-Boot and Linux.

> Reviewed-by: Marek Behún <kabel@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias
  2022-07-15  8:16 [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias Pali Rohár
  2022-07-15  8:37 ` Marek Behún
@ 2022-07-18 10:29 ` Stefan Roese
  2022-07-21 12:28 ` Stefan Roese
  2 siblings, 0 replies; 5+ messages in thread
From: Stefan Roese @ 2022-07-18 10:29 UTC (permalink / raw)
  To: Pali Rohár, Marek Behún; +Cc: u-boot

On 15.07.22 10:16, Pali Rohár wrote:
> CONFIG_ETHPRIME can be set to DT node name or alias which refers to DT
> node. Define ethernet aliases and set ETHPRIME to eth2 which refers to WAN
> ethernet port. This removes hardcoded DT node name from U-Boot
> configuration file.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/dts/armada-385-turris-omnia.dts | 6 ++++++
>   configs/turris_omnia_defconfig           | 2 +-
>   2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/armada-385-turris-omnia.dts b/arch/arm/dts/armada-385-turris-omnia.dts
> index 5511c84849ee..7f1478edfd23 100644
> --- a/arch/arm/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/dts/armada-385-turris-omnia.dts
> @@ -55,6 +55,12 @@
>   		stdout-path = &uart0;
>   	};
>   
> +	aliases {
> +		ethernet0 = &eth0;
> +		ethernet1 = &eth1;
> +		ethernet2 = &eth2;
> +	};
> +
>   	memory {
>   		device_type = "memory";
>   		reg = <0x00000000 0x40000000>; /* 1024 MB */
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 6460535ef94e..e2a0449b487b 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -65,7 +65,7 @@ CONFIG_CMD_FS_UUID=y
>   CONFIG_ENV_OVERWRITE=y
>   CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_USE_ETHPRIME=y
> -CONFIG_ETHPRIME="ethernet@34000"
> +CONFIG_ETHPRIME="eth2"
>   CONFIG_ARP_TIMEOUT=200
>   CONFIG_NET_RETRY_COUNT=50
>   CONFIG_NETCONSOLE=y

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias
  2022-07-15  8:16 [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias Pali Rohár
  2022-07-15  8:37 ` Marek Behún
  2022-07-18 10:29 ` Stefan Roese
@ 2022-07-21 12:28 ` Stefan Roese
  2 siblings, 0 replies; 5+ messages in thread
From: Stefan Roese @ 2022-07-21 12:28 UTC (permalink / raw)
  To: Pali Rohár, Marek Behún; +Cc: u-boot

On 15.07.22 10:16, Pali Rohár wrote:
> CONFIG_ETHPRIME can be set to DT node name or alias which refers to DT
> node. Define ethernet aliases and set ETHPRIME to eth2 which refers to WAN
> ethernet port. This removes hardcoded DT node name from U-Boot
> configuration file.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
>   arch/arm/dts/armada-385-turris-omnia.dts | 6 ++++++
>   configs/turris_omnia_defconfig           | 2 +-
>   2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/armada-385-turris-omnia.dts b/arch/arm/dts/armada-385-turris-omnia.dts
> index 5511c84849ee..7f1478edfd23 100644
> --- a/arch/arm/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/dts/armada-385-turris-omnia.dts
> @@ -55,6 +55,12 @@
>   		stdout-path = &uart0;
>   	};
>   
> +	aliases {
> +		ethernet0 = &eth0;
> +		ethernet1 = &eth1;
> +		ethernet2 = &eth2;
> +	};
> +
>   	memory {
>   		device_type = "memory";
>   		reg = <0x00000000 0x40000000>; /* 1024 MB */
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 6460535ef94e..e2a0449b487b 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -65,7 +65,7 @@ CONFIG_CMD_FS_UUID=y
>   CONFIG_ENV_OVERWRITE=y
>   CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_USE_ETHPRIME=y
> -CONFIG_ETHPRIME="ethernet@34000"
> +CONFIG_ETHPRIME="eth2"
>   CONFIG_ARP_TIMEOUT=200
>   CONFIG_NET_RETRY_COUNT=50
>   CONFIG_NETCONSOLE=y

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-21 12:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15  8:16 [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias Pali Rohár
2022-07-15  8:37 ` Marek Behún
2022-07-15  8:40   ` Pali Rohár
2022-07-18 10:29 ` Stefan Roese
2022-07-21 12:28 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).