From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH 2/3] net: sun8i-emac: Drop use of arch-specific header
Date: Mon, 18 Jul 2022 11:03:07 +0100 [thread overview]
Message-ID: <20220718110307.2ffef1b1@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20220715052058.28405-3-samuel@sholland.org>
On Fri, 15 Jul 2022 00:20:57 -0500
Samuel Holland <samuel@sholland.org> wrote:
Hi,
> This header is not used since commit abdbefba2a4e ("net: sun8i_emac: Use
> consistent clock bitfield definitions"). Dropping it allows the driver
> to be architecture-independent.
Yes, we don't need this header anymore (all boards compile fine without
it), and indeed it seems to be this commit you mentioned that changed that.
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> drivers/net/sun8i_emac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
> index a4b3492b7647..9cca8fa4e0a1 100644
> --- a/drivers/net/sun8i_emac.c
> +++ b/drivers/net/sun8i_emac.c
> @@ -16,7 +16,6 @@
> #include <asm/global_data.h>
> #include <asm/gpio.h>
> #include <asm/io.h>
> -#include <asm/arch/clock.h>
> #include <common.h>
> #include <clk.h>
> #include <dm.h>
next prev parent reply other threads:[~2022-07-18 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 5:20 [PATCH 0/3] net: sun8i-emac: Allwinner D1 Support Samuel Holland
2022-07-15 5:20 ` [PATCH 1/3] net: sun8i-emac: Downgrade printf during probe to debug Samuel Holland
2022-07-16 17:00 ` Andre Przywara
2022-08-06 17:38 ` Ramon Fried
2022-07-15 5:20 ` [PATCH 2/3] net: sun8i-emac: Drop use of arch-specific header Samuel Holland
2022-07-18 10:03 ` Andre Przywara [this message]
2022-08-06 17:39 ` Ramon Fried
2022-07-15 5:20 ` [PATCH 3/3] net: sun8i-emac: Use common syscon setup for R40 Samuel Holland
2022-07-15 9:24 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718110307.2ffef1b1@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).