Re: [PATCH 1/3] net: sun8i-emac: Downgrade printf during probe to debug

[Ramon Fried <rfried.dev@gmail.com>]

On Sat, Jul 16, 2022 at 8:02 PM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Fri, 15 Jul 2022 00:20:56 -0500
> Samuel Holland <samuel@sholland.org> wrote:
>
> > This just prints the PHY mode taken from the devicetree. It does not
> > need to be printed during every boot.
>
> That's true, but I think a more important reason is that it spoils the
> output, doesn't it? It reads:
> Net:   phy interface9
> eth0: ethernet@1c30000
> at the moment, but I guess the intention was just:
> Net:   eth0: ethernet@1c30000
>
> So given that, and the fact that "interface9" is not really helpful,
> that looks alright to me.
>
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>
> Thanks,
> Andre
> > ---
> >
> >  drivers/net/sun8i_emac.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
> > index 2220f84b6978..a4b3492b7647 100644
> > --- a/drivers/net/sun8i_emac.c
> > +++ b/drivers/net/sun8i_emac.c
> > @@ -857,7 +857,7 @@ static int sun8i_emac_eth_of_to_plat(struct udevice *dev)
> >       priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1);
> >
> >       pdata->phy_interface = dev_read_phy_mode(dev);
> > -     printf("phy interface%d\n", pdata->phy_interface);
> > +     debug("phy interface %d\n", pdata->phy_interface);
> >       if (pdata->phy_interface == PHY_INTERFACE_MODE_NA)
> >               return -EINVAL;
> >
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>