* [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER
@ 2022-07-08 9:14 Michal Simek
2022-07-08 16:37 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Michal Simek @ 2022-07-08 9:14 UTC (permalink / raw)
To: u-boot, git; +Cc: Bharat Gooty, Rayagonda Kokatanur, Tom Rini
keystone doesn't have custom gpio.h that's why don't select
GPIO_EXTRA_HEADER which points to it.
Logic in arch/arm/include/asm/gpio.h is very clear
#ifdef CONFIG_GPIO_EXTRA_HEADER
#include <asm/arch/gpio.h>
#endif
#include <asm-generic/gpio.h>
Where it is visible that there is no gpio.h in platform headers:
$ ls arch/arm/mach-keystone/include/mach/
clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h
hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h
clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h
hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
arch/arm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index ef79fc3a0a76..ac3c2ab2e593 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -829,7 +829,6 @@ config ARCH_KEYSTONE
select CMD_POWEROFF
select CPU_V7A
select DDR_SPD
- select GPIO_EXTRA_HEADER
select SUPPORT_SPL
select SYS_ARCH_TIMER
select SYS_THUMB_BUILD
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER
2022-07-08 9:14 [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER Michal Simek
@ 2022-07-08 16:37 ` Tom Rini
2022-07-15 8:09 ` Michal Simek
2022-07-25 21:20 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2022-07-08 16:37 UTC (permalink / raw)
To: Michal Simek; +Cc: u-boot, git, Bharat Gooty, Rayagonda Kokatanur
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Fri, Jul 08, 2022 at 11:14:52AM +0200, Michal Simek wrote:
> keystone doesn't have custom gpio.h that's why don't select
> GPIO_EXTRA_HEADER which points to it.
>
> Logic in arch/arm/include/asm/gpio.h is very clear
>
> #ifdef CONFIG_GPIO_EXTRA_HEADER
> #include <asm/arch/gpio.h>
> #endif
> #include <asm-generic/gpio.h>
>
> Where it is visible that there is no gpio.h in platform headers:
> $ ls arch/arm/mach-keystone/include/mach/
> clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h
> hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h
> clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h
> hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER
2022-07-08 9:14 [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER Michal Simek
2022-07-08 16:37 ` Tom Rini
@ 2022-07-15 8:09 ` Michal Simek
2022-07-25 21:20 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2022-07-15 8:09 UTC (permalink / raw)
To: u-boot, git; +Cc: Bharat Gooty, Rayagonda Kokatanur, Tom Rini
On 7/8/22 11:14, Michal Simek wrote:
> keystone doesn't have custom gpio.h that's why don't select
> GPIO_EXTRA_HEADER which points to it.
>
> Logic in arch/arm/include/asm/gpio.h is very clear
>
> #ifdef CONFIG_GPIO_EXTRA_HEADER
> #include <asm/arch/gpio.h>
> #endif
> #include <asm-generic/gpio.h>
>
> Where it is visible that there is no gpio.h in platform headers:
> $ ls arch/arm/mach-keystone/include/mach/
> clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h
> hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h
> clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h
> hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ef79fc3a0a76..ac3c2ab2e593 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -829,7 +829,6 @@ config ARCH_KEYSTONE
> select CMD_POWEROFF
> select CPU_V7A
> select DDR_SPD
> - select GPIO_EXTRA_HEADER
> select SUPPORT_SPL
> select SYS_ARCH_TIMER
> select SYS_THUMB_BUILD
I will take this via my tree because it looks like this platform is not actively
maintained.
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER
2022-07-08 9:14 [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER Michal Simek
2022-07-08 16:37 ` Tom Rini
2022-07-15 8:09 ` Michal Simek
@ 2022-07-25 21:20 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2022-07-25 21:20 UTC (permalink / raw)
To: Michal Simek; +Cc: u-boot, git, Bharat Gooty, Rayagonda Kokatanur
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On Fri, Jul 08, 2022 at 11:14:52AM +0200, Michal Simek wrote:
> keystone doesn't have custom gpio.h that's why don't select
> GPIO_EXTRA_HEADER which points to it.
>
> Logic in arch/arm/include/asm/gpio.h is very clear
>
> #ifdef CONFIG_GPIO_EXTRA_HEADER
> #include <asm/arch/gpio.h>
> #endif
> #include <asm-generic/gpio.h>
>
> Where it is visible that there is no gpio.h in platform headers:
> $ ls arch/arm/mach-keystone/include/mach/
> clock_defs.h clock-k2e.h clock-k2hk.h ddr3.h hardware-k2e.h
> hardware-k2hk.h i2c_defs.h mon.h mux-k2g.h xhci-keystone.h
> clock.h clock-k2g.h clock-k2l.h hardware.h hardware-k2g.h
> hardware-k2l.h mmc_host_def.h msmc.h psc_defs.h
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-25 21:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-08 9:14 [PATCH] ti: keystone: Don't select GPIO_EXTRA_HEADER Michal Simek
2022-07-08 16:37 ` Tom Rini
2022-07-15 8:09 ` Michal Simek
2022-07-25 21:20 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).