u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI
@ 2022-08-30 19:50 Jorge Ramirez-Ortiz
  2022-09-05 16:32 ` Jorge Ramirez-Ortiz, Foundries
  0 siblings, 1 reply; 4+ messages in thread
From: Jorge Ramirez-Ortiz @ 2022-08-30 19:50 UTC (permalink / raw)
  To: jorge, patrick.delaunay, patrice.chotard; +Cc: uboot-stm32, u-boot, mike

Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI
from executing.

The side effect observed are I2C devices no longer being
accessible from U-boot after a soft reset.

Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
---
 configs/stm32mp13_defconfig         | 1 -
 configs/stm32mp15_defconfig         | 1 -
 configs/stm32mp15_trusted_defconfig | 1 -
 3 files changed, 3 deletions(-)

diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig
index 673b468d31..44cee2e656 100644
--- a/configs/stm32mp13_defconfig
+++ b/configs/stm32mp13_defconfig
@@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_STM32=y
 CONFIG_SERIAL_RX_BUFFER=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig
index e5a2996c2c..2ad02f3652 100644
--- a/configs/stm32mp15_defconfig
+++ b/configs/stm32mp15_defconfig
@@ -133,7 +133,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
index e14668042f..9e24e82920 100644
--- a/configs/stm32mp15_trusted_defconfig
+++ b/configs/stm32mp15_trusted_defconfig
@@ -134,7 +134,6 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_STM32_QSPI=y
 CONFIG_STM32_SPI=y
-CONFIG_SYSRESET_PSCI=y
 CONFIG_TEE=y
 CONFIG_OPTEE=y
 # CONFIG_OPTEE_TA_AVB is not set
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI
  2022-08-30 19:50 [PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI Jorge Ramirez-Ortiz
@ 2022-09-05 16:32 ` Jorge Ramirez-Ortiz, Foundries
  2022-09-05 17:01   ` Oleksandr Suvorov
  0 siblings, 1 reply; 4+ messages in thread
From: Jorge Ramirez-Ortiz, Foundries @ 2022-09-05 16:32 UTC (permalink / raw)
  To: Jorge Ramirez-Ortiz
  Cc: patrick.delaunay, patrice.chotard, uboot-stm32, u-boot, mike

On 30/08/22, Jorge Ramirez-Ortiz wrote:
> Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI
> from executing.
> 
> The side effect observed are I2C devices no longer being
> accessible from U-boot after a soft reset.

I think this PR should get a bit more of attention.

The current reset configuration is broken, this is a fix.
Do I need to rename the PR?

TIA
jorge


> 
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
>  configs/stm32mp13_defconfig         | 1 -
>  configs/stm32mp15_defconfig         | 1 -
>  configs/stm32mp15_trusted_defconfig | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig
> index 673b468d31..44cee2e656 100644
> --- a/configs/stm32mp13_defconfig
> +++ b/configs/stm32mp13_defconfig
> @@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
>  CONFIG_DM_RTC=y
>  CONFIG_RTC_STM32=y
>  CONFIG_SERIAL_RX_BUFFER=y
> -CONFIG_SYSRESET_PSCI=y
>  CONFIG_TEE=y
>  CONFIG_OPTEE=y
>  # CONFIG_OPTEE_TA_AVB is not set
> diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig
> index e5a2996c2c..2ad02f3652 100644
> --- a/configs/stm32mp15_defconfig
> +++ b/configs/stm32mp15_defconfig
> @@ -133,7 +133,6 @@ CONFIG_SPI=y
>  CONFIG_DM_SPI=y
>  CONFIG_STM32_QSPI=y
>  CONFIG_STM32_SPI=y
> -CONFIG_SYSRESET_PSCI=y
>  CONFIG_TEE=y
>  CONFIG_OPTEE=y
>  # CONFIG_OPTEE_TA_AVB is not set
> diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
> index e14668042f..9e24e82920 100644
> --- a/configs/stm32mp15_trusted_defconfig
> +++ b/configs/stm32mp15_trusted_defconfig
> @@ -134,7 +134,6 @@ CONFIG_SPI=y
>  CONFIG_DM_SPI=y
>  CONFIG_STM32_QSPI=y
>  CONFIG_STM32_SPI=y
> -CONFIG_SYSRESET_PSCI=y
>  CONFIG_TEE=y
>  CONFIG_OPTEE=y
>  # CONFIG_OPTEE_TA_AVB is not set
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI
  2022-09-05 16:32 ` Jorge Ramirez-Ortiz, Foundries
@ 2022-09-05 17:01   ` Oleksandr Suvorov
  2022-09-19 14:59     ` Patrick DELAUNAY
  0 siblings, 1 reply; 4+ messages in thread
From: Oleksandr Suvorov @ 2022-09-05 17:01 UTC (permalink / raw)
  To: Jorge Ramirez-Ortiz, Foundries
  Cc: patrick.delaunay, patrice.chotard, uboot-stm32, u-boot, mike

Jorge,

I think, renaming the patch to "fix" and adding a field "Fixes:"
should help accept it faster.

On Mon, Sep 5, 2022 at 7:32 PM Jorge Ramirez-Ortiz, Foundries
<jorge@foundries.io> wrote:
>
> On 30/08/22, Jorge Ramirez-Ortiz wrote:
> > Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI
> > from executing.
> >
> > The side effect observed are I2C devices no longer being
> > accessible from U-boot after a soft reset.
>
> I think this PR should get a bit more of attention.
>
> The current reset configuration is broken, this is a fix.
> Do I need to rename the PR?
>
> TIA
> jorge
>
>
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > ---
> >  configs/stm32mp13_defconfig         | 1 -
> >  configs/stm32mp15_defconfig         | 1 -
> >  configs/stm32mp15_trusted_defconfig | 1 -
> >  3 files changed, 3 deletions(-)
> >
> > diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig
> > index 673b468d31..44cee2e656 100644
> > --- a/configs/stm32mp13_defconfig
> > +++ b/configs/stm32mp13_defconfig
> > @@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
> >  CONFIG_DM_RTC=y
> >  CONFIG_RTC_STM32=y
> >  CONFIG_SERIAL_RX_BUFFER=y
> > -CONFIG_SYSRESET_PSCI=y
> >  CONFIG_TEE=y
> >  CONFIG_OPTEE=y
> >  # CONFIG_OPTEE_TA_AVB is not set
> > diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig
> > index e5a2996c2c..2ad02f3652 100644
> > --- a/configs/stm32mp15_defconfig
> > +++ b/configs/stm32mp15_defconfig
> > @@ -133,7 +133,6 @@ CONFIG_SPI=y
> >  CONFIG_DM_SPI=y
> >  CONFIG_STM32_QSPI=y
> >  CONFIG_STM32_SPI=y
> > -CONFIG_SYSRESET_PSCI=y
> >  CONFIG_TEE=y
> >  CONFIG_OPTEE=y
> >  # CONFIG_OPTEE_TA_AVB is not set
> > diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
> > index e14668042f..9e24e82920 100644
> > --- a/configs/stm32mp15_trusted_defconfig
> > +++ b/configs/stm32mp15_trusted_defconfig
> > @@ -134,7 +134,6 @@ CONFIG_SPI=y
> >  CONFIG_DM_SPI=y
> >  CONFIG_STM32_QSPI=y
> >  CONFIG_STM32_SPI=y
> > -CONFIG_SYSRESET_PSCI=y
> >  CONFIG_TEE=y
> >  CONFIG_OPTEE=y
> >  # CONFIG_OPTEE_TA_AVB is not set
> > --
> > 2.34.1
> >



-- 
Best regards
Oleksandr

Oleksandr Suvorov
cryosay@gmail.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI
  2022-09-05 17:01   ` Oleksandr Suvorov
@ 2022-09-19 14:59     ` Patrick DELAUNAY
  0 siblings, 0 replies; 4+ messages in thread
From: Patrick DELAUNAY @ 2022-09-19 14:59 UTC (permalink / raw)
  To: Oleksandr Suvorov, Jorge Ramirez-Ortiz, Foundries
  Cc: patrice.chotard, uboot-stm32, u-boot, mike

Hi,

On 9/5/22 19:01, Oleksandr Suvorov wrote:
> Jorge,
>
> I think, renaming the patch to "fix" and adding a field "Fixes:"
> should help accept it faster.
>
> On Mon, Sep 5, 2022 at 7:32 PM Jorge Ramirez-Ortiz, Foundries
> <jorge@foundries.io> wrote:
>> On 30/08/22, Jorge Ramirez-Ortiz wrote:
>>> Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI
>>> from executing.
>>>
>>> The side effect observed are I2C devices no longer being
>>> accessible from U-boot after a soft reset.
>> I think this PR should get a bit more of attention.
>>
>> The current reset configuration is broken, this is a fix.
>> Do I need to rename the PR?
>>
>> TIA
>> jorge
>>
>>
>>> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
>>> ---
>>>   configs/stm32mp13_defconfig         | 1 -
>>>   configs/stm32mp15_defconfig         | 1 -
>>>   configs/stm32mp15_trusted_defconfig | 1 -
>>>   3 files changed, 3 deletions(-)
>>>
>>> diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig
>>> index 673b468d31..44cee2e656 100644
>>> --- a/configs/stm32mp13_defconfig
>>> +++ b/configs/stm32mp13_defconfig
>>> @@ -69,7 +69,6 @@ CONFIG_RNG_OPTEE=y
>>>   CONFIG_DM_RTC=y
>>>   CONFIG_RTC_STM32=y
>>>   CONFIG_SERIAL_RX_BUFFER=y
>>> -CONFIG_SYSRESET_PSCI=y
>>>   CONFIG_TEE=y
>>>   CONFIG_OPTEE=y
>>>   # CONFIG_OPTEE_TA_AVB is not set
>>> diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig
>>> index e5a2996c2c..2ad02f3652 100644
>>> --- a/configs/stm32mp15_defconfig
>>> +++ b/configs/stm32mp15_defconfig
>>> @@ -133,7 +133,6 @@ CONFIG_SPI=y
>>>   CONFIG_DM_SPI=y
>>>   CONFIG_STM32_QSPI=y
>>>   CONFIG_STM32_SPI=y
>>> -CONFIG_SYSRESET_PSCI=y
>>>   CONFIG_TEE=y
>>>   CONFIG_OPTEE=y
>>>   # CONFIG_OPTEE_TA_AVB is not set
>>> diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
>>> index e14668042f..9e24e82920 100644
>>> --- a/configs/stm32mp15_trusted_defconfig
>>> +++ b/configs/stm32mp15_trusted_defconfig
>>> @@ -134,7 +134,6 @@ CONFIG_SPI=y
>>>   CONFIG_DM_SPI=y
>>>   CONFIG_STM32_QSPI=y
>>>   CONFIG_STM32_SPI=y
>>> -CONFIG_SYSRESET_PSCI=y
>>>   CONFIG_TEE=y
>>>   CONFIG_OPTEE=y
>>>   # CONFIG_OPTEE_TA_AVB is not set
>>> --
>>> 2.34.1
>>>
>
>

This patch it is superseded by "configs: stm32mp*: fix system reset"

http://patchwork.ozlabs.org/project/uboot/list/?series=316914&state=*

http://patchwork.ozlabs.org/project/uboot/patch/20220905173357.2231466-1-jorge@foundries.io/


with the added "Fixes:"


Regards


Patrick


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-19 14:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 19:50 [PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI Jorge Ramirez-Ortiz
2022-09-05 16:32 ` Jorge Ramirez-Ortiz, Foundries
2022-09-05 17:01   ` Oleksandr Suvorov
2022-09-19 14:59     ` Patrick DELAUNAY

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).