* [PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error
[not found] <k3-udma-fix>
@ 2022-09-20 5:26 ` Dhruva Gole
2022-09-20 18:16 ` Tom Rini
2022-10-07 15:47 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Dhruva Gole @ 2022-09-20 5:26 UTC (permalink / raw)
To: trini; +Cc: Praneeth, Vignesh, u-boot, Dhruva Gole
Include linux/sizes.h because it defines SZ_64K which is used in many
places inside k3-udma.c
This fixes the error: ‘SZ_64K’ undeclared which appears during build
time
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---
I came across this error while trying to build upstream u-boot for the
AM62x. I needed to enable udma for xSPI boot and I got the following
build errors:
../drivers/dma/ti/k3-udma.c: In function ‘udma_prep_dma_memcpy’:
../drivers/dma/ti/k3-udma.c:1849:12: error: ‘SZ_64K’ undeclared (first
use in this function)
1849 | if (len < SZ_64K) {
| ^~~~~~
This probably went unnoticed until now because it was being included in
all the include/config/xx_evm.h files. However it being absent from
upstream am62_evm.h landed me this error and I think it makes sense to
actually add the include sizes.h here itself rather than rely that some
other included file that is included in k3-udma will include it in
itself.
Thanks and Regards,
Dhruva Gole
drivers/dma/ti/k3-udma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 86603d43f14f..1a9197bfc820 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -14,6 +14,7 @@
#include <malloc.h>
#include <linux/bitops.h>
#include <linux/dma-mapping.h>
+#include <linux/sizes.h>
#include <dm.h>
#include <dm/device_compat.h>
#include <dm/devres.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error
2022-09-20 5:26 ` [PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error Dhruva Gole
@ 2022-09-20 18:16 ` Tom Rini
2022-10-07 15:47 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-09-20 18:16 UTC (permalink / raw)
To: Dhruva Gole; +Cc: Praneeth, Vignesh, u-boot
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
On Tue, Sep 20, 2022 at 10:56:02AM +0530, Dhruva Gole wrote:
> Include linux/sizes.h because it defines SZ_64K which is used in many
> places inside k3-udma.c
> This fixes the error: ‘SZ_64K’ undeclared which appears during build
> time
>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error
2022-09-20 5:26 ` [PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error Dhruva Gole
2022-09-20 18:16 ` Tom Rini
@ 2022-10-07 15:47 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-10-07 15:47 UTC (permalink / raw)
To: Dhruva Gole; +Cc: Praneeth, Vignesh, u-boot
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
On Tue, Sep 20, 2022 at 10:56:02AM +0530, Dhruva Gole wrote:
> Include linux/sizes.h because it defines SZ_64K which is used in many
> places inside k3-udma.c
> This fixes the error: ‘SZ_64K’ undeclared which appears during build
> time
>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-07 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <k3-udma-fix>
2022-09-20 5:26 ` [PATCH] dma: ti: k3-udma: Fix 'SZ_64K’ undeclared error Dhruva Gole
2022-09-20 18:16 ` Tom Rini
2022-10-07 15:47 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).