* [PATCH] spi: zynqmp_qspi: Mark zynqmp_qspi_set_tapdelay() as static
@ 2022-10-04 5:37 Venkatesh Yadav Abbarapu
2022-10-07 9:31 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Venkatesh Yadav Abbarapu @ 2022-10-04 5:37 UTC (permalink / raw)
To: u-boot; +Cc: michal.simek, jagan, git
Fix the following sparse and compile time warning triggered with W=1:
drivers/spi/zynqmp_gqspi.c:286:6:
warning: no previous prototype for 'zynqmp_qspi_set_tapdelay'
[-Wmissing-prototypes]
Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
---
drivers/spi/zynqmp_gqspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/spi/zynqmp_gqspi.c
index c772bae3cc..ab8c551466 100644
--- a/drivers/spi/zynqmp_gqspi.c
+++ b/drivers/spi/zynqmp_gqspi.c
@@ -283,7 +283,7 @@ static void zynqmp_qspi_chipselect(struct zynqmp_qspi_priv *priv, int is_on)
zynqmp_qspi_fill_gen_fifo(priv, gqspi_fifo_reg);
}
-void zynqmp_qspi_set_tapdelay(struct udevice *bus, u32 baudrateval)
+static void zynqmp_qspi_set_tapdelay(struct udevice *bus, u32 baudrateval)
{
struct zynqmp_qspi_plat *plat = dev_get_plat(bus);
struct zynqmp_qspi_priv *priv = dev_get_priv(bus);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: zynqmp_qspi: Mark zynqmp_qspi_set_tapdelay() as static
2022-10-04 5:37 [PATCH] spi: zynqmp_qspi: Mark zynqmp_qspi_set_tapdelay() as static Venkatesh Yadav Abbarapu
@ 2022-10-07 9:31 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2022-10-07 9:31 UTC (permalink / raw)
To: Venkatesh Yadav Abbarapu, u-boot; +Cc: jagan, git
On 10/4/22 07:37, Venkatesh Yadav Abbarapu wrote:
> Fix the following sparse and compile time warning triggered with W=1:
>
> drivers/spi/zynqmp_gqspi.c:286:6:
> warning: no previous prototype for 'zynqmp_qspi_set_tapdelay'
> [-Wmissing-prototypes]
>
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
> ---
>
> drivers/spi/zynqmp_gqspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/spi/zynqmp_gqspi.c
> index c772bae3cc..ab8c551466 100644
> --- a/drivers/spi/zynqmp_gqspi.c
> +++ b/drivers/spi/zynqmp_gqspi.c
> @@ -283,7 +283,7 @@ static void zynqmp_qspi_chipselect(struct zynqmp_qspi_priv *priv, int is_on)
> zynqmp_qspi_fill_gen_fifo(priv, gqspi_fifo_reg);
> }
>
> -void zynqmp_qspi_set_tapdelay(struct udevice *bus, u32 baudrateval)
> +static void zynqmp_qspi_set_tapdelay(struct udevice *bus, u32 baudrateval)
> {
> struct zynqmp_qspi_plat *plat = dev_get_plat(bus);
> struct zynqmp_qspi_priv *priv = dev_get_priv(bus);
Applied.
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-07 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 5:37 [PATCH] spi: zynqmp_qspi: Mark zynqmp_qspi_set_tapdelay() as static Venkatesh Yadav Abbarapu
2022-10-07 9:31 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).