* [PATCH v2 0/3] sbi/cmd: improve output formatting
@ 2022-10-04 8:09 Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 1/3] cmd/sbi: format RustSBI version number Heinrich Schuchardt
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2022-10-04 8:09 UTC (permalink / raw)
To: Leo Liang, Rick Chen; +Cc: Sean Anderson, u-boot, Heinrich Schuchardt
* correctly format the version number for RustSBI
* provide an error message if the SBI does not implement
the 'SBI Base Functionality' extension.
* provide user friendly short texts for the legacy extensions
v2:
remove spurious '+' in first patch
Heinrich Schuchardt (3):
cmd/sbi: format RustSBI version number
cmd/sbi: error message for failure to get spec version
cmd/sbi: user friendly short texts
cmd/riscv/sbi.c | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
--
2.37.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/3] cmd/sbi: format RustSBI version number
2022-10-04 8:09 [PATCH v2 0/3] sbi/cmd: improve output formatting Heinrich Schuchardt
@ 2022-10-04 8:09 ` Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 2/3] cmd/sbi: error message for failure to get spec version Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 3/3] cmd/sbi: user friendly short texts Heinrich Schuchardt
2 siblings, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2022-10-04 8:09 UTC (permalink / raw)
To: Leo Liang, Rick Chen; +Cc: Sean Anderson, u-boot, Heinrich Schuchardt
The SBI command can print out the version number of the SBI implementation.
Choose the correct output format for RustSBI.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Rick Chen <rick@andestech.com>
---
v2:
remove spurious '+' from inserted line
---
cmd/riscv/sbi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
index 522f502435..9bbe7d4b90 100644
--- a/cmd/riscv/sbi.c
+++ b/cmd/riscv/sbi.c
@@ -74,6 +74,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc,
vers >> 16, vers & 0xffff);
break;
case 3: /* KVM */
+ case 4: /* RustSBI */
printf("%ld.%ld.%ld",
vers >> 16,
(vers >> 8) & 0xff,
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/3] cmd/sbi: error message for failure to get spec version
2022-10-04 8:09 [PATCH v2 0/3] sbi/cmd: improve output formatting Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 1/3] cmd/sbi: format RustSBI version number Heinrich Schuchardt
@ 2022-10-04 8:09 ` Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 3/3] cmd/sbi: user friendly short texts Heinrich Schuchardt
2 siblings, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2022-10-04 8:09 UTC (permalink / raw)
To: Leo Liang, Rick Chen; +Cc: Sean Anderson, u-boot, Heinrich Schuchardt
If calling 'Get SBI specification version' fails, write an error message
and return CMD_RET_FAILURE.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Rick Chen <rick@andestech.com>
---
v2:
no change
---
cmd/riscv/sbi.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
index 9bbe7d4b90..24955d2be1 100644
--- a/cmd/riscv/sbi.c
+++ b/cmd/riscv/sbi.c
@@ -56,8 +56,11 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc,
long mvendorid, marchid, mimpid;
ret = sbi_get_spec_version();
- if (ret >= 0)
- printf("SBI %ld.%ld", ret >> 24, ret & 0xffffff);
+ if (ret < 0) {
+ printf("No SBI 0.2+\n");
+ return CMD_RET_FAILURE;
+ }
+ printf("SBI %ld.%ld", ret >> 24, ret & 0xffffff);
impl_id = sbi_get_impl_id();
if (impl_id >= 0) {
for (i = 0; i < ARRAY_SIZE(implementations); ++i) {
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 3/3] cmd/sbi: user friendly short texts
2022-10-04 8:09 [PATCH v2 0/3] sbi/cmd: improve output formatting Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 1/3] cmd/sbi: format RustSBI version number Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 2/3] cmd/sbi: error message for failure to get spec version Heinrich Schuchardt
@ 2022-10-04 8:09 ` Heinrich Schuchardt
2 siblings, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2022-10-04 8:09 UTC (permalink / raw)
To: Leo Liang, Rick Chen; +Cc: Sean Anderson, u-boot, Heinrich Schuchardt
In the sbi command use the same short texts for the legacy extensions
as the SBI specification 1.0.0.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Rick Chen <rick@andestech.com>
---
v2:
no change
---
cmd/riscv/sbi.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
index 24955d2be1..6f2cad4e7e 100644
--- a/cmd/riscv/sbi.c
+++ b/cmd/riscv/sbi.c
@@ -30,15 +30,15 @@ static struct sbi_imp implementations[] = {
};
static struct sbi_ext extensions[] = {
- { SBI_EXT_0_1_SET_TIMER, "sbi_set_timer" },
- { SBI_EXT_0_1_CONSOLE_PUTCHAR, "sbi_console_putchar" },
- { SBI_EXT_0_1_CONSOLE_GETCHAR, "sbi_console_getchar" },
- { SBI_EXT_0_1_CLEAR_IPI, "sbi_clear_ipi" },
- { SBI_EXT_0_1_SEND_IPI, "sbi_send_ipi" },
- { SBI_EXT_0_1_REMOTE_FENCE_I, "sbi_remote_fence_i" },
- { SBI_EXT_0_1_REMOTE_SFENCE_VMA, "sbi_remote_sfence_vma" },
- { SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID, "sbi_remote_sfence_vma_asid" },
- { SBI_EXT_0_1_SHUTDOWN, "sbi_shutdown" },
+ { SBI_EXT_0_1_SET_TIMER, "Set Timer" },
+ { SBI_EXT_0_1_CONSOLE_PUTCHAR, "Console Putchar" },
+ { SBI_EXT_0_1_CONSOLE_GETCHAR, "Console Getchar" },
+ { SBI_EXT_0_1_CLEAR_IPI, "Clear IPI" },
+ { SBI_EXT_0_1_SEND_IPI, "Send IPI" },
+ { SBI_EXT_0_1_REMOTE_FENCE_I, "Remote FENCE.I" },
+ { SBI_EXT_0_1_REMOTE_SFENCE_VMA, "Remote SFENCE.VMA" },
+ { SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID, "Remote SFENCE.VMA with ASID" },
+ { SBI_EXT_0_1_SHUTDOWN, "System Shutdown" },
{ SBI_EXT_BASE, "SBI Base Functionality" },
{ SBI_EXT_TIME, "Timer Extension" },
{ SBI_EXT_IPI, "IPI Extension" },
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-04 8:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 8:09 [PATCH v2 0/3] sbi/cmd: improve output formatting Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 1/3] cmd/sbi: format RustSBI version number Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 2/3] cmd/sbi: error message for failure to get spec version Heinrich Schuchardt
2022-10-04 8:09 ` [PATCH v2 3/3] cmd/sbi: user friendly short texts Heinrich Schuchardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).