* [PATCH] tools: mkenvimage: Drop duplicate crc header include
@ 2022-11-07 0:56 Marek Vasut
2022-11-07 15:28 ` Simon Glass
2022-11-24 21:33 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2022-11-07 0:56 UTC (permalink / raw)
To: u-boot; +Cc: Marek Vasut, Simon Glass, Tom Rini
This header was already included just above version.h,
do not include it twice.
Fixes: 3db71108575 ("crc32: Use the crc.h header for crc functions")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
tools/mkenvimage.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
index b05f83415f0..a8eebab6c33 100644
--- a/tools/mkenvimage.c
+++ b/tools/mkenvimage.c
@@ -14,7 +14,6 @@
#include <stdlib.h>
#include <stdint.h>
#include <string.h>
-#include <u-boot/crc.h>
#include <unistd.h>
#include <libgen.h>
#include <sys/types.h>
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: mkenvimage: Drop duplicate crc header include
2022-11-07 0:56 [PATCH] tools: mkenvimage: Drop duplicate crc header include Marek Vasut
@ 2022-11-07 15:28 ` Simon Glass
2022-11-24 21:33 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-11-07 15:28 UTC (permalink / raw)
To: Marek Vasut; +Cc: u-boot, Tom Rini
On Sun, 6 Nov 2022 at 17:56, Marek Vasut <marex@denx.de> wrote:
>
> This header was already included just above version.h,
> do not include it twice.
>
> Fixes: 3db71108575 ("crc32: Use the crc.h header for crc functions")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> tools/mkenvimage.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: mkenvimage: Drop duplicate crc header include
2022-11-07 0:56 [PATCH] tools: mkenvimage: Drop duplicate crc header include Marek Vasut
2022-11-07 15:28 ` Simon Glass
@ 2022-11-24 21:33 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-11-24 21:33 UTC (permalink / raw)
To: Marek Vasut; +Cc: u-boot, Simon Glass
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
On Mon, Nov 07, 2022 at 01:56:04AM +0100, Marek Vasut wrote:
> This header was already included just above version.h,
> do not include it twice.
>
> Fixes: 3db71108575 ("crc32: Use the crc.h header for crc functions")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-24 21:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 0:56 [PATCH] tools: mkenvimage: Drop duplicate crc header include Marek Vasut
2022-11-07 15:28 ` Simon Glass
2022-11-24 21:33 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).