* [PATCH 1/1] usb: gadget: missing fallthrough in composite_setup()
@ 2023-04-01 7:06 Heinrich Schuchardt
2023-04-02 17:53 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2023-04-01 7:06 UTC (permalink / raw)
To: Marek Vasut; +Cc: Lukasz Majewski, u-boot, Heinrich Schuchardt
Add a missing fallthrough macro. This fixes a -Wimplicit-fallthrough
warning.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
drivers/usb/gadget/composite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 2a309e624e..04b8541993 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -1068,7 +1068,7 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)
if (!gadget_is_dualspeed(gadget) ||
gadget->speed >= USB_SPEED_SUPER)
break;
-
+ fallthrough;
case USB_DT_CONFIG:
value = config_desc(cdev, w_value);
if (value >= 0)
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] usb: gadget: missing fallthrough in composite_setup()
2023-04-01 7:06 [PATCH 1/1] usb: gadget: missing fallthrough in composite_setup() Heinrich Schuchardt
@ 2023-04-02 17:53 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2023-04-02 17:53 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Lukasz Majewski, u-boot
On 4/1/23 09:06, Heinrich Schuchardt wrote:
> Add a missing fallthrough macro. This fixes a -Wimplicit-fallthrough
> warning.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> drivers/usb/gadget/composite.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 2a309e624e..04b8541993 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -1068,7 +1068,7 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)
> if (!gadget_is_dualspeed(gadget) ||
> gadget->speed >= USB_SPEED_SUPER)
> break;
> -
> + fallthrough;
> case USB_DT_CONFIG:
> value = config_desc(cdev, w_value);
> if (value >= 0)
Applied to usb/next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-02 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-01 7:06 [PATCH 1/1] usb: gadget: missing fallthrough in composite_setup() Heinrich Schuchardt
2023-04-02 17:53 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).