u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: [PATCH v2] disk: Use a helper function to reduce duplication
Date: Mon, 3 Apr 2023 09:06:13 +0900	[thread overview]
Message-ID: <20230403000613.GA37805@laputa> (raw)
In-Reply-To: <20230331141703.GV13222@bill-the-cat>

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Hi Tom,

On Fri, Mar 31, 2023 at 10:17:03AM -0400, Tom Rini wrote:
> On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote:
> 
> > Reduce the duplicated code slightly by using a helper function to handle
> > the common code.
> > 
> > This reduces the code size very slightly.
> > 
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> 
> Applied to u-boot/next, thanks!

I think I said nak against this patch.
https://lists.denx.de/pipermail/u-boot/2023-March/512677.html

-Takahiro Akashi


> -- 
> Tom



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-04-03  0:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-19 19:29 [PATCH v2] disk: Use a helper function to reduce duplication Simon Glass
2023-03-20  7:31 ` Ilias Apalodimas
2023-03-20  7:57   ` AKASHI Takahiro
2023-03-31 14:17 ` Tom Rini
2023-04-03  0:06   ` AKASHI Takahiro [this message]
2023-04-03  1:16     ` Simon Glass
2023-04-03 14:46     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403000613.GA37805@laputa \
    --to=takahiro.akashi@linaro.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).