[PATCH] stm32mp: stm32prog: improve the partitioning trace

[PATCH] stm32mp: stm32prog: improve the partitioning trace

[Patrick Delaunay]

Improve the partitioning trace done in command stm32prog:
- remove the trace "partition: Done" when the GPT partitioning is not done
- indicate the mmc instance used for each 'gpt write' command

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

 arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
index c391b6c7abb..7ee4590ef26 100644
--- a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
+++ b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
@@ -1090,7 +1090,6 @@ static int create_gpt_partitions(struct stm32prog_data *data)
 	if (!buf)
 		return -ENOMEM;
 
-	puts("partitions : ");
 	/* initialize the selected device */
 	for (i = 0; i < data->dev_nb; i++) {
 		/* create gpt partition support only for full update on MMC */
@@ -1098,6 +1097,7 @@ static int create_gpt_partitions(struct stm32prog_data *data)
 		    !data->dev[i].full_update)
 			continue;
 
+		printf("partitions on mmc%d: ", data->dev[i].dev_id);
 		offset = 0;
 		rootfs_found = false;
 		memset(buf, 0, buflen);
@@ -1197,8 +1197,8 @@ static int create_gpt_partitions(struct stm32prog_data *data)
 		sprintf(buf, "part list mmc %d", data->dev[i].dev_id);
 		run_command(buf, 0);
 #endif
+		puts("done\n");
 	}
-	puts("done\n");
 
 #ifdef DEBUG
 	run_command("mtd list", 0);
-- 
2.25.1

Re: [PATCH] stm32mp: stm32prog: improve the partitioning trace

[Patrice CHOTARD]

Hi Patrick

On 9/9/22 17:22, Patrick Delaunay wrote:
> Improve the partitioning trace done in command stm32prog:
> - remove the trace "partition: Done" when the GPT partitioning is not done
> - indicate the mmc instance used for each 'gpt write' command
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
> index c391b6c7abb..7ee4590ef26 100644
> --- a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
> +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
> @@ -1090,7 +1090,6 @@ static int create_gpt_partitions(struct stm32prog_data *data)
>  	if (!buf)
>  		return -ENOMEM;
>  
> -	puts("partitions : ");
>  	/* initialize the selected device */
>  	for (i = 0; i < data->dev_nb; i++) {
>  		/* create gpt partition support only for full update on MMC */
> @@ -1098,6 +1097,7 @@ static int create_gpt_partitions(struct stm32prog_data *data)
>  		    !data->dev[i].full_update)
>  			continue;
>  
> +		printf("partitions on mmc%d: ", data->dev[i].dev_id);
>  		offset = 0;
>  		rootfs_found = false;
>  		memset(buf, 0, buflen);
> @@ -1197,8 +1197,8 @@ static int create_gpt_partitions(struct stm32prog_data *data)
>  		sprintf(buf, "part list mmc %d", data->dev[i].dev_id);
>  		run_command(buf, 0);
>  #endif
> +		puts("done\n");
>  	}
> -	puts("done\n");
>  
>  #ifdef DEBUG
>  	run_command("mtd list", 0);

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice

Re: [Uboot-stm32] [PATCH] stm32mp: stm32prog: improve the partitioning trace

[Patrice CHOTARD]

HI Patrick

On 9/12/22 08:43, Patrice CHOTARD wrote:
> Hi Patrick
> 
> On 9/9/22 17:22, Patrick Delaunay wrote:
>> Improve the partitioning trace done in command stm32prog:
>> - remove the trace "partition: Done" when the GPT partitioning is not done
>> - indicate the mmc instance used for each 'gpt write' command
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>>
>>  arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
>> index c391b6c7abb..7ee4590ef26 100644
>> --- a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
>> +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c
>> @@ -1090,7 +1090,6 @@ static int create_gpt_partitions(struct stm32prog_data *data)
>>  	if (!buf)
>>  		return -ENOMEM;
>>  
>> -	puts("partitions : ");
>>  	/* initialize the selected device */
>>  	for (i = 0; i < data->dev_nb; i++) {
>>  		/* create gpt partition support only for full update on MMC */
>> @@ -1098,6 +1097,7 @@ static int create_gpt_partitions(struct stm32prog_data *data)
>>  		    !data->dev[i].full_update)
>>  			continue;
>>  
>> +		printf("partitions on mmc%d: ", data->dev[i].dev_id);
>>  		offset = 0;
>>  		rootfs_found = false;
>>  		memset(buf, 0, buflen);
>> @@ -1197,8 +1197,8 @@ static int create_gpt_partitions(struct stm32prog_data *data)
>>  		sprintf(buf, "part list mmc %d", data->dev[i].dev_id);
>>  		run_command(buf, 0);
>>  #endif
>> +		puts("done\n");
>>  	}
>> -	puts("done\n");
>>  
>>  #ifdef DEBUG
>>  	run_command("mtd list", 0);
> 
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Thanks
> Patrice
> _______________________________________________
> Uboot-stm32 mailing list
> Uboot-stm32@st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32

Applied on u-boot-stm32/next

Thanks
Patrice