* [PATCH] test/py: Run simple dm commands without checking
@ 2022-07-07 10:59 Michal Simek
2022-07-12 10:58 ` Simon Glass
2022-07-15 7:59 ` Michal Simek
0 siblings, 2 replies; 4+ messages in thread
From: Michal Simek @ 2022-07-07 10:59 UTC (permalink / raw)
To: u-boot, git; +Cc: Michal Simek
From: Michal Simek <michal.simek@xilinx.com>
Just to make sure that dm commands can operate.
This was the problem on Microblaze in past without fixing manual
relocation.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
test/py/tests/test_dm.py | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/test/py/tests/test_dm.py b/test/py/tests/test_dm.py
index 97203b536e17..ea93061fdfa8 100644
--- a/test/py/tests/test_dm.py
+++ b/test/py/tests/test_dm.py
@@ -33,3 +33,11 @@ def test_dm_static(u_boot_console):
response = u_boot_console.run_command('dm drivers')
for driver in drivers:
assert driver in response
+
+@pytest.mark.buildconfigspec("cmd_dm")
+def test_dm_uclass(u_boot_console):
+ response = u_boot_console.run_command("dm uclass")
+
+@pytest.mark.buildconfigspec("cmd_dm")
+def test_dm_devres(u_boot_console):
+ response = u_boot_console.run_command("dm devres")
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] test/py: Run simple dm commands without checking
2022-07-07 10:59 [PATCH] test/py: Run simple dm commands without checking Michal Simek
@ 2022-07-12 10:58 ` Simon Glass
2022-07-12 11:21 ` Michal Simek
2022-07-15 7:59 ` Michal Simek
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2022-07-12 10:58 UTC (permalink / raw)
To: Michal Simek; +Cc: U-Boot Mailing List, git, Michal Simek
Hi Michal,
On Thu, 7 Jul 2022 at 05:00, Michal Simek <michal.simek@amd.com> wrote:
>
> From: Michal Simek <michal.simek@xilinx.com>
>
> Just to make sure that dm commands can operate.
> This was the problem on Microblaze in past without fixing manual
> relocation.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
Make up your mind :-)
> ---
>
> test/py/tests/test_dm.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
You can drop the 'response' var if you are not using it.
>
> diff --git a/test/py/tests/test_dm.py b/test/py/tests/test_dm.py
> index 97203b536e17..ea93061fdfa8 100644
> --- a/test/py/tests/test_dm.py
> +++ b/test/py/tests/test_dm.py
> @@ -33,3 +33,11 @@ def test_dm_static(u_boot_console):
> response = u_boot_console.run_command('dm drivers')
> for driver in drivers:
> assert driver in response
> +
> +@pytest.mark.buildconfigspec("cmd_dm")
> +def test_dm_uclass(u_boot_console):
> + response = u_boot_console.run_command("dm uclass")
> +
> +@pytest.mark.buildconfigspec("cmd_dm")
> +def test_dm_devres(u_boot_console):
> + response = u_boot_console.run_command("dm devres")
> --
> 2.36.1
>
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] test/py: Run simple dm commands without checking
2022-07-12 10:58 ` Simon Glass
@ 2022-07-12 11:21 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2022-07-12 11:21 UTC (permalink / raw)
To: Simon Glass; +Cc: U-Boot Mailing List, git, Michal Simek
Hi Simon,
On 7/12/22 12:58, Simon Glass wrote:
> Hi Michal,
>
> On Thu, 7 Jul 2022 at 05:00, Michal Simek <michal.simek@amd.com> wrote:
>>
>> From: Michal Simek <michal.simek@xilinx.com>
>>
>> Just to make sure that dm commands can operate.
>> This was the problem on Microblaze in past without fixing manual
>> relocation.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>
> Make up your mind :-)
the patch is in xilinx repo for quite a long time and in the meantime company
has changed. That's why two SoB lines.
>
>> ---
>>
>> test/py/tests/test_dm.py | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> You can drop the 'response' var if you are not using it.
Someone can parse it in future if they like.
M
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] test/py: Run simple dm commands without checking
2022-07-07 10:59 [PATCH] test/py: Run simple dm commands without checking Michal Simek
2022-07-12 10:58 ` Simon Glass
@ 2022-07-15 7:59 ` Michal Simek
1 sibling, 0 replies; 4+ messages in thread
From: Michal Simek @ 2022-07-15 7:59 UTC (permalink / raw)
To: u-boot, git
On 7/7/22 12:59, Michal Simek wrote:
> From: Michal Simek <michal.simek@xilinx.com>
>
> Just to make sure that dm commands can operate.
> This was the problem on Microblaze in past without fixing manual
> relocation.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> test/py/tests/test_dm.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/test/py/tests/test_dm.py b/test/py/tests/test_dm.py
> index 97203b536e17..ea93061fdfa8 100644
> --- a/test/py/tests/test_dm.py
> +++ b/test/py/tests/test_dm.py
> @@ -33,3 +33,11 @@ def test_dm_static(u_boot_console):
> response = u_boot_console.run_command('dm drivers')
> for driver in drivers:
> assert driver in response
> +
> +@pytest.mark.buildconfigspec("cmd_dm")
> +def test_dm_uclass(u_boot_console):
> + response = u_boot_console.run_command("dm uclass")
> +
> +@pytest.mark.buildconfigspec("cmd_dm")
> +def test_dm_devres(u_boot_console):
> + response = u_boot_console.run_command("dm devres")
Applied.
M
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-15 7:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 10:59 [PATCH] test/py: Run simple dm commands without checking Michal Simek
2022-07-12 10:58 ` Simon Glass
2022-07-12 11:21 ` Michal Simek
2022-07-15 7:59 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).